apt, branch 1.3_exp2 Debians commandline package manager https://git.kalnischkies.de/apt/atom?h=1.3_exp2 2016-06-11T15:25:20Z Release 1.3~exp2 2016-06-11T15:25:20Z Julian Andres Klode jak@debian.org 2016-06-11T15:24:13Z urn:sha1:5ff8dd6bd1c30c29a7398e339d3bdeaffe2f4489 don't leak FD in AutoProxyDetect command return parsing 2016-06-10T08:49:41Z David Kalnischkies david@kalnischkies.de 2016-06-09T22:01:46Z urn:sha1:8f858d560e3b7b475c623c4e242d1edce246025a Just closing the fd would be enough, but while we are at it we can also use the Popen interface to have an easier time with this. don't leak dpkg statusfd pipe in debugging 2016-06-10T08:49:41Z David Kalnischkies david@kalnischkies.de 2016-06-09T21:18:10Z urn:sha1:7977ed047f967b3e4b4091181acce3eaf7bd8176 Not a big deal to leak fds in debugging mode, but for completeness. Git-Dch: Ignore don't leak EDSP solver output fd 2016-06-10T08:49:41Z David Kalnischkies david@kalnischkies.de 2016-06-09T20:58:06Z urn:sha1:2202a8a05766586c60217d43193416dbd84be027 don't leak an FD in lz4 (de)compression 2016-06-10T08:49:34Z David Kalnischkies david@kalnischkies.de 2016-06-09T19:06:48Z urn:sha1:6f35be91c9e86e463bca7df6eadf05412c7b732c Seen first in #826783, but as this buglog also shows leaked uncompressed files as well we don't close it just yet. do not hang on piped input in PipedFileFdPrivate 2016-06-10T08:48:25Z David Kalnischkies david@kalnischkies.de 2016-06-09T18:41:58Z urn:sha1:bdc42211700ef0f6f40e4ef3f362e52d684d70fb This effects only compressors configured on the fly (rather then the inbuilt ones as they use a library). remove racy_pselect fallback 2016-06-09T10:23:59Z David Kalnischkies david@kalnischkies.de 2016-06-09T10:23:59Z urn:sha1:554bc997e4f619c72f883fd68cc896df96de58e5 The comment says it should have been removed with Lenny+1 which is a small while ago already, so it seems like a good time now… And as this is a cleanup commit it also gets right of spurious whitespace at the end of lines, adds missing fold markers and similar busy work. Git-Dch: Ignore drop Dpkg::MaxArgs in favor of Dpkg::MaxArgsBytes 2016-06-08T20:40:53Z David Kalnischkies david@kalnischkies.de 2016-06-08T20:40:53Z urn:sha1:c92ece1a7309d762bcf424f4ab0f1427d520d207 We had an old FIXME saying that it is probably pointless to do this if we limit by length of the commandline already and I completely agree. The splitting is bad enough if it must be done, so we should only do it if we have to (as in absolute length of commandline) and, but that is just a remark, it is unlikely that we ever have/had a call triggering this as the default value was ~32000 items… don't explicitly configure the last round of packages 2016-06-08T15:31:45Z David Kalnischkies david@kalnischkies.de 2016-06-08T15:31:45Z urn:sha1:b4450f1dd6bca537e60406b2383ab154a3e1485f We end our operation by calling "dpkg --configure -a", so instead of running a (big) configure run with all packages mentioned explicitly before this, we simply skip them and let them be handled by this call implicitly. There isn't really an observeable gain to be had here from a speed point, but it helps in avoiding an (uncommon) problem of having a too long commandline passed to dpkg, which we would split up (probably incorrectly). edsp: drop privileges before executing solvers 2016-06-08T15:27:19Z David Kalnischkies david@kalnischkies.de 2016-06-08T11:44:29Z urn:sha1:007d8b488787f4c33ced5937f22f99f1b759088a Most (if not all) solvers should be able to run perfectly fine without root privileges as they get the entire state they are supposed to work on via stdin and do not perform any action directly, but just pass suggestions on via stdout. The new default is to run them all as _apt hence, but each solver can configure another user if it chooses/must. The security benefits are minimal at best, but it helps preventing silly mistakes (see 35f3ed061f10a25a3fb28bc988fddbb976344c4d) and that is always good. Note that our 'apt' and 'dump' solver already dropped privileges if they had them.