apt, branch 1.3_pre1 Debians commandline package manager https://git.kalnischkies.de/apt/atom?h=1.3_pre1 2016-07-07T18:39:03Z Release 1.3~pre1 2016-07-07T18:39:03Z Julian Andres Klode jak@debian.org 2016-07-07T18:38:00Z urn:sha1:4bdf29d39c401ac479f6486469328fa648f9feab apt-key.8: Put (deprecated) into the term tag 2016-07-07T18:20:44Z Julian Andres Klode jak@debian.org 2016-07-07T18:20:44Z urn:sha1:ec51fe3ff619835a0e2e672112f42ad3293ee760 Now post-build script should no longer complain... Gbp-Dch: ignore keep trying with next if connection to a SRV host failed 2016-07-06T13:53:59Z David Kalnischkies david@kalnischkies.de 2016-07-06T12:49:39Z urn:sha1:3af3ac2f5ec007badeded46a94be2bd06b9917a2 Instead of only trying the first host we get via SRV, we try them all as we are supposed to and if that isn't working we try to connect to the host itself as if we hadn't seen any SRV records. This was already the intend of the old code, but it failed to hide earlier problems for the next call, which would unconditionally fail then resulting in an all around failure to connect. With proper stacking we can also keep the error messages of each call around (and in the order tried) so if the entire connection fails we can report all the things we have tried while we discard the entire stack if something works out in the end. report all instead of first error up the acquire chain 2016-07-06T13:53:59Z David Kalnischkies david@kalnischkies.de 2016-07-06T13:10:52Z urn:sha1:b50dfa6b2dd2d459e0c2746ac9367982b96ffac0 If we don't give a specific error to report up it is likely that all error currently in the error stack are equally important, so reporting just one could turn out to be confusing e.g. if name resolution failed in a SRV record list. don't change owner/perms/times through file:// symlinks 2016-07-06T00:25:51Z David Kalnischkies david@kalnischkies.de 2016-07-05T18:04:27Z urn:sha1:3465138575e1fd0d5892d9b6be1ae232eb873460 If we have files in partial/ from a previous invocation or similar such those could be symlinks created by file:// sources. The code is expecting only real files through and happily changes owner, modification times and permission on the file the symlink points to which tend to be files we have no business in touching in this way. Permissions of symlinks shouldn't be changed, changing owner is usually pointless to, but just to be sure we pick the easy way out and use lchown, check for symlinks before chmod/utimes. Reported-By: Mattia Rizzolo on IRC tests: disable EIPP logging in test-compressed-indexes 2016-07-05T18:45:47Z David Kalnischkies david@kalnischkies.de 2016-07-05T18:36:15Z urn:sha1:68151307d42ed64cd6258f94a0d748abe9efb8e0 The test makes heavy use of disabling compression types which are usually available some way or another like xz which is how the EIPP logs are compressed by default. Instead of changing this test to change the filename according to the compression we want to test we just disable EIPP logging for this test as that is easier and has the same practical effect. Gbp-Dch: Ignore EIPP/EDSP log can't be written is a warning, not an error 2016-07-05T18:44:45Z David Kalnischkies david@kalnischkies.de 2016-07-05T13:44:53Z urn:sha1:1b50bba6571661d1ddc1db808bd618bd0de3cae4 If other logs can't be written this is a warning to, so for consistency sake translate the errors to warnings. report write errors in EDSP/EIPP properly back to caller 2016-07-05T18:44:45Z David Kalnischkies david@kalnischkies.de 2016-07-05T13:40:23Z urn:sha1:5958c7497eea24d55ff305764f058ba1ae836200 Unlikely to happen in practice and I wonder more how I could miss these in earlier reviews, but okay, lets fix it for consistency now. give a descriptive error for pipe tries with 'false' 2016-07-05T18:44:45Z David Kalnischkies david@kalnischkies.de 2016-07-05T13:05:56Z urn:sha1:cc9745a0d81a3e1aa5ef6f99f7ad638d26bdb950 If libapt has builtin support for a compression type it will create a dummy compressor struct with the Binary set to 'false' as it will catch these before using the generic pipe implementation which uses the Binary. The catching happens based on configured Names through, so you can actually force apt to use the external binaries even if it would usually use the builtin support. That logic fails through if you don't happen to have these external binaries installed as it will fallback to calling 'false', which will end in confusing 'Write error's. So, this is again something you only encounter in constructed testing. Gbp-Dch: Ignore don't add default compressors two times if disabled 2016-07-05T18:44:45Z David Kalnischkies david@kalnischkies.de 2016-07-05T12:46:39Z urn:sha1:29b8e6b939bb7fcf0b2959545d8c822995c84118 This is in so far pointless as the first match will deal with the extension, so we don't actually ever use these second instances – probably for the better as most need arguments to behave as epected & more importantly: the point of the exercise disabling their use for testing proposes. Gbp-Dch: Ignore