apt, branch 2.1.5Debians commandline package managerhttps://git.kalnischkies.de/apt/atom?h=2.1.52020-05-26T10:20:42ZRelease 2.1.52020-05-26T10:20:42ZJulian Andres Klodejulian.klode@canonical.com2020-05-26T10:20:42Zurn:sha1:a5c65bce372375d40eb317e1a2b181cced54affaDutch manpages translation update2020-05-25T10:05:00ZFrans SpiesschaertFrans.Spiesschaert@yucom.be2020-05-24T18:42:43Zurn:sha1:abfed3e396b9cb3e0b45c1cfa04db38ac00a8171
Closes: #961431
Mark PatternTreeParser::Node destructor as virtual2020-05-25T10:05:00ZDavid Kalnischkiesdavid@kalnischkies.de2020-05-14T09:24:28Zurn:sha1:10f87f7e3f08335421fd60a2b49840289cd737de
The non-virtual base-destructor causes its derivate classes to leak
tiny bits of memory otherwise. The header is private and not to be
used outside of APT, so we can perform this tiny ABI break as there
is no ABI to break.
Reported-By: valgrind and clang -fsanitize=leak
Stub out i18n methods for -DUSE_NLS=OFF2020-05-25T10:05:00ZDavid Kalnischkiesdavid@kalnischkies.de2020-05-21T08:49:41Zurn:sha1:c378f9ee5746b06ead26793881b1449c53b1d7c6
Replacing the macros with stub inline functions allows for more
versatile usage, e.g. fixing this compile error:
In file included from /usr/include/x86_64-linux-gnu/c++/9/bits/c++locale.h:41,
from /usr/include/c++/9/bits/localefwd.h:40,
from /usr/include/c++/9/ios:41,
from /usr/include/c++/9/ostream:38,
from /usr/include/c++/9/iostream:39,
from include/apt-pkg/configuration.h:30,
from ../apt-pkg/contrib/netrc.cc:16:
/usr/include/c++/9/clocale:54:11: error: ‘::setlocale’ has not been declared
54 | using ::setlocale;
Gbp-Dch: Ignore
Allow FMV SSE4.2 detection to succeed on clang2020-05-25T10:05:00ZDavid Kalnischkiesdavid@kalnischkies.de2020-05-21T20:17:42Zurn:sha1:574249cd721a3cdbb79b6e457384a55827856b6a
As the builtins were used in the feature test also in the default branch
clang fails to compile the test helpfully complaining that you need to
compile with sse4.2 to use that while on gcc it is optimized out as
unused code and produces only a warning for that… removing the code from
the default branch fixes this problem, but we adapt the code some more to
avoid compilers optimizing it out in the future just in case.
Silence clang warning -Wstring-plus-int2020-05-25T10:05:00ZDavid Kalnischkiesdavid@kalnischkies.de2020-05-24T14:36:03Zurn:sha1:c3bfdbfa3ae868515a67142d2df6200a3cb34d35
../apt-pkg/init.cc:137:39: warning: adding 'int' to a string does not append to the string [-Wstring-plus-int]
Cnf.CndSet("Dir::State", STATE_DIR + 1);
../apt-pkg/init.cc:137:39: note: use array indexing to silence this warning
We have a few instances of that & it should be reasonably clear that we are not
actually trying to append here, but ignoring or silencing this warning with an
override is far more costly than just using what clang suggests here.
Reported-By: clang
Gbp-Dch: Ignore
Ensure EDSP doesn't use a dangling architecture string2020-05-25T10:05:00ZDavid Kalnischkiesdavid@kalnischkies.de2020-05-24T14:27:15Zurn:sha1:90a7a5e32643a67f4245460e7659d9dee230e9e7
../apt-pkg/edsp.cc:861:23: error: object backing the pointer will be destroyed at the end of the full-expression [-Wdangling-gsl]
const char *arch = _config->Find("APT::Architecture").c_str();
Compilers are probably optimizing it the way the patch does by hand now. Small
string optimisation helps likely as well. Othwise that should have failed left
and right as EDSP is used by experimental and such builders to talk to aspcud.
Reported-By: clang
Don't update candidate provides map if the same as current2020-05-25T10:05:00ZDavid Kalnischkiesdavid@kalnischkies.de2020-05-23T15:15:32Zurn:sha1:c77566fd8f21a1a44efb4092c90996d1cc8eaf24Don't set variables to conditionally override them 2 lines later2020-05-25T10:05:00ZDavid Kalnischkiesdavid@kalnischkies.de2020-05-23T14:55:59Zurn:sha1:0e5a9bf95d5b9b3c775ed3ce6142d35815a7c7ac
Gbp-Dch: Ignore
Allow pkgDepCache to be asked to check internal consistency2020-05-24T19:02:35ZDavid Kalnischkiesdavid@kalnischkies.de2020-05-23T14:22:44Zurn:sha1:2ba86f95bfad4ec00a3b99b311d05c158162b25c
For speed reasons pkgDepCache initializes its state once and then has a
battery of update calls you have to invoke in the right order to update
the various states – all in the name of speed. In debug and/or
simulation mode we can sacrifice this speed for a bit of extra checking
though to verify that we haven't made some critical mistake like #961266.