Debians commandline package manager https://git.kalnischkies.de/apt/atom?h=2.1.9 2020-08-10T12:16:47Z 2020-08-10T12:16:47Z Julian Andres Klode julian.klode@canonical.com 2020-08-10T12:16:47Z urn:sha1:f21440f5af98e1b5987e040a8f25bc3c2d6b7831 2020-08-10T12:15:02Z Julian Andres Klode jak@debian.org 2020-08-10T12:15:02Z urn:sha1:fc0fcaca622c0d075499c337451e76b905c5e024 http: Fix infinite loop on read errors See merge request apt-team/apt!126 2020-08-10T09:59:49Z Aleix Vidal i Gaya aleix.vidal@gmail.com 2020-08-10T09:59:37Z urn:sha1:3921bdfec6926c5db6d052683a21339c76fb8600 See merge request !127 for more information. 2020-08-10T09:39:30Z Julian Andres Klode julian.klode@canonical.com 2020-08-10T09:39:30Z urn:sha1:fa375493c5a4ed9c10d4e5257ac82c6e687862d3 While we fixed the infinite retrying earlier, we still have problems if we retry in the middle of a transfer, we might end up resuming downloads that are already done and read more than we should (removing the IsOpen() check so that it always retries makes test-ubuntu-bug-1098738-apt-get-source-md5sum fail with wrong file sizes). I think the retrying was added to fixup pipelining messups, but we have better solutions now, so let's get rid of it, until we have implemented this properly. 2020-08-05T12:15:49Z Julian Andres Klode julian.klode@canonical.com 2020-08-05T12:14:19Z urn:sha1:4b439208203cd584e158fd240a3a4a72d1248099 When we failed after a retry, we only communicated failure as transient, but this seems wrong, especially given that the code now always triggers a retry when Die() is called, as Die() closes the server fd. Instead, remove the error handling in that code path, and reuse the existing fatal-ish error code handling path. 2020-08-05T09:08:16Z Julian Andres Klode julian.klode@canonical.com 2020-08-05T09:04:45Z urn:sha1:ded246bb61b9b0f4ca658be45c1691844e1dc122 If there was a transient error and the server fd was closed, the code would infinitely retry - it never reached FailCounter >= 2 because it falls through to the end of the loop, which sets FailCounter = 0. Add a continue just like the DNS rotation code has, so that the retry actually fails after 2 attempts. Also rework the error logic to forward the actual error message. 2020-08-04T10:41:38Z Julian Andres Klode julian.klode@canonical.com 2020-08-04T10:40:27Z urn:sha1:8761d5a714819f14c62879d1f705e95b270c5d99 2020-08-04T10:34:38Z Julian Andres Klode jak@debian.org 2020-08-04T10:34:38Z urn:sha1:7d222636954ec95382149e31b314e9828ba05a2e Pu/http fixes 2 See merge request apt-team/apt!125 2020-08-04T10:16:36Z Julian Andres Klode jak@debian.org 2020-08-04T10:16:36Z urn:sha1:63c0657ea54c9268bc1855d5eac92bc636532bd6 Support marking all newly installed packages as automatically installed See merge request apt-team/apt!110 2020-08-04T10:12:30Z Julian Andres Klode jak@debian.org 2020-08-04T10:12:30Z urn:sha1:11530bab64efd4b4fc46de7833533cea9c69f521 Remove master/slave terminology See merge request apt-team/apt!124