Debians commandline package manager https://git.kalnischkies.de/apt/atom?h=2.3.0 2021-03-08T10:51:58Z 2021-03-08T10:51:58Z Julian Andres Klode julian.klode@canonical.com 2021-03-08T10:51:58Z urn:sha1:ade9d3c41da55171f258a3aeed2e3b3350da8920 2021-03-08T09:21:06Z Julian Andres Klode jak@debian.org 2021-03-08T09:21:06Z urn:sha1:fbc06b381d14cfa9e2efb4b437b2ce1419e4f1a4 Deal with rred shortcomings around empty patch files See merge request apt-team/apt!159 2021-03-07T01:55:07Z David Kalnischkies david@kalnischkies.de 2021-03-06T15:11:34Z urn:sha1:2a81f98b124d8fe551b160df55db1d3bf79a77c1 The mirror method can distribute requests for files based on various metadata bits, but some – the main index files – weren't actually passing those on to the methods as advertised in the manpage. This is hidden both by mirror usually falling back to other sources which will eventually hit the right one and that if the repository does not support by-hash apt will automatically stick to the mirror which was used for the Release file. 2021-03-07T01:55:07Z David Kalnischkies david@kalnischkies.de 2021-03-06T23:47:26Z urn:sha1:59933938f51105066161a6eb88253006826336a2 Especially in small sections of an archive it can happen that an index returns to a previous state (e.g. if a package was first added and then removed with no other changes happening in between). The result is that we have multiple patches which start from the same hash which if we perform clientside merging is no problem although not ideal as we perform needless work. For serverside merging it would not matter, but due to rred previously refusing to merge zero-size patches but dak ignoring failure letting it carry these size-zero patches until they naturally expire we run into a problem as these broken patches won't do and force us to fall back to downloading the entire index. By always starting from the last patch instead of the first with the starter hash we can avoid this problem and behave optimally in clientside merge cases, too. 2021-03-07T01:55:07Z David Kalnischkies david@kalnischkies.de 2021-03-06T18:55:09Z urn:sha1:246f66561e23911b9615bd337b3b6f6f25b6cd31 The rred method expects the patches to have a certain name, which we have to rename the file to before calling the method, but by delaying the rename we ensure that if the download of one of them fails and a successful fallback occurs they are all properly cleaned up as no longer useful while in the error case the next apt run can potentially pick them up as already downloaded. Our test-pdiff-usage test was encountering this every other run, but did not fail as the check for unaccounted files in partial/ was wrapped in a subshell so that the failure produced failing output, but did not change the exit code. 2021-03-06T14:02:26Z David Kalnischkies david@kalnischkies.de 2021-03-06T14:02:26Z urn:sha1:9bd27033c4786fa89cebc9d090ad2c6e8f47b598 There isn't a lot of sense in working on empty patches as they change nothing (quite literally), but they can be the result of merging multiple patches and so to not require our users to specifically detect and remove them, we can be nice and just ignore them instead of erroring out. 2021-03-01T21:30:05Z Julian Andres Klode julian.klode@canonical.com 2021-03-01T21:30:05Z urn:sha1:3a7aecd232dfdbcec5dbdc3af16e03479d47d917 This reverts commit d96c9a0280bffcfb0f4a319e003e9af60c6cfaf1. It is not correct for master. 2021-03-01T21:29:12Z Julian Andres Klode julian.klode@canonical.com 2021-03-01T21:29:12Z urn:sha1:757304ce49f7b9335132be53e8162cce89e85033 apt Debian release 2.2.1 2021-03-01T21:28:15Z Julian Andres Klode julian.klode@canonical.com 2021-03-01T21:28:15Z urn:sha1:16b905aabc9b8700b937dd1541d52ea0df2f3a0e 2021-03-01T20:43:54Z Julian Andres Klode julian.klode@canonical.com 2021-03-01T20:43:03Z urn:sha1:0d51cf142884801c903df0cddaec5545f0174553 Conflicts do require removing the package temporarily, so they really should not be used. We need to improve that eventually such that we can deconfigure packages when we have to remove their dependencies due to conflicts.