apt, branch 2.9.34Debians commandline package managerhttps://git.kalnischkies.de/apt/atom?h=2.9.342025-03-20T21:51:37ZRelease 2.9.342025-03-20T21:51:37ZJulian Andres Klodejulian.klode@canonical.com2025-03-20T21:51:37Zurn:sha1:2a6c9bd8c0f8f50671bf7992f1e5d87b392e0336Merge branch 'solver3' into 'main'2025-03-20T21:44:05ZJulian Andres Klodejak@debian.org2025-03-20T21:44:05Zurn:sha1:fbb202b34df162eb19e9035683800e704cd17e6a
solver3: Handle previously satisfied Suggests last
See merge request apt-team/apt!467solver3: Do not install new packages for Suggests2025-03-20T21:22:17ZJulian Andres Klodejulian.klode@canonical.com2025-03-20T20:15:14Zurn:sha1:81804cefd8c24c98e7a0216a9d4277516e19b6e2
As a followup to the previous commit, restore the exact behavior
of the old solver to break the Suggests on upgrade here by erasing
any choices not previously installed.
This ensures that the Suggests never installs any new package, but
it will still retain previously installed packages when solver3 is
doing autoremove.
solver3: Handle previously satisfied Suggests last2025-03-20T21:22:17ZJulian Andres Klodejulian.klode@canonical.com2025-03-20T19:47:28Zurn:sha1:83bad834c63604035c251f24ee9ea99dac1a1369
In #2103556 we can see that avahi-daemon Suggests avahi-autoipd,
which is previously satisfied by dhcpcd-base due to a Provides;
that Provides has now been dropped; and solver3 keeps the update
back.
As in LP: #2102720 this is a Suggests and it seems wrong for the
Suggests to actually influence dependency choices and be able to
hold back updates.
Instead, satisfy previously satisfied Suggests at the end. For the
particular case in this bug report, this results in avahi-autoipd,
the real package, to be installed to keep the Suggests working
which needs further consideration whether that is the right choice
(we can argue either way), but in any case this is a better solution.
This in turn breaks the conkeror test which is a somewhat awkward
unrealistic test these days as it has no automatically installed
packages; because previously something must have had a Suggests
on say libdatrie1 or something that was processed first.
This would be fine before 5daf6dbfd272be2f8e3c59d4bab4be8c119b7aa1
but as of that commit we no longer rewrite
conkeror Depends xulrunner-1.9 | xulrunner-1.9.1
into
conkeror Depends xulrunner-1.9.1 | xulrunner-1.9
Because xulrunner-1.9 is manually installed. Mark xulrunner-1.9
as automatically installed to fix the test case.
The resulting behavior seems correct: If you manually want
xulrunner-1.9 specifically we should not replace it with
xulrunner-1.9.1; but if it's automatically installed we should.
LP: #2103556
Merge branch 'solver3' into 'main'2025-03-20T14:51:10ZJulian Andres Klodejak@debian.org2025-03-20T14:51:10Zurn:sha1:fff3dddedba0d19d722cb4889bab355182cc2522
Various solver bug fixes
See merge request apt-team/apt!466solver3: Avoid empty error message in evaluation crash report2025-03-20T14:18:05ZJulian Andres Klodejulian.klode@canonical.com2025-03-20T14:16:58Zurn:sha1:61b3b1840568b223baad08da1eb9a1fb5d6e7f91
whoopsie does not accept empty values
solver3: Use zstd-compressed, base64-encoded dumps2025-03-20T14:09:56ZJulian Andres Klodejulian.klode@canonical.com2025-03-20T14:03:23Zurn:sha1:a2cb87afcbc89d1f8e770c26121a75d9c1654458
Store the solver dumps with zstd compression and base64-encode
them in the crash report; such that they take up significantly
less space and can fit in cassandra's schema.
Base64 is wrapped at 76 characters as the base64 tool does. Do
some magic std::string_view conversion to avoid string copies
for the substr() used to get 76 characters at a time.
Note we can rely on substr(i, 76) to handle less than 76 characters
just fine; it uses std::min(76, size() - i) characters.
solver3: Record manual flag before discovering packages2025-03-20T13:32:42ZJulian Andres Klodejulian.klode@canonical.com2025-03-20T13:30:54Zurn:sha1:109fdcac9a16ffa06b06366134dcaaef7e2b3379
When discovering packages we look at the manual flag to avoid
reordering obsolete manually installed packages last.
We inadvertently initialized that flag interlaced with discovering
packages so if we discovered packages depending on obsolete, but
manually installed, packages first, we were not aware they were
manually installed and demoted them.
I am struggling to come up with a test case for this as I can't
get the package objects in the cache to be in the right order for
the bug to trigger.
LP: #2102720
Merge branch 'smaller-dumps' into 'main'2025-03-20T09:27:08ZJulian Andres Klodejak@debian.org2025-03-20T09:27:08Zurn:sha1:7ef14b64596bd0ca78feaea5fda22b8d524de286
Write minimized EDSP dumps in crash report, Dir::log::solver
See merge request apt-team/apt!465edsp: Dump minimized Dir::Log::Solver logs2025-03-20T09:26:51ZJulian Andres Klodejulian.klode@canonical.com2025-03-13T14:55:50Zurn:sha1:8ed6bea2083e055b50dfbd8bebf1355cce502f3f