apt, branch mainDebians commandline package managerhttps://git.kalnischkies.de/apt/atom?h=main2024-04-26T20:10:30ZAllow parsing an empty Provides line2024-04-26T20:10:30ZDavid Kalnischkiesdavid@kalnischkies.de2024-04-26T18:50:49Zurn:sha1:c98bcdf00e5366fec101dd17094d36be21872a02
If dpkg-gencontrol was involved in the creation of a package we will not
usually encounter empty or otherwise useless fields, but apparently not
everyone is using it.
It isn't recommended to have these empty lines, but it isn't too hard to
ignore for Provides as we did for dependencies already and apt-ftparchive
can be convinced to produce empty files (if you feed it such a package)
as well, so lets be nice and provide users with a more accepting parser.
Closes: #1069874
Merge branch 'fix/mixed' into 'main'2024-04-26T11:01:17ZJulian Andres Klodejak@debian.org2024-04-26T11:01:17Zurn:sha1:05a1ee0cf4d5948ec2a084629bb9712af7d9c475
Split out of mostly independent fixes: cmake execute errors, removed rev-deps, protected garbage & co
See merge request apt-team/apt!345Add test for dealing with unsat Suggests promoted to Recommends2024-04-24T13:16:21ZDavid Kalnischkiesdavid@kalnischkies.de2024-04-04T13:36:24Zurn:sha1:7a1063e81b855ac7ff9ee54f115843c3af6dd1bf
Our code does the right thing currently, so lets add a test to ensure
this keeps being the case in the future.
Drop sudo-related envvars in testing framework2024-04-24T13:16:21ZDavid Kalnischkiesdavid@kalnischkies.de2024-04-23T16:13:46Zurn:sha1:9c06578c37ff77b70b9d978d48528df13e13530f
Our autoremoval-advertisment is modified by SUDO_USER as if the current
apt call was made with sudo it seems a good idea to show the ad with
sudo as well. That is annoying for our tests through as normally the
tests are run locally or by autopkgtest without sudo, but in Gitlab CI
we use it (to run our tests as user… as we are already root) and so
individual tests had to deal with this.
That is annoying and really not needed as we can have our autoremove
test check that this ad gets displayed the right way and ignore it the
rest of the time.
Do not upgrade rev-deps ear-marked for removal2024-04-24T13:16:21ZDavid Kalnischkiesdavid@kalnischkies.de2024-03-14T20:59:10Zurn:sha1:d030a1041b243c45dcd41e34d3c2b21cf1a533ba
We schedule reverse dependencies for an upgrade, but we shouldn't do it
if we have ear-marked this package for removal later on. Usually the
solver will end up doing the right thing like it already did in the
included testcase in the end, but given that before it reaches the right
end it explored a bad path which can lead to more installs and removals
influencing later decisions or are just too hard for the resolver to
undo later on, we can just not explore this path to begin with.
References: e077370ffcb3669a50a600e80356c2002e6b176d
Match version constraints before saving garbage packages2024-04-24T13:16:21ZDavid Kalnischkiesdavid@kalnischkies.de2024-04-03T19:12:01Zurn:sha1:e099ee946000797f4c03b8c5075ce7ebba193337
We remove new garbage packages from the solution if we can as installing
a new package which is at the same time considered garbage looks silly,
but it could also be a new dependency of another garbage package, so we
have a second round trying to save such packages. In this round we
weren't considering versioned constraints on dependency relations through
so even an unsatisfied old recommends could save which it shouldn't.
Avoid figuring which kept pkgs are phased if we don't display it2024-04-24T13:16:21ZDavid Kalnischkiesdavid@kalnischkies.de2024-04-03T12:36:40Zurn:sha1:7d93bcabc3f2c47c093faae7b36b7709f287cce2
Not all commands show kept back packages, so even if it hardly matters,
lets not crunch numbers needlessly if we don't need the info which also
reduces the lifetime of the involved variables hopefully also reducing
the mental requirements for a reader.
Do not ignore if a cmake execute_process fails2024-04-24T13:16:21ZDavid Kalnischkiesdavid@kalnischkies.de2024-04-05T14:02:39Zurn:sha1:3e24f431d9527816820e103df7db9f39062b551d
Ignoring errors might lead to failures later on anyhow, but especially
with triehash it could also lead to broken builds or other crazy stuff,
so lets better be save than sorry.
The text of notices and audits shall not be bold2024-04-23T19:02:30ZJulian Andres Klodejulian.klode@canonical.com2024-04-23T19:01:45Zurn:sha1:edfbc3869361f709d70794a794199ac2076ea9f1
This turned out to be a bit too bold for most of them, given their
informational nature.
Highlight essential removals with action::remove color2024-04-23T18:32:30ZJulian Andres Klodejulian.klode@canonical.com2024-04-23T18:32:17Zurn:sha1:d4889a909632f38418c630f257c00ccc595ba572