apt/apt-pkg/acquire-method.cc, branch 1.2.10Debians commandline package managerhttps://git.kalnischkies.de/apt/atom?h=1.2.102016-01-26T14:32:15Zact on various suggestions from cppcheck2016-01-26T14:32:15ZDavid Kalnischkiesdavid@kalnischkies.de2016-01-25T21:13:52Zurn:sha1:2651f1c071927b7fc440ec7a638ecad7ccf04a2e
Reported-By: cppcheck
Git-Dch: Ignore
make all d-pointer * const pointers2015-08-10T15:25:25ZDavid Kalnischkiesdavid@kalnischkies.de2015-06-17T07:29:00Zurn:sha1:6c55f07a5fa3612a5d59c61a17da5fe640eadc8b
Doing this disables the implicit copy assignment operator (among others)
which would cause hovac if used on the classes as it would just copy the
pointer, not the data the d-pointer points to. For most of the classes
we don't need a copy assignment operator anyway and in many classes it
was broken before as many contain a pointer of some sort.
Only for our Cacheset Container interfaces we define an explicit copy
assignment operator which could later be implemented to copy the data
from one d-pointer to the other if we need it.
Git-Dch: Ignore
add d-pointer, virtual destructors and de-inline de/constructors2015-06-16T14:22:46ZDavid Kalnischkiesdavid@kalnischkies.de2015-06-16T14:22:46Zurn:sha1:c8a4ce6cbed57ae108dc955d4a850f9b129a0693
To have a chance to keep the ABI for a while we need all three to team
up. One of them missing and we might loose, so ensuring that they are
available is a very tedious but needed task once in a while.
Git-Dch: Ignore
check patch hashes in rred worker instead of in the handler2015-06-09T10:57:36ZDavid Kalnischkiesdavid@kalnischkies.de2015-06-06T17:16:45Zurn:sha1:3679515479136179e0d95325a6559fcc6d0af7f8
rred is responsible for unpacking and reading the patch files in one go,
but we currently only have hashes for the uncompressed patch files, so
the handler read the entire patch file before dispatching it to the
worker which would read it again – both with an implicit uncompress.
Worse, while the workers operate in parallel the handler is the central
orchestration unit, so having it busy with work means the workers do
(potentially) nothing.
This means rred is working with 'untrusted' data, which is bad. Yet,
having the unpack in the handler meant that the untrusted uncompress was
done as root which isn't better either. Now, we have it at least
contained in a binary which we can harden a bit better. In the long run,
we want hashes for the compressed patch files through to be safe.
rework hashsum verification in the acquire system2015-06-09T10:57:35ZDavid Kalnischkiesdavid@kalnischkies.de2015-06-06T10:28:00Zurn:sha1:448c38bdcd72b52f11ec5f326f822cf57653f81c
Having every item having its own code to verify the file(s) it handles
is an errorprune process and easy to break, especially if items move
through various stages (download, uncompress, patching, …). With a giant
rework we centralize (most of) the verification to have a better
enforcement rate and (hopefully) less chance for bugs, but it breaks the
ABI bigtime in exchange – and as we break it anyway, it is broken even
harder.
It shouldn't effect most frontends as they don't deal with the acquire
system at all or implement their own items, but some do and will need to
be patched (might be an opportunity to use apt on-board material).
The theory is simple: Items implement methods to decide if hashes need to
be checked (in this stage) and to return the expected hashes for this
item (in this stage). The verification itself is done in worker message
passing which has the benefit that a hashsum error is now a proper error
for the acquire system rather than a Done() which is later revised to a
Failed().
do not inline virtual destructors with d-pointers2014-10-13T09:29:39ZDavid Kalnischkiesdavid@kalnischkies.de2014-10-13T06:05:57Zurn:sha1:862bafea48af2ceaf96345db237b461307a021f6
Reimplementing an inline method is opening a can of worms we don't want
to open if we ever want to us a d-pointer in those classes, so we do the
only thing which can save us from hell: move the destructors into the cc
sources and we are good.
Technically not an ABI break as the methods inline or not do the same
(nothing), so a program compiled against the old version still works
with the new version (beside that this version is still in experimental,
so nothing really has been build against this library anyway).
Git-Dch: Ignore
Merge remote-tracking branch 'mvo/feature/expected-size' into debian/experimental2014-10-08T06:37:01ZMichael Vogtmvo@ubuntu.com2014-10-08T06:37:01Zurn:sha1:0c158e03ceb509a08d3d4ded79c3151237f669ddMerge remote-tracking branch 'mvo/feature/acq-trans' into debian/experimental2014-10-08T06:36:53ZMichael Vogtmvo@ubuntu.com2014-10-08T06:36:53Zurn:sha1:a943fbf21ca0b9b58b8f1492fc518679b1d7c749Merge remote-tracking branch 'donkult/feature/acq-trans' into feature/expected-size2014-10-08T06:05:18ZMichael Vogtmvo@ubuntu.com2014-10-08T06:05:18Zurn:sha1:676700504710013d6737f79bf6ad12003d55c30ddo not show IP in output of testcases2014-10-07T21:52:12ZDavid Kalnischkiesdavid@kalnischkies.de2014-10-07T21:52:12Zurn:sha1:0045df3fc7c3c1dba084682805b50203472d443f
On travis-ci connect.cc detects a rotation, triggering it store the IP
which is later appended to the error message, which is all nice and
great if we deal with a real server, but in the testcases it just
triggers failures as strings do not match.
Git-Dch: Ignore