apt/apt-pkg/acquire-worker.cc, branch 1.3_rc2 Debians commandline package manager https://git.kalnischkies.de/apt/atom?h=1.3_rc2 2016-08-17T05:55:45Z check internal redirections for loops, too 2016-08-17T05:55:45Z David Kalnischkies david@kalnischkies.de 2016-08-14T10:13:59Z urn:sha1:18ccc85f02325ac87ee13bb96c92594fcfda5ea4 Now that we have the redirections loopchecker centrally in our items we can use it also to prevent internal redirections to loop caused by bugs as in a few instances we get into the business of rewriting the URI we will query by ourself as we predict we would see such a redirect anyway. Our code has no bugs of course, hence no practical difference. ;) Gbp-Dch: Ignore log with the failed item description, not with next try 2016-08-16T17:20:28Z David Kalnischkies david@kalnischkies.de 2016-08-14T07:51:56Z urn:sha1:850ad02657c096fb227b38ef6d691fcf20acd619 The failure handling frequently changes URI & Description of the failed item to try a slightly different combination which might work, but the logging of the failure happens only afterwards as the same failure handling decides if this is a critical error or not so we need a backup here instead of potentially new content. A purely cosmetic issue, but can still be confusing for humans. allow methods to be disabled and redirected via config 2016-08-10T21:19:44Z David Kalnischkies david@kalnischkies.de 2016-08-06T17:59:57Z urn:sha1:c9c910695185b59aa27b787c1a250497e47b492b To prevent accidents like adding http-sources while using tor+http it can make sense to allow disabling methods. It might even make sense to allow "redirections" and adding "symlinked" methods via configuration. This could e.g. allow using different options for certain sources by adding and configuring a "virtual" new method which picks up the config based on the name it was called with like e.g. http does if called as tor+http. detect redirection loops in acquire instead of workers 2016-08-10T21:19:44Z David Kalnischkies david@kalnischkies.de 2016-08-02T20:44:50Z urn:sha1:57401c48fadc0c78733a67294f9cc20a57e527c9 Having the detection handled in specific (http) workers means that a redirection loop over different hostnames isn't detected. Its also not a good idea have this implement in each method independently even if it would work suggest transport-packages based on established namescheme 2016-08-10T21:19:44Z David Kalnischkies david@kalnischkies.de 2016-08-01T15:52:55Z urn:sha1:d0ef571416e1ff6266c89e6285898d269768cf8f apt-transports not shipped in apt directly are usually named apt-transport-% with % being what is in the name of the transport. tor additional introduced aliases via %+something, which isn't a bad idea, so be strip the +something part from the method name before suggesting the installation of an apt-transport-% package. This avoids us the maintainance of a list of existing transports creating a two class system of known and unknown transports which would be quite arbitrary and is unfriendly to backports. add insecure (and weak) allow-options for sources.list 2016-06-22T12:05:01Z David Kalnischkies david@kalnischkies.de 2016-06-20T18:50:43Z urn:sha1:d03b947b0ce4f87d7d5cc48d4d274ab3bd0b289a Weak had no dedicated option before and Insecure and Downgrade were both global options, which given the effect they all have on security is rather bad. Setting them for individual repositories only isn't great but at least slightly better and also more consistent with other settings for repositories. better error message for insufficient hashsums 2016-06-22T12:05:01Z David Kalnischkies david@kalnischkies.de 2016-06-18T11:55:39Z urn:sha1:562f0774f8f04d978c7cea69a29c131a0e0ec75f Downloading and saying "Hash Sum mismatch" isn't very friendly from a user POV, so with this change we try to detect such cases early on and report it, preferably before download even started. Closes: 827758 allow redirection for items without a space in the desc again 2016-05-03T21:37:43Z David Kalnischkies david@kalnischkies.de 2016-05-03T21:22:53Z urn:sha1:84ac6edfabe1c92d67e8d441e04216ad33c89165 Broken in a4b8112b19763cbd2c12b81d55bc7d43a591d610. If an item has a description which includes no space and is redirected to another mirror the code which wants to rewrite the description expects a space in there, but can't find it and the unguarded substr command on the string will fail with an exception thrown… Guarding it properly and everything is fine. show more details for "Writing more data" errors, too 2016-04-25T13:35:52Z David Kalnischkies david@kalnischkies.de 2016-04-24T08:35:08Z urn:sha1:30979dd7616105302f06af82f419eb62d7b613f8 They are the small brothers of the hashsum mismatch, so they deserve a similar treatment even through we have for architectual reasons not a much to display as for hashsum mismatches for now. show more details for "Hash Sum mismatch" errors 2016-04-25T13:35:52Z David Kalnischkies david@kalnischkies.de 2016-03-12T19:29:04Z urn:sha1:0340069cc4709a18ba117090763d9f263de999a9 Users tend to report these errors with just this error message… not very actionable and hard to figure out if this is a temporary or 'permanent' mirror-sync issue or even the occasional apt bug. Showing the involved hashsums and modification times should help in triaging these kind of bugs – and eventually we will have less of them via by-hash. The subheaders aren't marked for translation for now as they are technical glibberish and probably easier to deal with if not translated. After all, our iconic "Hash Sum mismatch" is translated at least. These additions were proposed in #817240 by Peter Palfrader.