apt/apt-pkg/acquire-worker.cc, branch 2.1.19

Keep URIs encoded in the acquire system

2020-12-18T18:31:19Z

We do not deal a lot with URIs which need encoding, but then we do it is a pain that we store it decoded in the acquire system as it means we have to decode and reencode URIs eventually which is potentially giving us slightly different URIs. We see that in our own testing framework while setting up redirects as the config options are effectively double-encoded and decoded to pass them around successfully as otherwise %2f and / in an URI are treated the same. This commit adds the infrastructure for methods to opt into getting URIs send in encoded form (and returning them to us in encoded form, too) so that we eventually do not have to touch the URIs which is how it should be. This means though that we have to deal with methods who do not support this yet (aka: all at the moment) for which we decode and encode while communicating with them.

Drop pkgAcquire::Item::ModifyRetries() ABI hack

2020-02-26T13:10:47Z

apt-pkg: URI: Add 'explicit' to single argument constructor

2019-04-30T15:43:56Z

This needs a fair amount of changes elsewhere in the code, hence this is separate from the previous commits.

acq: worker: Move CurrentSize, TotalSize, ResumePoint to CurrentItem

2019-04-30T15:40:38Z

These status fields belong to the current item, move them there. This prepares us for eventually having multiple current items.

Disable deprecated methods (ftp, rsh, ssh) by default

2019-01-31T15:21:04Z

These methods are not supposed to be used anymore, they are not actively maintained and may hence contain odd bugs. Fixes !49

Drop alternative URIs we got a hash-based fail from

2018-05-11T16:28:19Z

If we got a file but it produced a hash error, mismatched size or similar we shouldn't fallback to alternative URIs as they likely result in the same error. If we can we should instead use another mirror. We used to be a lot stricter by stopping all trys for this file if we got a non-404 (or a hash-based) failure, but that is too hard as we really want to try other mirrors (if we have them) in the hope that they have the expected and correct files.

Remove obsolete RCS keywords

2018-05-07T11:41:31Z

Prompted-by: Jakub Wilk

Fix various typos reported by spellcheckers

2018-05-04T22:34:27Z

Reported-By: codespell & spellintian Gbp-Dch: Ignore

require methods to request AuxRequest capability at startup

2018-01-03T18:42:45Z

Allowing a method to request work from other methods is a powerful capability which could be misused or exploited, so to slightly limited the surface let method opt-in into this capability on startup.

reimplement and simplify mirror:// method

2018-01-03T17:55:41Z

Embedding an entire acquire stack and HTTP logic in the mirror method made it rather heavy weight and fragile. This reimplement goes the other way by doing only the bare minimum in the method itself and instead redirect the actual download of files to their proper methods. The reimplementation drops the (in the real world) unused query-string feature as it isn't really implementable in the new architecture.