apt/apt-pkg/algorithms.cc, branch 2.1.3

Recognize propagated protected in pkgProblemResolver

2020-05-18T13:55:36Z

Turns out that pkgDepCache and pkgProblemResolver maintain two (semi) independent sets of protected flags – except that a package if marked protected in the pkgProblemResolver is automatically also marked in the pkgDepCache as protected. This way the pkgProblemResolver will have as protected only the direct user requests while pkgDepCache will (hopefully) propagate the flag to unavoidable dependencies of these requests nowadays. The pkgProblemResolver was only checking his own protected flag though and based on that calls our Mark* methods usually without checking return, leading to it believing it could e.g. remove packages it actually can't remove as pkgDepCache will not allow it as it is marked as protected there. Teaching it to check for the flag in the pkgDepCache instead avoids it believing in the wrong things eventually giving up. The scoring is keeping the behaviour of adding the large score boost only for the direct user requests though as there is no telling which other sideeffects this might have if too many packages get too many points from the get-go. Second part of fixing #960705, now with pkgProblemResolver output which looks more like the whole class of problem is resolved rather than a teeny tiny edgecase it was before.

Rename pkgSimulate::Go2 to pkgSimulate::Go

2020-02-26T13:10:47Z

algorithms: Remove deprecated ProblemResolver::InstallProtect()

2019-02-26T15:31:20Z

Remove obsolete RCS keywords

2018-05-07T11:41:31Z

Prompted-by: Jakub Wilk

Fix various typos reported by spellcheckers

2018-05-04T22:34:27Z

Reported-By: codespell & spellintian Gbp-Dch: Ignore

Reformat and sort all includes with clang-format

2017-07-12T11:57:51Z

This makes it easier to see which headers includes what. The changes were done by running git grep -l '#\s*include' \ | grep -E '.(cc|h)$' \ | xargs sed -i -E 's/(^\s*)#(\s*)include/\1#\2 include/' To modify all include lines by adding a space, and then running ./git-clang-format.sh.

Drop cacheiterators.h include

2017-07-12T11:56:05Z

Including cacheiterators.h before pkgcache.h fails because pkgcache.h depends on cacheiterators.h.

avoid explicit types for pkg counts by auto

2017-06-26T21:31:15Z

Changes nothing on the program front and as the datatypes are sufficently comparable fixes no bug either, but problems later on if we ever change the types of those and prevent us using types which are too large for the values we want to store waste (a tiny bit of) resources. Gbp-Dch: Ignore

algorithms: Fix typo: gental -> gentle

2017-01-30T23:57:58Z

Oh dear, nobody (or rather no tool) saw that yet... Gbp-Dch: ignore

fix various typos reported by spellintian

2017-01-19T14:59:38Z

Most of them in (old) code comments. The two instances of user visible string changes the po files of the manpages are fixed up as well. Gbp-Dch: Ignore Reported-By: spellintian