apt/apt-pkg/cacheiterators.h, branch 1.7.0_alpha1Debians commandline package managerhttps://git.kalnischkies.de/apt/atom?h=1.7.0_alpha12018-05-11T15:58:46ZDeprectate buggy/incorrect Rls/PkgFile::IsOk methods2018-05-11T15:58:46ZDavid Kalnischkiesdavid@kalnischkies.de2018-04-11T10:45:38Zurn:sha1:c5e2fa2b772524c03b0c7f777ffea6f2485fe6ca
With the advent of compressed files and especially with in-memory
post-processed files the simple assumptions made in IsOk are no longer
true. Worse, they are at best duplicates of checks performed by the
cache generation (and validation) earlier and isn't used in too many
places. It is hence best to simply get right of these calls instead of
trying to fix them.
convert various c-style casts to C++-style2017-12-13T22:53:34ZDavid Kalnischkiesdavid@kalnischkies.de2017-12-13T12:26:38Zurn:sha1:957381a0d26ec11a172ebfc64f892d1b31f0c193
gcc was warning about ignored type qualifiers for all of them due to the
last 'const', so dropping that and converting to static_cast in the
process removes the here harmless warning to avoid hidden real issues in
them later on.
Reported-By: gcc
Gbp-Dch: Ignore
cacheiterators: Warn about direct include and don't include pkgcache.h2017-07-12T12:07:27ZJulian Andres Klodejak@debian.org2017-07-12T12:07:27Zurn:sha1:51da6127d0073c9fc81f4b220f2360bd612ded5c
This adds a warning so existing working code will still
work (as it includes pkgcache.h first anyway), but it will
know that it's not right to include this file directly.
Reformat and sort all includes with clang-format2017-07-12T11:57:51ZJulian Andres Klodejak@debian.org2017-07-12T11:40:41Zurn:sha1:87274d0f22e1dfd99b2e5200e2fe75c1b804eac3
This makes it easier to see which headers includes what.
The changes were done by running
git grep -l '#\s*include' \
| grep -E '.(cc|h)$' \
| xargs sed -i -E 's/(^\s*)#(\s*)include/\1#\2 include/'
To modify all include lines by adding a space, and then running
./git-clang-format.sh.
factor out Pkg/DepIterator prettyprinters into own header2016-04-28T08:08:32ZDavid Kalnischkiesdavid@kalnischkies.de2016-04-28T07:22:55Zurn:sha1:84573326f41dd09b914b8374548e7ee7c93d0439
The old prettyprinters have only access to the struct they pretty print,
which isn't enough usually as we want to know for a package also a bit
of state information like which version is the candidate.
We therefore need to pull the DepCache into context and hence use a
temporary struct which is printed instead of the iterator itself.
deprecate confusing Pkg.CandVersion() method2016-04-28T08:08:32ZDavid Kalnischkiesdavid@kalnischkies.de2016-04-28T07:06:39Zurn:sha1:29636cc759c6fbb92c6c462c90611eefb67cbbd4
This method does not return the 'current' candidate of the DepCache
which would be most expected, but instead returns the version which
would be candidate in a default-only policy setting – aka ignoring
apt_preferences settings and co.
Switch performance critical code to use APT::StringView2016-01-07T18:59:08ZJulian Andres Klodejak@debian.org2016-01-07T18:16:23Zurn:sha1:eff0c22e59e65b6b63e854ff41eb091278e05714
This improves performance of the cache generation on my
ARM platform (4x Cortex A15) by about 10% to 20% from
2.35-2.50 to 2.1 seconds.
add messages to our deprecation warnings in libapt2015-11-27T14:40:47ZDavid Kalnischkiesdavid@kalnischkies.de2015-11-27T14:40:47Zurn:sha1:5dd00edbcf702cac1ea22392796c65881a8ef6f9
Git-Dch: Ignore
fix various typos reported by codespell2015-08-27T09:27:44ZDavid Kalnischkiesdavid@kalnischkies.de2015-08-22T14:22:08Zurn:sha1:3a8776a37af38127fb04565959e8e0e449eb04a4
Reported-By: codespell
Drop the Section field from pkgCache::Package again2015-08-12T21:45:17ZJulian Andres Klodejak@debian.org2015-08-12T21:44:33Zurn:sha1:a1dfe33790edda246a23a5c5d3c432cd8429e848
This somehow got back, we don't really know why. Emulate the
Section() method in the PkgIterator by looking at the section
of the head of the VersionList.