apt/apt-pkg/clean.cc, branch 1.5Debians commandline package managerhttps://git.kalnischkies.de/apt/atom?h=1.52017-08-24T14:56:52ZReplace APT_CONST with APT_PURE everywhere2017-08-24T14:56:52ZJulian Andres Klodejak@debian.org2017-08-24T14:55:15Zurn:sha1:0e4ac8334d02ea256f750ad61689f28ff1ebdf6c
As a follow up to the last commit, let's replace APT_CONST
with APT_PURE everywhere to clean stuff up.
Reformat and sort all includes with clang-format2017-07-12T11:57:51ZJulian Andres Klodejak@debian.org2017-07-12T11:40:41Zurn:sha1:87274d0f22e1dfd99b2e5200e2fe75c1b804eac3
This makes it easier to see which headers includes what.
The changes were done by running
git grep -l '#\s*include' \
| grep -E '.(cc|h)$' \
| xargs sed -i -E 's/(^\s*)#(\s*)include/\1#\2 include/'
To modify all include lines by adding a space, and then running
./git-clang-format.sh.
Drop cacheiterators.h include2017-07-12T11:56:05ZJulian Andres Klodejak@debian.org2017-07-12T11:42:18Zurn:sha1:c46f94aa48a9707668c46118b3eec77ff318b78c
Including cacheiterators.h before pkgcache.h fails because
pkgcache.h depends on cacheiterators.h.
clean archives without changing directory2017-06-26T21:31:15ZDavid Kalnischkiesdavid@kalnischkies.de2017-04-28T16:18:28Zurn:sha1:6829c5420b4c2e434489e837cad6f3fd09fa3ab3
Adopting this change in other frontends will require source changes as
well similar to our own changes in apt-private/.
non-existing directories don't need to be cleaned2015-12-14T02:21:20ZDavid Kalnischkiesdavid@kalnischkies.de2015-12-14T02:21:20Zurn:sha1:dffc17ba835b6bf782fe553d338b6a921c6de7bf
Trying to clean up directories which do not exist seems rather silly if
you think about it, so let apt think about it and stop it.
Depends a bit on the caller if this is fixing anything for them as they
might try to acquire a lock or doing other clever things as apt does.
Closes: 807477
ignore lost+found in private directory cleanup2015-11-19T16:56:07ZDavid Kalnischkiesdavid@kalnischkies.de2015-11-19T15:19:15Zurn:sha1:6aef1942f441e6e667982b92802907026d8cc7c6
In ce1f3a2c we started warning about failing unlinking, which we
consistently do for directories. That isn't a problem as directories
usually aren't in the places we do want to clean up – with the potential
exeception of "lost+found", so lets ignore it like we ignore our own
partial/ subdirectory.
Closes: 805424
make all d-pointer * const pointers2015-08-10T15:25:25ZDavid Kalnischkiesdavid@kalnischkies.de2015-06-17T07:29:00Zurn:sha1:6c55f07a5fa3612a5d59c61a17da5fe640eadc8b
Doing this disables the implicit copy assignment operator (among others)
which would cause hovac if used on the classes as it would just copy the
pointer, not the data the d-pointer points to. For most of the classes
we don't need a copy assignment operator anyway and in many classes it
was broken before as many contain a pointer of some sort.
Only for our Cacheset Container interfaces we define an explicit copy
assignment operator which could later be implemented to copy the data
from one d-pointer to the other if we need it.
Git-Dch: Ignore
add d-pointer, virtual destructors and de-inline de/constructors2015-06-16T14:22:46ZDavid Kalnischkiesdavid@kalnischkies.de2015-06-16T14:22:46Zurn:sha1:c8a4ce6cbed57ae108dc955d4a850f9b129a0693
To have a chance to keep the ABI for a while we need all three to team
up. One of them missing and we might loose, so ensuring that they are
available is a very tedious but needed task once in a while.
Git-Dch: Ignore
store Release files data in the Cache2015-06-12T14:33:37ZDavid Kalnischkiesdavid@kalnischkies.de2015-06-12T00:08:53Zurn:sha1:b07aeb1a6e24825e534167a737043441e871de9f
We used to read the Release file for each Packages file and store the
data in the PackageFile struct even through potentially many Packages
(and Translation-*) files could use the same data. The point of the
exercise isn't the duplicated data through. Having the Release files as
first-class citizens in the Cache allows us to properly track their
state as well as allows us to use the information also for files which
aren't in the cache, but where we know to which Release file they
belong (Sources are an example for this).
This modifies the pkgCache structs, especially the PackagesFile struct
which depending on how libapt users access the data in these structs can
mean huge breakage or no visible change. As a single data point:
aptitude seems to be fine with this. Even if there is breakage it is
trivial to fix in a backportable way while avoiding breakage for
everyone would be a huge pain for us.
Note that not all PackageFile structs have a corresponding ReleaseFile.
In particular the dpkg/status file as well as *.deb files have not. As
these have only a Archive property need, the Component property takes
over this duty and the ReleaseFile remains zero. This is also the reason
why it isn't needed nor particularily recommended to change from
PackagesFile to ReleaseFile blindly. Sticking with the earlier is
usually the better option.
fix compile and tests error2014-10-13T11:01:15ZDavid Kalnischkiesdavid@kalnischkies.de2014-10-13T07:54:21Zurn:sha1:9d653a6de2ca952247cc4e628256259d225570a6
I am pretty sure I did that before committing broken stuff…
Git-Dch: Ignore