apt/apt-pkg/contrib/error.cc, branch 1.4_beta4 Debians commandline package manager https://git.kalnischkies.de/apt/atom?h=1.4_beta4 2016-07-27T20:42:24Z (error) va_list 'args' was opened but not closed by va_end() 2016-07-27T20:42:24Z David Kalnischkies david@kalnischkies.de 2016-07-27T20:21:58Z urn:sha1:196d590a99e309764e07c9dc23ea98897eebf53a Reported-By: cppcheck Gbp-Dch: Ignore avoid using global PendingError to avoid failing too often too soon 2015-09-14T13:22:18Z David Kalnischkies david@kalnischkies.de 2015-09-10T17:00:51Z urn:sha1:95278287f4e1eeaf5d96749d6fc9bfc53fb400d0 Our error reporting is historically grown into some kind of mess. A while ago I implemented stacking for the global error which is used in this commit now to wrap calls to functions which do not report (all) errors via return, so that only failures in those calls cause a failure to propergate down the chain rather than failing if anything (potentially totally unrelated) has failed at some point in the past. This way we can avoid stopping the entire acquire process just because a single source produced an error for example. It also means that after the acquire process the cache is generated – even if the acquire process had failures – as we still have the old good data around we can and should generate a cache for (again). There are probably more instances of this hiding, but all these looked like the easiest to work with and fix with reasonable (aka net-positive) effects. cleanup headers and especially #includes everywhere 2014-03-13T12:58:45Z David Kalnischkies david@kalnischkies.de 2014-03-05T21:11:25Z urn:sha1:453b82a388013e522b3a1b9fcd6ed0810dab1f4f Beside being a bit cleaner it hopefully also resolves oddball problems I have with high levels of parallel jobs. Git-Dch: Ignore Reported-By: iwyu (include-what-you-use) warning: extra ‘;’ [-Wpedantic] 2014-03-13T12:58:45Z David Kalnischkies david@kalnischkies.de 2014-02-27T00:20:53Z urn:sha1:d3e8fbb395f57954acd7a2095f02ce530a05ec6a Git-Dch: Ignore Reported-By: gcc -Wpedantic proper cleanup varargs in _error (uncovered by Coverity) 2013-07-26T10:04:55Z David Kalnischkies kalnischkies@gmail.com 2013-07-26T10:04:55Z urn:sha1:9ca0d58180366275f5e62b6c5aad066b7b09a1de Git-Dch: Ignore merge with debian/experimental 2011-09-13T15:52:22Z David Kalnischkies kalnischkies@gmail.com 2011-09-13T15:52:22Z urn:sha1:74b220028595342028e3309002e4ec359af328f9 reorder includes: add <config.h> if needed and include it at first 2011-09-13T08:09:00Z David Kalnischkies kalnischkies@gmail.com 2011-09-13T08:09:00Z urn:sha1:ea54214002c09eeb4dd498d97a564471ec9993c5 cppcheck complains about some possible speed improvements which could be 2011-08-11T18:53:28Z David Kalnischkies kalnischkies@gmail.com 2011-08-11T18:53:28Z urn:sha1:f7f0d6c7560a8f71707e7852a512469147aa9f84 done on the mirco-optimazation level, so lets fix them: (performance) Possible inefficient checking for emptiness. (performance) Prefer prefix ++/-- operators for non-primitive types. fix a bunch of cppcheck warnings/errors based on a patch by 2011-04-15T23:10:09Z David Kalnischkies kalnischkies@gmail.com 2011-04-15T23:10:09Z urn:sha1:6070a3461841d4398d731fcb33792d55779111f1 Niels Thykier, thanks! (Closes: #622805) * apt-pkg/contrib/error.cc: 2011-02-15T13:04:06Z David Kalnischkies kalnischkies@gmail.com 2011-02-15T13:04:06Z urn:sha1:38f297033faa099a0705c8f66964d8c5d7927c8d - ensure that va_list is not invalid in second try