apt/apt-pkg/contrib/error.h, branch 2.1.19

error: Extract operator<< into error.cc (de-inline it)

2020-03-10T21:29:46Z

Extract the code, and reformat it with clang-format so we can modify it.

apt-pkg: default visibility to hidden

2020-02-26T19:34:54Z

Remove code tagged APT_PKG_590, add some missing includes

2020-02-18T11:48:38Z

Remove all code scheduled to be removed after 5.90, and fix files to include files they previously got from hashes.h including more headers.

Avoid #define _error, use anonymous C++ struct instead

2020-01-07T15:24:16Z

Replace the macro with an anonymous struct that provides an inline operator->() returning the _error pointer. This change is ABI compatible, and the inline macro is not exported. We should consider if we want to avoid the function call and directly export the thread_local variable instead, when we do break ABI. Closes: #948338

Remove obsolete RCS keywords

2018-05-07T11:41:31Z

Prompted-by: Jakub Wilk

Reformat and sort all includes with clang-format

2017-07-12T11:57:51Z

This makes it easier to see which headers includes what. The changes were done by running git grep -l '#\s*include' \ | grep -E '.(cc|h)$' \ | xargs sed -i -E 's/(^\s*)#(\s*)include/\1#\2 include/' To modify all include lines by adding a space, and then running ./git-clang-format.sh.

fix various typos reported by spellintian

2017-01-19T14:59:38Z

Most of them in (old) code comments. The two instances of user visible string changes the po files of the manpages are fixed up as well. Gbp-Dch: Ignore Reported-By: spellintian

properly format multiline error messages

2016-04-25T13:35:52Z

fix typos and docs in GlobalError documentation

2015-12-13T16:46:49Z

Reported-By: Manuel A. Fernandez Montecelo Git-Dch: Ignore

avoid using global PendingError to avoid failing too often too soon

2015-09-14T13:22:18Z

Our error reporting is historically grown into some kind of mess. A while ago I implemented stacking for the global error which is used in this commit now to wrap calls to functions which do not report (all) errors via return, so that only failures in those calls cause a failure to propergate down the chain rather than failing if anything (potentially totally unrelated) has failed at some point in the past. This way we can avoid stopping the entire acquire process just because a single source produced an error for example. It also means that after the acquire process the cache is generated – even if the acquire process had failures – as we still have the old good data around we can and should generate a cache for (again). There are probably more instances of this hiding, but all these looked like the easiest to work with and fix with reasonable (aka net-positive) effects.