apt/apt-pkg/contrib/fileutl.cc, branch 3.2.0

Correctly append or remove FD_CLOEXEC

2025-10-20T18:26:49Z

Rather than just setting the flags to 0 or FD_CLOEXEC, read the current value and append or remove as needed.

ExecFork: Simplify closing and make it safe

2025-10-20T18:06:50Z

Implement a wrapper around FD_CLOEXEC and use it in place of the raw fcntl(). This wrapper _Exit()s the child if the operation failed. Restructure the close_range() handling to simply mark all fds for closing first and then "reopen" the ones we should keep.

Add some comments and tests around Keep-Fd ordering

2025-10-20T17:42:57Z

ExecFork: Use close_range() if available

2025-10-20T15:16:45Z

Use close_range() if we have it in preference to iterating over /proc/self/fd and falling back to closing all possible fds. This builds sets of ranges to close that take into account the APT::Keep-Fds vector, and a test case is provided to ensure correctness of the splitting logic. Preference is given to close_range() over /proc as in the optimal case, this results in a single system call!

Fix error handling with getline

2025-05-19T15:58:13Z

The function getline is used to read data from different streams, however, the error handling is not accurate. From the man page, getline returns -1 on failure and sets errno accordingly, but the current implementation only checks errno to see if there was a failure. With this approach, in case getline returns success but also sets errno it is consider and error. Fix the issue but also checking the return value of getline. Signed-off-by: Walter Lozano

fileutl: Convert FileFd::d to std::unique_ptr

2025-02-15T08:51:55Z

StartsWithGPGClearTextSignature(): don't keep un-written-to pointer to constant string in .data

2025-02-14T18:45:12Z

flAbsPath(): try to re-use storage of argument

2025-02-14T18:45:12Z

Take const& in flNotFile()

2025-02-14T18:45:12Z

Take const& in GetLock()

2025-02-14T18:45:12Z