apt/apt-pkg/contrib/hashes.cc, branch 2.3.1

HexDigest: Silence -Wstringop-overflow

2020-12-04T22:16:04Z

The compiler does not know that the size is small and thinks we might be doing a stack buffer overflow of the vla: Add APT_ASSUME macro and silence -Wstringop-overflow in HexDigest() The compiler does not know that the size of a hash is at most 512 bit, so tell it that it is. ../apt-pkg/contrib/hashes.cc: In function ‘std::string HexDigest(gcry_md_hd_t, int)’: ../apt-pkg/contrib/hashes.cc:415:21: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=] 415 | Result[(Size)*2] = 0; | ~~~~~~~~~~~~~~~~~^~~ ../apt-pkg/contrib/hashes.cc:414:9: note: at offset [-9223372036854775808, 9223372036854775807] to an object with size at most 4294967295 declared here 414 | char Result[((Size)*2) + 1]; | ^~~~~~ Fix this by adding a simple assertion. This generates an extra two instructions in the normal code path, so it's not exactly super costly.

Initialize libgcrypt on first use

2020-02-25T18:07:15Z

This is not supposed to be done this way, but frankly, since we abstract away the backend, there's not much else we can do here. Closes: #949074

Remove code tagged APT_PKG_590, add some missing includes

2020-02-18T11:48:38Z

Remove all code scheduled to be removed after 5.90, and fix files to include files they previously got from hashes.h including more headers.

Convert users of {MD5,SHA1,SHA256,SHA512}Summation to use Hashes

2020-01-14T12:10:36Z

This makes use of the a function GetHashString() that returns the specific hash string. We also need to implement another overload of Add() for signed chars with sizes, so the existing users do not require reinterpret_cast everywhere.

Raise buffer size for Hashes::AddFD() from 4 KiB to 64 KiB

2020-01-14T12:10:36Z

Move APT_BUFFER_SIZE to macros.h and re-use it in hashes, this also might speed up stuff, the motivation for using 64 KiB buffers in fileutl.cc was precisely that after all.

hashes: Use Libgcrypt for hashing purposes

2020-01-14T12:10:36Z

Switch the code of the Hashes class to use libgcrypt, which allows us to use hardware-accelerated implementations of SHA1 and friends.

Apply various suggestions by cppcheck

2019-07-08T13:51:17Z

Reported-By: cppcheck

hashes: Remove deprecated functions

2019-02-26T15:31:20Z

This keeps the members in the class, but makes them private. We want to migrate to libgcrypt eventually, since we already use libgcrypt through gpgv anyway.

Use std::to_string() for HashStringList::FileSize() getter

2019-02-04T14:29:09Z

This slightly improves performance, as std::to_string() (as in gcc's libstdc++) avoids a heap allocation. This is surprisingly performance critical code, so we might want to improve things further in 1.9 by manually calculating the string - that would also get rid of issues with locales changing string formatting, if any.

Remove obsolete RCS keywords

2018-05-07T11:41:31Z

Prompted-by: Jakub Wilk