apt/apt-pkg/contrib/hashes.cc, branch 2.9.1Debians commandline package managerhttps://git.kalnischkies.de/apt/atom?h=2.9.12024-02-20T12:49:04ZModernize standard library includes2024-02-20T12:49:04ZJulian Andres Klodejulian.klode@canonical.com2024-02-20T12:43:08Zurn:sha1:40a75722c43ae24cb9a99d6730a3b25b65819c49
This was automated with sed and git-clang-format, and then I had to
fix up the top of policy.cc by hand as git-clang-format accidentally
indented it by two spaces.
Revert "Do not fail on systems running in FIPSmode."2023-10-04T12:52:29ZJulian Andres Klodejulian.klode@canonical.com2023-10-04T12:52:29Zurn:sha1:b92934a1904cd6dd1dfdab283d27cd34ca2dbe44
This reverts commit 668451def296afeb0c358a7d80ff39dc546defab.
Do not fail on systems running in FIPSmode.2023-05-29T12:28:20ZA. Maitland Bottomsbottoms@debian.org2023-05-29T12:28:20Zurn:sha1:668451def296afeb0c358a7d80ff39dc546defab
Initialize using gcrypt's GCRYCTL_NO_FIPS_MODE, available since
gcrypt version 1.10.0, otherwise apt aborts on FIPS enabled systems.
Parse Checksum fields via pkgTagSection::Key, too2022-04-01T12:16:19ZDavid Kalnischkiesdavid@kalnischkies.de2022-04-01T09:37:26Zurn:sha1:05fae6fae95d8ef6690f3d56863e3bb6a44d424c
We abstract hashes a fair bit to be able to add new ones eventually,
which lead us to building the field names on the fly. We can do better
through by keeping a central place for these names, too, which even
helps in reducing code as we don't need the MD5 → Files dance anymore.
HexDigest: Silence -Wstringop-overflow2020-12-04T22:16:04ZJulian Andres Klodejulian.klode@canonical.com2020-12-04T22:16:04Zurn:sha1:d63772845a28a08ea9c812ad8ac281cf9e0ae12a
The compiler does not know that the size is small and thinks we might
be doing a stack buffer overflow of the vla:
Add APT_ASSUME macro and silence -Wstringop-overflow in HexDigest()
The compiler does not know that the size of a hash is at most 512 bit,
so tell it that it is.
../apt-pkg/contrib/hashes.cc: In function ‘std::string HexDigest(gcry_md_hd_t, int)’:
../apt-pkg/contrib/hashes.cc:415:21: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=]
415 | Result[(Size)*2] = 0;
| ~~~~~~~~~~~~~~~~~^~~
../apt-pkg/contrib/hashes.cc:414:9: note: at offset [-9223372036854775808, 9223372036854775807] to an object with size at most 4294967295 declared here
414 | char Result[((Size)*2) + 1];
| ^~~~~~
Fix this by adding a simple assertion. This generates an extra two
instructions in the normal code path, so it's not exactly super costly.
Initialize libgcrypt on first use2020-02-25T18:07:15ZJulian Andres Klodejulian.klode@canonical.com2020-02-25T18:03:12Zurn:sha1:65b77c941780c8e1819f527879b0b8e2642839dd
This is not supposed to be done this way, but frankly, since we
abstract away the backend, there's not much else we can do here.
Closes: #949074
Remove code tagged APT_PKG_590, add some missing includes2020-02-18T11:48:38ZJulian Andres Klodejulian.klode@canonical.com2020-02-18T11:48:38Zurn:sha1:e8016805b87bead8eb3dff0d0559c5d9590b721b
Remove all code scheduled to be removed after 5.90, and fix
files to include files they previously got from hashes.h
including more headers.
Convert users of {MD5,SHA1,SHA256,SHA512}Summation to use Hashes2020-01-14T12:10:36ZJulian Andres Klodejulian.klode@canonical.com2020-01-07T19:36:53Zurn:sha1:79de3008ebfc6b4a5dd32e9de1d19788da0b885d
This makes use of the a function GetHashString() that returns
the specific hash string. We also need to implement another overload
of Add() for signed chars with sizes, so the existing users do not
require reinterpret_cast everywhere.
Raise buffer size for Hashes::AddFD() from 4 KiB to 64 KiB2020-01-14T12:10:36ZJulian Andres Klodejulian.klode@canonical.com2020-01-07T18:55:48Zurn:sha1:b350560e34a369ef7610f9fceeffb00660209390
Move APT_BUFFER_SIZE to macros.h and re-use it in hashes,
this also might speed up stuff, the motivation for using
64 KiB buffers in fileutl.cc was precisely that after all.
hashes: Use Libgcrypt for hashing purposes2020-01-14T12:10:36ZJulian Andres Klodejulian.klode@canonical.com2020-01-07T18:21:40Zurn:sha1:814ffcfaf34ad1d35e397eeaaafefbf03faed9cf
Switch the code of the Hashes class to use libgcrypt, which allows
us to use hardware-accelerated implementations of SHA1 and friends.