apt/apt-pkg/contrib/hashsum_template.h, branch 1.4_beta2 Debians commandline package manager https://git.kalnischkies.de/apt/atom?h=1.4_beta2 2016-09-01T14:13:14Z try not to call memcpy with length 0 in hash calculations 2016-09-01T14:13:14Z David Kalnischkies david@kalnischkies.de 2016-08-31T08:11:07Z urn:sha1:644478e8db56f305601c3628a74e53de048b28c8 memcpy is marked as nonnull for its input, but ignores the input anyhow if the declared length is zero. Our SHA2 implementations do this as well, it was "just" MD5 and SHA1 missing, so we add the length check here as well as along the callstack as it is really pointless to do all these method calls for "nothing". Reported-By: gcc -fsanitize=undefined HashSumValue::Set: Do not provide const char* overload 2016-01-08T20:20:25Z Julian Andres Klode jak@debian.org 2016-01-08T20:19:32Z urn:sha1:af4899c9df6e925b1cb099c29bd78788b2984cca Hide the std::string overload instead of providing a const char * one, the old variant was stupid. Gbp-Dch: ignore Switch performance critical code to use APT::StringView 2016-01-07T18:59:08Z Julian Andres Klode jak@debian.org 2016-01-07T18:16:23Z urn:sha1:eff0c22e59e65b6b63e854ff41eb091278e05714 This improves performance of the cache generation on my ARM platform (4x Cortex A15) by about 10% to 20% from 2.35-2.50 to 2.1 seconds. apply various style suggestions by cppcheck 2015-08-10T15:24:01Z David Kalnischkies david@kalnischkies.de 2015-06-16T22:14:10Z urn:sha1:e8afd16892e87a6e2f17c1019ee455f5583387c2 Some of them modify the ABI, but given that we prepare a big one already, these few hardly count for much. Git-Dch: Ignore cleanup headers and especially #includes everywhere 2014-03-13T12:58:45Z David Kalnischkies david@kalnischkies.de 2014-03-05T21:11:25Z urn:sha1:453b82a388013e522b3a1b9fcd6ed0810dab1f4f Beside being a bit cleaner it hopefully also resolves oddball problems I have with high levels of parallel jobs. Git-Dch: Ignore Reported-By: iwyu (include-what-you-use) warning: useless cast to type A [-Wuseless-cast] 2014-03-13T12:58:45Z David Kalnischkies david@kalnischkies.de 2014-02-27T01:18:11Z urn:sha1:e788a834ce421042e727b72e43177edaa47e53a7 Git-Dch: Ignore Reported-By: gcc -Wuseless-cast warning: cast from type A to type B casts away qualifiers [-Wcast-qual] 2014-03-13T12:58:45Z David Kalnischkies david@kalnischkies.de 2014-02-27T00:54:10Z urn:sha1:cf4ff3b78dc347188949370db914fe6329be6c99 Git-Dch: Ignore Reported-By: gcc -Wcast-qual g++ 4.7 fixes 2012-01-02T14:15:54Z Michael Vogt michael.vogt@ubuntu.com 2012-01-02T14:15:54Z urn:sha1:5c6ceb4557cb6497dea827d1ec4e2615ccd53e50 g++ 4.7 fixes 2012-01-02T14:08:58Z Michael Vogt michael.vogt@ubuntu.com 2012-01-02T14:08:58Z urn:sha1:e75aa33384d52635fba502bed628bc68f9cb5066 try to avoid direct usage of .Fd() if possible and do read()s and co 2011-12-17T22:53:31Z David Kalnischkies kalnischkies@gmail.com 2011-12-17T22:53:31Z urn:sha1:109eb1511d0cdfa4af3196105cada30bcbb77bc8 on the FileFd instead