apt/apt-pkg/contrib, branch 1.2 Debians commandline package manager https://git.kalnischkies.de/apt/atom?h=1.2 2016-01-15T18:18:29Z string_view: Drop constexpr constructor for standard compatibility 2016-01-15T18:18:29Z Julian Andres Klode jak@debian.org 2016-01-15T18:18:29Z urn:sha1:ef6cc0e22a2933e0e36bc260179fdf0b86f9ac26 APT::StringView is supposed to be a temporary measure, until support for the standardized string_view is widely available. Introducing additional unstandardized features just makes porting to the standard version harder. The constexpr constructor also won't have any real effect on most systems, as the compiler will happily optimise the strlen() call away for constant strings. Gbp-Dch: ignore provide a constexpr char[] overload for APT::StringView 2016-01-15T17:19:16Z David Kalnischkies david@kalnischkies.de 2016-01-15T16:11:19Z urn:sha1:ec6a4a831e57834bf4d7abb91fc8b298c2fbfcc2 The commit also adds a few trivial tests Git-Dch: Ignore return correct position in APT::StringView::(r)find 2016-01-15T17:19:16Z David Kalnischkies david@kalnischkies.de 2016-01-15T14:57:32Z urn:sha1:9b2845e1691b5587d731c3dae9f695ca2db0be1a The position returned is supposed to be the position of the character counted from the start of the string, but if we used the substr calling overloads the skipped over prefix wasn't considered. The pos parameter of rfind had also the wrong semantic. Store the size of strings in the cache 2016-01-08T20:20:25Z Julian Andres Klode jak@debian.org 2016-01-08T10:12:14Z urn:sha1:60d523e2ae93a6c5bc396b6bede2544271fb1f2e By storing the size of the string in the cache, we can make use of it when comparing the names in the hashtable in pkgCache::FindGrp. HashSumValue::Set: Do not provide const char* overload 2016-01-08T20:20:25Z Julian Andres Klode jak@debian.org 2016-01-08T20:19:32Z urn:sha1:af4899c9df6e925b1cb099c29bd78788b2984cca Hide the std::string overload instead of providing a const char * one, the old variant was stupid. Gbp-Dch: ignore operator==(char*, StringView) use StringView.operator== 2016-01-08T01:33:36Z Julian Andres Klode jak@debian.org 2016-01-08T01:32:23Z urn:sha1:0cc8987abf9f25c458833a0479bc4cb11b405e16 Use the same path for both comparisons, as the operator== path is faster than just calling compare() - it avoids any comparison if the size differs. Gbp-Dch: ignore StringView: rfind: pos should be end of substr, not start 2016-01-07T19:23:48Z Julian Andres Klode jak@debian.org 2016-01-07T19:23:48Z urn:sha1:0e58689ae76e8155bc1f418323aa9e56c34187f6 Gbp-Dch: ignore StringView: pos argument default should be npos 2016-01-07T19:21:16Z Julian Andres Klode jak@debian.org 2016-01-07T19:21:16Z urn:sha1:eee8ee176a5ae3377cc601eb68cdb576b8076761 Gbp-Dch: ignore StringView::rfind(): Call rfind() instead of find() on subst 2016-01-07T19:01:16Z Julian Andres Klode jak@debian.org 2016-01-07T19:01:16Z urn:sha1:8cfd5495e30533e2ab708c8dc875f1c6f29650fd Thanks: Niels Thykier for reporting on IRC Gbp-Dch: ignore Switch performance critical code to use APT::StringView 2016-01-07T18:59:08Z Julian Andres Klode jak@debian.org 2016-01-07T18:16:23Z urn:sha1:eff0c22e59e65b6b63e854ff41eb091278e05714 This improves performance of the cache generation on my ARM platform (4x Cortex A15) by about 10% to 20% from 2.35-2.50 to 2.1 seconds.