apt/apt-pkg/contrib, branch 1.2.3Debians commandline package managerhttps://git.kalnischkies.de/apt/atom?h=1.2.32016-02-10T11:48:37ZSet seekpos to 0 after reopening files in Seek()2016-02-10T11:48:37ZJulian Andres Klodejak@debian.org2016-02-10T11:45:47Zurn:sha1:eda0c1ba43cd3ae0ed85aba2c31573f156cec9c4
If we just reopened the file, we also need to reset the current
seek position when we reset the buffer, otherwise the code will
not try to seek to the position given to Skip (from 0), but will
try to seek to old offset + the position given to skip.
Closes: #812994, #813000
Use some semantically more correct buffer operations2016-02-04T17:34:42ZJulian Andres Klodejak@debian.org2016-02-04T17:33:30Zurn:sha1:72ed5f14b558984bd9c5731f82345b10cb2df2ca
When writing into the buffer write to free() bytes starting
at getend(), instead of buffersize_max bytes at get()
-> get() is a read pointer.
This makes no difference in practice though, as we reset
the buffer before the call, so start = end = 0.
Gbp-Dch: ignore
Correctly report write errors when flushing buffered writer2016-02-04T17:00:42ZJulian Andres Klodejak@debian.org2016-02-04T17:00:42Zurn:sha1:1996a6a785a54efaeddb4ecf5e88fa6070330182
We cannot just return false without setting an error,
as InternalWrite does not set one itself.
Avoid temporary strings in SubstVar.2016-02-03T14:54:10ZAdrian Wielgosikadrian.wielgosik@gmail.com2016-02-02T22:15:25Zurn:sha1:732510fef9af5addc5e3ff1a79ce8c9658711fb6
Microoptimization, but still gives a measurable 2-3% improvement
when using commands with lots of output like `apt list`.
Do not buffer writes larger than the buffer if possible2016-02-01T15:50:48ZJulian Andres Klodejak@debian.org2016-02-01T15:46:53Zurn:sha1:f1828e6b0adb87bf0b99d3cfeeafbb76cbc6aab7
It makes no sense to split a large block into multiple small
blocks, so when we have the chance to write them unbuffered,
do so.
BufferedWriteFileFdPrivate: Simplify InternalWrite()2016-02-01T15:29:13ZJulian Andres Klodejak@debian.org2016-02-01T15:28:43Zurn:sha1:070ed1c9147c092c1f944afd1c17c51f651a5c39
We do not need the loop, FileFd::Private() handles this for us.
Gbp-Dch: ignore
simple_buffer::write: Use free() instead of maxsize - size()2016-02-01T15:25:03ZJulian Andres Klodejak@debian.org2016-02-01T15:25:03Zurn:sha1:47fcfff8a50caebe3cd1f2ee19875a2ca8bbeadc
We want to check whether the amount of free space is smaller
than the requested write size. Checking maxsize - size() is
incorrect for bufferstart >= 0, as size() = end - start.
Gbp-Dch: ignore
fix "Mismatched free() / delete / delete []" in simple_buffer2016-01-30T14:02:42ZStefan Bühlerstbuehler@web.de2016-01-30T11:06:02Zurn:sha1:ab16ead7f8e3824f5099558b9d559f6520a24570drop explicit check for EWOULDBLOCK if it has the same value as EAGAIN2016-01-26T14:32:15ZDavid Kalnischkiesdavid@kalnischkies.de2016-01-25T19:05:54Zurn:sha1:3b0e76ec9c9386e428944f621b970d691884b84a
gcc correctly reports that we check for the same value twice, expect
that the manpage of read(2) tells us to do it for portability, so to
make both sides happy lets add a little #if'ing here.
Reported-By: gcc-6
Git-Dch: Ignore
string_view: Drop constexpr constructor for standard compatibility2016-01-15T18:18:29ZJulian Andres Klodejak@debian.org2016-01-15T18:18:29Zurn:sha1:ef6cc0e22a2933e0e36bc260179fdf0b86f9ac26
APT::StringView is supposed to be a temporary measure, until support
for the standardized string_view is widely available. Introducing
additional unstandardized features just makes porting to the
standard version harder.
The constexpr constructor also won't have any real effect on most
systems, as the compiler will happily optimise the strlen() call
away for constant strings.
Gbp-Dch: ignore