apt/apt-pkg/contrib, branch 1.2.6

Fix several typos

2016-03-06T23:14:48Z

This effectively merges branch 'typofixes-vlajos-20150807' of github.com:vlajos/apt with the following commit: commit 13cacb3e2e2352ba701e769fc889e3344fabbf7e Author: Veres Lajos Date: Sun Aug 9 00:12:53 2015 +0100 typofix - https://github.com/vlajos/misspell_fixer It has been rebased for a better commit message.

Fix lzma write support to handle "try again" case

2016-03-06T09:22:45Z

The liblzma-based write code needs the same tweaks that the read code already has to cope with the situation where lzma_code returns zero the first time through because avail_out is zero, but will do more work if called again. This ports the read tweaks to the write code as closely as possible (including matching comments etc.). Closes: #751688

Set seekpos to 0 after reopening files in Seek()

2016-02-10T11:48:37Z

If we just reopened the file, we also need to reset the current seek position when we reset the buffer, otherwise the code will not try to seek to the position given to Skip (from 0), but will try to seek to old offset + the position given to skip. Closes: #812994, #813000

Use some semantically more correct buffer operations

2016-02-04T17:34:42Z

When writing into the buffer write to free() bytes starting at getend(), instead of buffersize_max bytes at get() -> get() is a read pointer. This makes no difference in practice though, as we reset the buffer before the call, so start = end = 0. Gbp-Dch: ignore

Correctly report write errors when flushing buffered writer

2016-02-04T17:00:42Z

We cannot just return false without setting an error, as InternalWrite does not set one itself.

Avoid temporary strings in SubstVar.

2016-02-03T14:54:10Z

Microoptimization, but still gives a measurable 2-3% improvement when using commands with lots of output like `apt list`.

Do not buffer writes larger than the buffer if possible

2016-02-01T15:50:48Z

It makes no sense to split a large block into multiple small blocks, so when we have the chance to write them unbuffered, do so.

BufferedWriteFileFdPrivate: Simplify InternalWrite()

2016-02-01T15:29:13Z

We do not need the loop, FileFd::Private() handles this for us. Gbp-Dch: ignore

simple_buffer::write: Use free() instead of maxsize - size()

2016-02-01T15:25:03Z

We want to check whether the amount of free space is smaller than the requested write size. Checking maxsize - size() is incorrect for bufferstart >= 0, as size() = end - start. Gbp-Dch: ignore

fix "Mismatched free() / delete / delete []" in simple_buffer

2016-01-30T14:02:42Z