apt/apt-pkg/contrib, branch 1.3_exp2Debians commandline package managerhttps://git.kalnischkies.de/apt/atom?h=1.3_exp22016-06-10T08:49:41Zdon't leak FD in AutoProxyDetect command return parsing2016-06-10T08:49:41ZDavid Kalnischkiesdavid@kalnischkies.de2016-06-09T22:01:46Zurn:sha1:8f858d560e3b7b475c623c4e242d1edce246025a
Just closing the fd would be enough, but while we are at it we can also
use the Popen interface to have an easier time with this.
don't leak an FD in lz4 (de)compression2016-06-10T08:49:34ZDavid Kalnischkiesdavid@kalnischkies.de2016-06-09T19:06:48Zurn:sha1:6f35be91c9e86e463bca7df6eadf05412c7b732c
Seen first in #826783, but as this buglog also shows leaked uncompressed
files as well we don't close it just yet.
do not hang on piped input in PipedFileFdPrivate2016-06-10T08:48:25ZDavid Kalnischkiesdavid@kalnischkies.de2016-06-09T18:41:58Zurn:sha1:bdc42211700ef0f6f40e4ef3f362e52d684d70fb
This effects only compressors configured on the fly (rather then the
inbuilt ones as they use a library).
use de-localed std::put_time instead rolling our own2016-05-28T10:55:21ZDavid Kalnischkiesdavid@kalnischkies.de2016-05-28T10:55:21Zurn:sha1:eceb219c2a64f3f81421c3c6587380b6ae81a530accept only the expected UTC timezones in date parsing2016-05-28T09:42:20ZDavid Kalnischkiesdavid@kalnischkies.de2016-05-28T09:03:35Zurn:sha1:9febc2b238e1e322dce1f94ecbed46d595893b52
HTTP/1.1 hardcodes GMT (RFC 7231 §7.1.1.1) and what is good enough for the
internet must be good enough for us™ as we reuse the implementation
internally to parse (most) dates we encounter in various places like the
Release files with their Date and Valid-Until header fields.
Implementing a fully timezone aware parser just feels too hard for no
effective benefit as it would take 5+ years (= until LTS's are out of
fashion) until a repository could use non-UTC dates and expect it to
work. Not counting non-apt implementations which might or might not
only want to encounter UTC here as well.
As a bonus, this eliminates the use of an instance of setlocale in
libapt.
Closes: 819697
prevent C++ locale number formatting in text APIs2016-05-27T17:14:38ZDavid Kalnischkiesdavid@kalnischkies.de2016-05-27T16:10:39Zurn:sha1:b58e2c7c56b1416a343e81f9f80cb1f02c128e25
Setting the C++ locale via std::locale::global(std::locale("")); which
would otherwise default to the default C locale (aka: unaffected by
setlocale) effects the formatting of numeric types in IO streams, which
for output for humans is perfectly sensible, but breaks our many text
interfaces used and parsed by us and others without expecting the
numbers to be formatted.
Closes: #825396
edsp: try harder to not generate unneeded error messages2016-05-20T12:18:36ZDavid Kalnischkiesdavid@kalnischkies.de2016-04-27T11:44:08Zurn:sha1:4e92b11649292714082754920d5b28477414cd5a
The &= introduced in the EDSP-FileFd conversion isn't working to full
satisfaction for multiple && clauses as the && has a higher binding than
&= has, so that the methods were called even through they shouldn't
have because of previous errors. Using variadic functions we can solve
this in a slightly cleaner way bringing down the amount of 'broken pipe'
errors for the error case of the dump resolver substantially.
Git-Dch: Ignore
convert EDSP to be based on FileFd instead of FILE*2016-05-20T12:18:36ZDavid Kalnischkiesdavid@kalnischkies.de2016-04-26T10:26:12Zurn:sha1:ef00bd7af5b2bc0625df58482eacb4c2873c3647
I doubt there is any non-src:apt usage of these interfaces.
Merge pull request julian-klode/apt#3 from adrian17/master2016-05-10T16:32:06ZJulian Andres Klodejak@debian.org2016-05-10T16:32:06Zurn:sha1:a9c2517e9ce961a761022dfa8eb0b62f68f5df9e
Improve GetLocalitySortedVersionSet, speeds up apt search by 30%
remove 100-levels config nesting limit2016-05-03T11:49:45ZDavid Kalnischkiesdavid@kalnischkies.de2016-05-02T16:18:37Zurn:sha1:6afe25b56467b228fdd7c045d1062b12c0408e7c
The actual reason for this commit isn't the limit – there isn't much
point in using that much nesting – its in shutting up gcc mostly:
apt/apt-pkg/contrib/configuration.cc: In function ‘bool ReadConfigFile(Configuration&, const string&, const bool&, const unsigned int&)’:
apt/apt-pkg/contrib/configuration.cc:686:20: warning: cannot optimize loop, the loop counter may overflow [-Wunsafe-loop-optimizations]
string Stack[100];
^
by replacing this with C++s handy std::stack container (adapter).
Also cleans some whitespace noise from the file in the process.