apt/apt-pkg/contrib, branch 1.3_exp3Debians commandline package managerhttps://git.kalnischkies.de/apt/atom?h=1.3_exp32016-06-20T11:49:31Zimplement and document DIRECT for auto-detect-proxy2016-06-20T11:49:31ZDavid Kalnischkiesdavid@kalnischkies.de2016-06-20T11:49:31Zurn:sha1:9515ed7bcdb32c7985ca83d309beda7155d02136
There is a subtile difference between an empty setting and "DIRECT" in
the configuration as the later overrides the generic settings while the
earlier does not. Also, non-zero exitcodes should really be reported as
an error rather than silently discarded.
do not error if auto-detect-proxy cmd has no output2016-06-20T11:22:22ZDavid Kalnischkiesdavid@kalnischkies.de2016-06-20T09:23:09Zurn:sha1:cad1877559f3e1703c3fea4d081978e1b4bb4a0e
Regression introduced in 8f858d560e3b7b475c623c4e242d1edce246025a.
Commands are probably better of always having output through as the
fall through to the generic proxy settings is likely not intended. As
documenting and implementing this more consistently is kind of a
regression through, it is split off into the next commit.
Closes: 827713
avoid std::get_time usage to sidestep libstdc++6 bug2016-06-17T16:09:20ZDavid Kalnischkiesdavid@kalnischkies.de2016-06-17T15:56:45Zurn:sha1:1d742e01470bba27715a8191c50adde4b39c2f19
As reported upstream in
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71556
the implementation of std::get_time is currently not as accepting as
strptime is, especially in how hours should be formatted.
Just reverting 9febc2b238e1e322dce1f94ecbed46d595893b52 would be
possible, but then we would reopen the problems fixed by it, so instead
I opted here for a rewrite of the parsing logic which makes this method
a lot longer, but at least it provides the same benefits as the rewrite
in std::get_time was intended to give us and decouples us from the fix
of the issue in the standard library implementation of GCC.
LP: 1593583
don't use FindFile for external Dir::Bin commands2016-06-14T12:32:14ZDavid Kalnischkiesdavid@kalnischkies.de2016-06-14T12:32:14Zurn:sha1:90f2a7a0f66cfc259883490a5fcf40f7d0696cfe
We usually use absolute paths to specific the location of dpkg, apt-key
and the like, but there is nothing wrong with using just the command
name and instead let exec(3) make the lookup in PATH.
We had a wild mixture before, so opting for the more accepting option
out of the two seems about right especially as it makes no difference in
the default case as apt uses absolute paths.
don't leak FD in AutoProxyDetect command return parsing2016-06-10T08:49:41ZDavid Kalnischkiesdavid@kalnischkies.de2016-06-09T22:01:46Zurn:sha1:8f858d560e3b7b475c623c4e242d1edce246025a
Just closing the fd would be enough, but while we are at it we can also
use the Popen interface to have an easier time with this.
don't leak an FD in lz4 (de)compression2016-06-10T08:49:34ZDavid Kalnischkiesdavid@kalnischkies.de2016-06-09T19:06:48Zurn:sha1:6f35be91c9e86e463bca7df6eadf05412c7b732c
Seen first in #826783, but as this buglog also shows leaked uncompressed
files as well we don't close it just yet.
do not hang on piped input in PipedFileFdPrivate2016-06-10T08:48:25ZDavid Kalnischkiesdavid@kalnischkies.de2016-06-09T18:41:58Zurn:sha1:bdc42211700ef0f6f40e4ef3f362e52d684d70fb
This effects only compressors configured on the fly (rather then the
inbuilt ones as they use a library).
use de-localed std::put_time instead rolling our own2016-05-28T10:55:21ZDavid Kalnischkiesdavid@kalnischkies.de2016-05-28T10:55:21Zurn:sha1:eceb219c2a64f3f81421c3c6587380b6ae81a530accept only the expected UTC timezones in date parsing2016-05-28T09:42:20ZDavid Kalnischkiesdavid@kalnischkies.de2016-05-28T09:03:35Zurn:sha1:9febc2b238e1e322dce1f94ecbed46d595893b52
HTTP/1.1 hardcodes GMT (RFC 7231 §7.1.1.1) and what is good enough for the
internet must be good enough for us™ as we reuse the implementation
internally to parse (most) dates we encounter in various places like the
Release files with their Date and Valid-Until header fields.
Implementing a fully timezone aware parser just feels too hard for no
effective benefit as it would take 5+ years (= until LTS's are out of
fashion) until a repository could use non-UTC dates and expect it to
work. Not counting non-apt implementations which might or might not
only want to encounter UTC here as well.
As a bonus, this eliminates the use of an instance of setlocale in
libapt.
Closes: 819697
prevent C++ locale number formatting in text APIs2016-05-27T17:14:38ZDavid Kalnischkiesdavid@kalnischkies.de2016-05-27T16:10:39Zurn:sha1:b58e2c7c56b1416a343e81f9f80cb1f02c128e25
Setting the C++ locale via std::locale::global(std::locale("")); which
would otherwise default to the default C locale (aka: unaffected by
setlocale) effects the formatting of numeric types in IO streams, which
for output for humans is perfectly sensible, but breaks our many text
interfaces used and parsed by us and others without expecting the
numbers to be formatted.
Closes: #825396