apt/apt-pkg/contrib, branch 1.3_pre3Debians commandline package managerhttps://git.kalnischkies.de/apt/atom?h=1.3_pre32016-08-03T17:00:01ZExecGPGV: Pass current config state to apt-key via temp file2016-08-03T17:00:01ZJulian Andres Klodejak@debian.org2016-08-03T16:50:37Zurn:sha1:98f884ebec556bafe6f9650e105fc7c60580e730
Create a temporary configuration file with a dump of our
configuration and pass that to apt-key.
LP: #1607283
ExecGPGV: Fork in all cases2016-08-03T16:45:51ZJulian Andres Klodejak@debian.org2016-08-03T16:45:51Zurn:sha1:81ee750f90bb4d21a0441196ce105f6848633616ExecGPGV: Rework file removal on exit()2016-08-03T16:44:27ZJulian Andres Klodejak@debian.org2016-08-03T16:44:27Zurn:sha1:e0a243f33cd411f730af3c93aff38635c9668f9e
Create a local exiter object which cleans up files on exit.
gpgv: Unlink the correct temp file in error case2016-08-03T14:40:14ZJulian Andres Klodejak@debian.org2016-07-28T10:41:27Zurn:sha1:d0d06f44ed60a3888528d834a799bae86c2978d5
Previously, when data could be created and sig not, we would unlink
sig, not data (and vice versa).
if the FileFd failed already following calls should fail, too2016-07-29T20:09:04ZDavid Kalnischkiesdavid@kalnischkies.de2016-07-29T19:39:20Zurn:sha1:02c38073af51802c02bb104d4450e0e112d641ad
There is no point in trying to perform Write/Read on a FileFd which
already failed as they aren't going to work as expected, so we should
make sure that they fail early on and hard.
(error) va_list 'args' was opened but not closed by va_end()2016-07-27T20:42:24ZDavid Kalnischkiesdavid@kalnischkies.de2016-07-27T20:21:58Zurn:sha1:196d590a99e309764e07c9dc23ea98897eebf53a
Reported-By: cppcheck
Gbp-Dch: Ignore
call flush on the wrapped writebuffered FileFd2016-07-23T15:23:13ZDavid Kalnischkiesdavid@kalnischkies.de2016-07-23T13:24:46Zurn:sha1:8ca481e8419c19b6ef9074b68cc028177a507161
The flush call is a no-op in most FileFd implementations so this isn't
as critical as it might sound as the only non-trivial implementation is
in the buffered writer, which tends not be used to buffer another
buffer…
ensure Cnf::FindFile doesn't return files below /dev/null2016-07-19T16:05:13ZDavid Kalnischkiesdavid@kalnischkies.de2016-07-19T16:05:13Zurn:sha1:bbd8308cc01941e51e2cbcf88168a5560abe6042
Very unlikely, but if the parent is /dev/null, the child empty and the
grandchild a value we returned /dev/null/value which doesn't exist, so
hardly a problem, but for best operability we should be consistent in
our work and return /dev/null always.
don't change owner/perms/times through file:// symlinks2016-07-06T00:25:51ZDavid Kalnischkiesdavid@kalnischkies.de2016-07-05T18:04:27Zurn:sha1:3465138575e1fd0d5892d9b6be1ae232eb873460
If we have files in partial/ from a previous invocation or similar such
those could be symlinks created by file:// sources. The code is
expecting only real files through and happily changes owner,
modification times and permission on the file the symlink points to
which tend to be files we have no business in touching in this way.
Permissions of symlinks shouldn't be changed, changing owner is usually
pointless to, but just to be sure we pick the easy way out and use
lchown, check for symlinks before chmod/utimes.
Reported-By: Mattia Rizzolo on IRC
give a descriptive error for pipe tries with 'false'2016-07-05T18:44:45ZDavid Kalnischkiesdavid@kalnischkies.de2016-07-05T13:05:56Zurn:sha1:cc9745a0d81a3e1aa5ef6f99f7ad638d26bdb950
If libapt has builtin support for a compression type it will create a
dummy compressor struct with the Binary set to 'false' as it will catch
these before using the generic pipe implementation which uses the
Binary. The catching happens based on configured Names through, so you
can actually force apt to use the external binaries even if it would
usually use the builtin support. That logic fails through if you don't
happen to have these external binaries installed as it will fallback to
calling 'false', which will end in confusing 'Write error's.
So, this is again something you only encounter in constructed testing.
Gbp-Dch: Ignore