Debians commandline package manager https://git.kalnischkies.de/apt/atom?h=1.6_alpha3 2017-10-22T17:10:57Z 2017-10-22T17:10:57Z Julian Andres Klode jak@debian.org 2017-10-22T17:02:53Z urn:sha1:0934b6b023b46cd0e2e5fa55a23a054b2feeb618 The previous change moved running the proxy detection program from the method to the main process, so it runs as root and not as _apt. This brings it back into the sandbox. Gbp-Dch: ignore 2017-08-24T14:56:52Z Julian Andres Klode jak@debian.org 2017-08-24T14:55:15Z urn:sha1:0e4ac8334d02ea256f750ad61689f28ff1ebdf6c As a follow up to the last commit, let's replace APT_CONST with APT_PURE everywhere to clean stuff up. 2017-08-24T14:56:48Z Julian Andres Klode jak@debian.org 2017-08-24T14:50:12Z urn:sha1:03590fb98226bfdf3147eb78effc3fa7987709bb Functions marked with the const attribute may not inspect any global memory. This includes targets of pointers or references passed as arguments. A pure function however is free to inspect memory, but may not have any side effects. The function StringSplit() was marked as const, but took two references to strings. When the second one was passed as a literal as in StringSplit(name, "::") the compiler cleverly figured out that we only inspect the address of "::" (since StringSplit is const) and thus optimized away the "::" content. While patching out individual broken uses of APT_CONST would be possible, this is already the second case, and there might be more, so let's redefine APT_CONST to use the pure attribute, so we don't end up with the same situation again in some time. 2017-08-04T11:06:10Z David Kalnischkies david@kalnischkies.de 2017-07-31T20:47:58Z urn:sha1:898d53aca8fb26f3861d0efa4d5bef8adb620a7c Regression-Of: 3317ad864c997f4897756c0a2989c4199e9cda62 2017-07-26T17:09:04Z David Kalnischkies david@kalnischkies.de 2017-07-07T14:24:21Z urn:sha1:ea408c560ed85bb4ef7cf8f72f8463653501332c We have support for an netrc-like auth.conf file since 0.7.25 (closing 518473), but it was never documented in apt that it even exists and netrc seems to have fallen out of usage as a manpage for it no longer exists making the feature even more arcane. On top of that the code was a bit of a mess (as it is written in c-style) and as a result the matching of machine tokens to URIs also a bit strange by checking for less specific matches (= without path) first. We now do a single pass over the stanzas. In practice early adopters of the undocumented implementation will not really notice the differences and the 'new' behaviour is simpler to document and more usual for an apt user. Closes: #811181 2017-07-26T17:09:04Z David Kalnischkies david@kalnischkies.de 2017-07-15T13:08:35Z urn:sha1:51751106976b1c6afa8f7991790db87b239fcc84 We used to fail on unreadable config/preferences/sources files, but at least for sources we didn't in the past and it seems harsh to refuse to work because of a single file, especially as the error messages are inconsistent and end up being silly (like suggesting to run apt update to fix the problem…). LP: #1701852 2017-07-26T17:09:04Z David Kalnischkies david@kalnischkies.de 2017-07-15T12:12:50Z urn:sha1:3317ad864c997f4897756c0a2989c4199e9cda62 Using different ways of opening files means we have different behaviour and error messages for them, so by the same for all we can have more uniformity for users and apt developers alike. 2017-07-20T20:09:10Z Julian Andres Klode jak@debian.org 2017-07-20T20:09:10Z urn:sha1:414b7d57eda362328568484957fbd6c06b1b0d1f We can't allocate a pointer here, it would not get released - use an object instead. Gbp-Dch: ignore 2017-07-20T18:50:05Z Julian Andres Klode jak@debian.org 2017-07-20T18:50:05Z urn:sha1:b28636e54f682dc65aef169f201a34a8e2893369 This makes the code easier to read. 2017-07-12T11:57:51Z Julian Andres Klode jak@debian.org 2017-07-12T11:40:41Z urn:sha1:87274d0f22e1dfd99b2e5200e2fe75c1b804eac3 This makes it easier to see which headers includes what. The changes were done by running git grep -l '#\s*include' \ | grep -E '.(cc|h)$' \ | xargs sed -i -E 's/(^\s*)#(\s*)include/\1#\2 include/' To modify all include lines by adding a space, and then running ./git-clang-format.sh.