apt/apt-pkg/deb/deblistparser.cc, branch 1.1.9

ParseDepends: Mark branches for build-dep parsing as unlikely

2015-12-27T10:50:05Z

We do not see those branches at all during normal mode of operation (that is, during cache generation), so tell the compiler about it.

debListParser: Do not validate Description-md5 for correctness twice

2015-12-27T03:04:50Z

The Set() method returns false if the input is no hex number, so simply use that.

debListParser: ParseDepends: Only query native arch if needed

2015-12-27T01:25:49Z

This makes the code parsing architecture lists slower, but on the other hand, improves the more generic case of reading dependencies from Packages files.

Convert most callers of isspace() to isspace_ascii()

2015-12-27T00:20:41Z

This converts all callers that read machine-generated data, callers that might work with user input are not converted.

Convert package names from Packages files to lower case

2015-12-11T13:48:21Z

dpkg does that when reading package files, so we should do the same. This only deals with parsing names from binary package paragraphs, it does not look at source package names and/or the list of binaries in a dsc file. Closes: #807012

deblistparser: Make PrioList const

2015-10-23T16:06:23Z

More safety, less writeable memory.

implement dpkgs vision of interpreting pkg: dependencies

2015-09-14T13:22:18Z

How the Multi-Arch field and pkg: dependencies interact was discussed at DebConf15 in the "MultiArch BoF". dpkg and apt (among other tools like dose) had a different interpretation in certain scenarios which we resolved by agreeing on dpkg view – and this commit realizes this agreement in code. As was the case so far libapt sticks to the idea of trying to hide MultiArch as much as possible from individual frontends and instead translates it to good old SingleArch. There are certainly situations which can be improved in frontends if they know that MultiArch is upon them, but these are improvements – not necessary changes needed to unbreak a frontend. The implementation idea is simple: If we parse a dependency on foo:amd64 the dependency is formed on a package 'foo:amd64' of arch 'any'. This package is provided by package 'foo' of arch 'amd64', but not by 'foo' of arch 'i386'. Both of those foo packages provide each other through (assuming foo is M-A:foreign) to allow a dependency on 'foo' to be satisfied by either foo of amd64 or i386. Packages can also declare to provide 'foo:amd64' which is translated to providing 'foo:amd64:any' as well. This indirection over provides was chosen as the alternative would be to teach dependency resolvers how to deal with architecture specific dependencies – which violates the design idea of avoiding resolver changes, especially as architecture-specific dependencies are a cornercase with quite a few subtil rules. Handling it all over versioned provides as we already did for M-A in general seems much simpler as it just works for them. This switch to :any has actually a "surprising" benefit as well: Even frontends showing a package name via .Name() [which doesn't show the architecture] will display the "architecture" for dependencies in which it was explicitely requested, while we will not show the 'strange' :any arch in FullName(true) [= pretty-print] either. Before you had to specialcase these and by default you wouldn't get these details shown. The only identifiable disadvantage is that this complicates error reporting and handling. apt-get's ShowBroken has existing problems with virtual packages [it just shows the name without any reason], so that has to be worked on eventually. The other case is that detecting if a package is completely unknown or if it was at least referenced somewhere needs to acount for this "split" – not that it makes a practical difference which error is shown… but its one of the improvements possible.

M-A: allowed pkgs of unconfigured archs do not statisfy :any

2015-09-14T13:22:18Z

We parse all architectures we encounter recently, which means we also parse packages from architectures which are neither native nor foreign, but still came onto the system somehow (usually via heavy force).

store ':any' pseudo-packages with 'any' as architecture

2015-09-14T13:22:18Z

Previously we had python:any:amd64, python:any:i386, … in the cache and the dependencies of an amd64 package would be on python:any:amd64, of an i386 on python:any:i386 and so on. That seems like a relatively pointless endeavor given that they will all be provided by the same packages and therefore also a waste of space. Git-Dch: Ignore

fix some unused parameter/variable warnings

2015-08-31T15:48:54Z

Reported-By: gcc Git-Dch: Ignore