apt/apt-pkg/deb/debsystem.cc, branch 3.0.1Debians commandline package managerhttps://git.kalnischkies.de/apt/atom?h=3.0.12025-02-07T19:58:00Zdpkg: Pass --admindir if a different one is specified2025-02-07T19:58:00ZJulian Andres Klodejulian.klode@canonical.com2025-02-04T15:30:29Zurn:sha1:672244d46644a26f4659376d88a9899663d20d1d
Otherwise if we set e.g. Dir, we end up with the foreign
architectures from the host which is wrong.
Fixes: 8e6a86aa3bc6d5a9013bb42fccea9bbce3fd97e2
apt-pkg/deb/debsystem.cc: Fall back to "dpkg" when Dir::Bin::dpkg is not found2024-12-30T12:15:44ZBalint Reczeybalint@balintreczey.hu2024-12-28T22:58:36Zurn:sha1:8e6a86aa3bc6d5a9013bb42fccea9bbce3fd97e2
The custom dpkg binary may be removed by apt and that breaks the end of
the operation. This can be observed when using eatmydata as dpkg and
removing the symlink to eatmydata when removing the apt-eatmydata package.
fdopen() failing does not close the fd2024-11-14T18:23:26Zнабnabijaczleweli@nabijaczleweli.xyz2024-11-14T18:23:26Zurn:sha1:2db807afb1cbb02cce1fd8ff883de8ea1d23fa30DEFER() more2024-11-14T18:22:39Zнабnabijaczleweli@nabijaczleweli.xyz2024-11-14T17:55:49Zurn:sha1:6e80412fad93ef685559953719b82a28c1dcea13Modernize standard library includes2024-02-20T12:49:04ZJulian Andres Klodejulian.klode@canonical.com2024-02-20T12:43:08Zurn:sha1:40a75722c43ae24cb9a99d6730a3b25b65819c49
This was automated with sed and git-clang-format, and then I had to
fix up the top of policy.cc by hand as git-clang-format accidentally
indented it by two spaces.
Allow apt to run if no dpkg/status file exists2022-09-02T14:55:45ZDavid Kalnischkiesdavid@kalnischkies.de2022-09-01T13:14:52Zurn:sha1:f52c1ce9b31befb71016a20759b96b4946034fcb
Not having a dpkg/status file used to be a hard error which from a
boostrap perspective is suspect as in the beginning, there is no
status so you would need to touch it into existence.
We make a difference between factual non-existence and inaccessibility
to catch mistakes in which the file is not readable for some reason,
the testcase test-bug-254770-segfault-if-cache-not-buildable is an
example of this.
Note that apt has already figured out at this point that this is a
Debian-like system which should have a dpkg/status file. This change
does not effect the auto-detection and is not supposed to.
Report failures back from debSystem::AddStatusFiles2022-09-02T14:55:45ZDavid Kalnischkiesdavid@kalnischkies.de2022-08-31T14:26:48Zurn:sha1:49f9cfba5567cd034bf729a63b3f6e9badd9bc35
Failing to properly create the status file class should be reported back
to the caller so it can proceed accordingly instead of proceeding into
more failures.
This gives us:
E: flAbsPath on /var/lib/dpkg/status failed - realpath (2: No such file or directory)
E: The package lists or status file could not be parsed or opened.
instead of:
E: flAbsPath on /var/lib/dpkg/status failed - realpath (2: No such file or directory)
E: Could not open file - open (2: No such file or directory)
E: Problem opening
E: The package lists or status file could not be parsed or opened.
and valgrind reporting actions on uninitialised values.
Restore dpkg::chroot-directory functionality2021-06-10T17:25:17ZDavid Kalnischkiesdavid@kalnischkies.de2021-06-10T16:06:14Zurn:sha1:8083d4019844f764058efa2a950ed16975178bff
If we call dpkg inside a chroot we have to ensure that the temporary
directory we construct to call dpkg --recursive is inside the chroot and
that we strip the path to the chroot from the directory name we pass to
dpkg.
Note that the added test succeeds before and (hopefully) after as we
can't really chroot here or fiddle with the needed settings as we are
already setting up apt to work with a quasi-chroot. The test perhaps
helps in ensuring we don't break it too much in the future though.
(Broken five years (and one day) ago this seems to have an immense user
base at the moment, but it might in the future via mmdebstrap)
References: f495992428a396e0f98886c9a761a804aa161c68
Reported-By: Johannes Schauer Marin Rodrigues on IRC
Tested-By: Johannes Schauer Marin Rodrigues
dpkg: fix passing readonly /dev/null fd as stdout/stderr2021-01-22T15:41:12ZYoufu Zhangzhangyoufu@gmail.com2021-01-22T09:41:22Zurn:sha1:acbe227d50178657d98a609221b1caa5b128d7bb
The read-only /dev/null was duplicated to stdout and stderr, causing writes to those descriptors to fail:
[pid 260] openat(AT_FDCWD, "/dev/null", O_RDONLY) = 7
[pid 260] dup2(7, 0) = 0
[pid 260] close(5) = 0
[pid 260] dup2(6, 1) = 1
[pid 260] dup2(7, 2) = 2
[pid 260] write(2, "Chrooting into ", 15) = -1 EBADF (Bad file descriptor)
[pid 260] chroot("/chroot/") = 0
Add basic support for the Protected field2020-06-29T15:32:17ZJulian Andres Klodejulian.klode@canonical.com2020-06-29T15:31:06Zurn:sha1:ddd8fc3d28cd8e668868158049ced7fa3c8c71b8
This will be mapped to Important for the time being.