apt/apt-pkg/deb/dpkgpm.cc, branch 1.2.10

streamline dpkgpm cleanup-handling

2016-03-14T10:47:19Z

The (unlikely) waitpid failure case should fallthrough the code just like the other failures (and successes) instead of taking a shortcut avoiding all the cleanup (progress) and finishing touches (log, state). This also delays the cleanup of the progress until apt is really done with everything and "just" has the post-invokes left to do, so the period of 'apt looks finished as it stopped the progress' and 'apt really finished as I have the shell-prompt back' is shorter even if there is no progress reported anymore, so the bar lingers at 100%… Ideally even the post-invokes would be covered by progress, but they can have their own output and dealing with that could be hard. Git-Dch: Ignore

Fix several typos

2016-03-06T23:14:48Z

This effectively merges branch 'typofixes-vlajos-20150807' of github.com:vlajos/apt with the following commit: commit 13cacb3e2e2352ba701e769fc889e3344fabbf7e Author: Veres Lajos Date: Sun Aug 9 00:12:53 2015 +0100 typofix - https://github.com/vlajos/misspell_fixer It has been rebased for a better commit message.

Add missing numeric includes in files using std::accumulate()

2016-02-26T14:17:14Z

Reported-By: Helmut Grohne on IRC

Use c++11 for loop in AptHistoryRequestingUser

2016-01-25T16:17:54Z

Git-Dch: ignore

Store "Requested-By" user in history.log in a simpler format

2016-01-25T15:49:48Z

Git-Dch: ignore Thanks: David Kalnischkies

Log calling SUDO_USER or PKEXEC_UID in history.log

2016-01-25T13:44:42Z

Thanks: Thomas Reusch

Avoid overflow when summing up file sizes

2015-12-07T13:44:15Z

We need to pass 0llu instead of 0 as the init value, otherwise std::accumulate will calculate with ints. Reported-by: Raphaël Hertzog

apply various suggestions made by cppcheck

2015-11-05T11:21:33Z

Reported-By: cppcheck Git-Dch: Ignore

do not use read() returned value unconditionally

2015-11-05T11:21:33Z

A slightly unlikely bug, but lets fix it while slightly reworking this whole function to be slightly saner to look at, even if still not good. Git-Dch: Ignore

wrap every unlink call to check for != /dev/null

2015-11-04T17:42:28Z

Unlinking /dev/null is bad, we shouldn't do that. Also, we should print at least a warning if we tried to unlink a file but didn't manage to pull it of (ignoring the case were the file is /dev/null or doesn't exist in the first place). This got triggered by a relatively unlikely to cause problem in pkgAcquire::Worker::PrepareFiles which would while temporary uncompressed files (which are set to keep compressed) figure out that to files are the same and prepare for sharing by deleting them. Bad move. That also shows why not printing a warning is a bad idea as this hide the error for in non-root test runs. Git-Dch: Ignore