apt/apt-pkg/deb/dpkgpm.cc, branch 1.2.3Debians commandline package managerhttps://git.kalnischkies.de/apt/atom?h=1.2.32016-01-25T16:17:54ZUse c++11 for loop in AptHistoryRequestingUser2016-01-25T16:17:54ZMichael Vogtmvo@debian.org2016-01-25T16:17:54Zurn:sha1:48fe8dff592f6769bf2c67b8e7befd7091068f7d
Git-Dch: ignore
Store "Requested-By" user in history.log in a simpler format2016-01-25T15:49:48ZMichael Vogtmvo@debian.org2016-01-25T15:49:48Zurn:sha1:46e88ba252230858abe891d5815fce884d3cf35d
Git-Dch: ignore
Thanks: David Kalnischkies
Log calling SUDO_USER or PKEXEC_UID in history.log2016-01-25T13:44:42ZMichael Vogtmvo@debian.org2016-01-25T13:44:42Zurn:sha1:a6fd0c5cc412afd5dac7a9952cab741e48342488
Thanks: Thomas Reusch
Avoid overflow when summing up file sizes2015-12-07T13:44:15ZJulian Andres Klodejak@debian.org2015-12-07T13:42:25Zurn:sha1:5a97834817dd43b7833881f38f512a9f2fdac8a9
We need to pass 0llu instead of 0 as the init value, otherwise
std::accumulate will calculate with ints.
Reported-by: Raphaël Hertzog
apply various suggestions made by cppcheck2015-11-05T11:21:33ZDavid Kalnischkiesdavid@kalnischkies.de2015-11-04T20:08:55Zurn:sha1:258b9e512c4001e806c5c0966acecd3d742ec6e9
Reported-By: cppcheck
Git-Dch: Ignore
do not use read() returned value unconditionally2015-11-05T11:21:33ZDavid Kalnischkiesdavid@kalnischkies.de2015-11-04T17:01:35Zurn:sha1:9fb4e6510faaa9c84b88d4cb567bf3deebf8e0b7
A slightly unlikely bug, but lets fix it while slightly reworking this
whole function to be slightly saner to look at, even if still not good.
Git-Dch: Ignore
wrap every unlink call to check for != /dev/null2015-11-04T17:42:28ZDavid Kalnischkiesdavid@kalnischkies.de2015-11-02T17:49:52Zurn:sha1:ce1f3a2c616b86da657c1c796efa5f4d18c30c39
Unlinking /dev/null is bad, we shouldn't do that. Also, we should print
at least a warning if we tried to unlink a file but didn't manage to
pull it of (ignoring the case were the file is /dev/null or doesn't
exist in the first place).
This got triggered by a relatively unlikely to cause problem in
pkgAcquire::Worker::PrepareFiles which would while temporary
uncompressed files (which are set to keep compressed) figure out that to
files are the same and prepare for sharing by deleting them. Bad move.
That also shows why not printing a warning is a bad idea as this hide
the error for in non-root test runs.
Git-Dch: Ignore
sanify API to get 'the' candidate version2015-11-04T17:04:05ZDavid Kalnischkiesdavid@kalnischkies.de2015-10-30T15:34:25Zurn:sha1:294a80209a0c6ea617a14fb2ae650d4fd329eab5
This was discussed a while ago on #debian-apt and now that I see myself
making this mistake lets bite the bullet and fix it in the easy way out
version: Using a new name which fits with a similar named setter and
deprecate the old method instead of 'hostily' changing API.
Closes: #803471
implement a public pkgSystem::MultiArchSupported2015-11-04T14:02:36ZDavid Kalnischkiesdavid@kalnischkies.de2015-09-15T10:44:53Zurn:sha1:8d6d3f00b14217e69ecabd68379b1e29bf4a3ccd
Some codepaths need to check if the system (in our case usually dpkg)
supports MultiArch or not. We had copy-pasted the check so far into
these paths, but having it as a system check is better for reusability.
dpkgpm: Convert users of localtime() to localtime_r()2015-10-30T14:35:13ZJulian Andres Klodejak@debian.org2015-10-23T18:36:03Zurn:sha1:42285f827b6a28becc2d47d82f82f74f6ca68a11
The former is not thread-safe, whereas the latter is.
Gbp-Dch: ignore