Debians commandline package manager https://git.kalnischkies.de/apt/atom?h=1.1.3 2015-11-27T14:40:47Z 2015-11-27T14:40:47Z David Kalnischkies david@kalnischkies.de 2015-11-27T14:40:47Z urn:sha1:5dd00edbcf702cac1ea22392796c65881a8ef6f9 Git-Dch: Ignore 2015-11-21T17:04:29Z Justin B Rye justin.byam.rye@gmail.com 2015-11-21T16:50:06Z urn:sha1:d04e44ac8177fc5b70ae0189bb5e437c2502f910 Reference mail: https://lists.debian.org/debian-l10n-english/2015/11/msg00006.html 2015-11-05T11:21:33Z David Kalnischkies david@kalnischkies.de 2015-11-04T20:08:55Z urn:sha1:258b9e512c4001e806c5c0966acecd3d742ec6e9 Reported-By: cppcheck Git-Dch: Ignore 2015-11-05T11:21:33Z David Kalnischkies david@kalnischkies.de 2015-11-04T17:01:35Z urn:sha1:9fb4e6510faaa9c84b88d4cb567bf3deebf8e0b7 A slightly unlikely bug, but lets fix it while slightly reworking this whole function to be slightly saner to look at, even if still not good. Git-Dch: Ignore 2015-11-04T17:42:28Z David Kalnischkies david@kalnischkies.de 2015-11-02T17:49:52Z urn:sha1:ce1f3a2c616b86da657c1c796efa5f4d18c30c39 Unlinking /dev/null is bad, we shouldn't do that. Also, we should print at least a warning if we tried to unlink a file but didn't manage to pull it of (ignoring the case were the file is /dev/null or doesn't exist in the first place). This got triggered by a relatively unlikely to cause problem in pkgAcquire::Worker::PrepareFiles which would while temporary uncompressed files (which are set to keep compressed) figure out that to files are the same and prepare for sharing by deleting them. Bad move. That also shows why not printing a warning is a bad idea as this hide the error for in non-root test runs. Git-Dch: Ignore 2015-11-04T17:42:28Z David Kalnischkies david@kalnischkies.de 2015-10-30T22:16:01Z urn:sha1:2f91076de326a0dee067659381a9c4cf745f0efe Leading or trailing newlines can be confusing for our parser as it expects two newlines to start/stop a new stanza. To solve this the lines we wanna add are printed first, ignore any leading newlines and then add the stanza as provided by dpkg-deb with or without trailing newlines as the parser will look at the first stanza only anyway and removing trailing newlines is considerably harder to do. Closes: 802553 2015-11-04T17:42:27Z David Kalnischkies david@kalnischkies.de 2015-10-28T13:38:49Z urn:sha1:1dd20368486820efb6ef4476ad739e967174bec4 Based on a discussion with Niels Thykier who asked for Contents-all this implements apt trying for all architecture dependent files to get a file for the architecture all, which is treated internally now as an official architecture which is always around (like native). This way arch:all data can be shared instead of duplicated for each architecture requiring the user to download the same information again and again. There is one problem however: In Debian there is already a binary-all/ Packages file, but the binary-any files still include arch:all packages, so that downloading this file now would be a waste of time, bandwidth and diskspace. We therefore need a way to decide if it makes sense to download the all file for Packages in Debian or not. The obvious answer would be a special flag in the Release file indicating this, which would need to default to 'no' and every reasonable repository would override it to 'yes' in a few years time, but the flag would be there "forever". Looking closer at a Release file we see the field "Architectures", which doesn't include 'all' at the moment. With the idea outlined above that 'all' is a "proper" architecture now, we interpret this field as being authoritative in declaring which architectures are supported by this repository. If it says 'all', apt will try to get all, if not it will be skipped. This gives us another interesting feature: If I configure a source to download armel and mips, but it declares it supports only armel apt will now print a notice saying as much. Previously this was a very cryptic failure. If on the other hand the repository supports mips, too, but for some reason doesn't ship mips packages at the moment, this 'missing' file is silently ignored (= that is the same as the repository including an empty file). The Architectures field isn't mandatory through, so if it isn't there, we assume that every architecture is supported by this repository, which skips the arch:all if not listed in the release file. 2015-11-04T17:04:05Z David Kalnischkies david@kalnischkies.de 2015-10-30T15:34:25Z urn:sha1:294a80209a0c6ea617a14fb2ae650d4fd329eab5 This was discussed a while ago on #debian-apt and now that I see myself making this mistake lets bite the bullet and fix it in the easy way out version: Using a new name which fits with a similar named setter and deprecate the old method instead of 'hostily' changing API. Closes: #803471 2015-11-04T17:04:00Z David Kalnischkies david@kalnischkies.de 2015-10-11T21:05:47Z urn:sha1:64b66a46a7fc9e7070ee6a758013a6059fee691e Showing just "Get: [1234 B]" looks very strange, so we now print the filename and as usual the package name, version and architecture. 2015-11-04T17:04:00Z David Kalnischkies david@kalnischkies.de 2015-09-25T09:25:25Z urn:sha1:b49068c566d749130e023536d54588c948c16edf We had this code lying around in apt-mark for a while now, but other frontends need this (and similar) functionality as well, so its high time that we provide a public interface in libapt for this stuff.