Debians commandline package manager https://git.kalnischkies.de/apt/atom?h=1.8.0_alpha2 2018-10-14T19:23:41Z 2018-10-14T19:23:41Z Julian Andres Klode jak@debian.org 2018-10-14T19:23:41Z urn:sha1:b80e48783c183aeaf1d30d898a7743f091d96336 Support subkeys and multiple keyrings in Signed-By options See merge request apt-team/apt!27 2018-10-05T10:45:47Z Julian Andres Klode julian.klode@canonical.com 2018-10-05T10:29:39Z urn:sha1:6675601c81de85b40dc89772c1d6d17f1811c5ba Some post-invoke scripts install packages, which fails because the environment variable is not set. This sets the variable for all three kinds of scripts {pre,post-}invoke and pre-install-pkgs, but we will only allow post-invoke at a later time. Gbp-Dch: full 2018-09-11T11:16:11Z David Kalnischkies david@kalnischkies.de 2018-08-17T09:59:45Z urn:sha1:ff8fa4ab4b80384a9240f0df63181f71077a8d83 If we limit a file to be signed by a certain key it should usually accept also being signed by any of this keys subkeys instead of requiring each subkey to be listed explicitly. If the later is really wanted we support now also the same syntax as gpg does with appending an exclamation mark at the end of the fingerprint to force no mapping. 2018-09-11T11:08:58Z David Kalnischkies david@kalnischkies.de 2018-09-10T19:34:11Z urn:sha1:329c8d5e149465003ea9007661a7af1099c75c43 We are seeing 'processing' messages from dpkg first, so it makes sense to translate them to "Preparing" messages instead of using "Installing" and co to override these shortly after with the "Preparing" messages. The difference isn't all to visible as later messages tend to linger far longer in the display than the ealier ones, but at least in a listing it seems more logical. 2018-09-11T11:08:58Z David Kalnischkies david@kalnischkies.de 2018-09-10T16:43:34Z urn:sha1:f484906eff85c8c9eadc13ce817d8857abdd08e8 The progress reporting relies on parsing the status reports of dpkg which used to repeat being in the same state multiple times in the same run, but by fixing #365921 it will stop doing so. The problem is in theory just with 'config-files' in case we do purge as this (can) do remove + purge in one step, but we remove this also for the unpack + configure combination althrough we handle these currently in two independent dpkg calls. 2018-09-11T11:08:58Z David Kalnischkies david@kalnischkies.de 2018-09-09T17:45:42Z urn:sha1:2295de2c97e6d1290a86e0b160885212411510a5 Exiting the processing loop as soon as the dpkg process finishes might leave status-fd lines unprocessed which wasn't much of a problem in the past as the progress would just be slightly off, but now that we us the information also for skipping already done tasks and generate warnings if we didn't see all expected messages we should make sure we seem them all. We still need to exit "early" if dpkg exited unsuccessfully/crashed through as the (remaining) status lines we get could be incomplete. 2018-08-29T15:50:31Z David Kalnischkies david@kalnischkies.de 2018-08-22T07:54:07Z urn:sha1:55585d0f93de1a0e60858e594b1b3b46f4a0831f cppcheck reports: (error) Iterator 't' used after element has been erased. The loop is actually fashioned to deal with this (not in the most efficient way, but in simplest and speed isn't really a concern here) IF this codepath had a "break" at the end… so I added one. Note that the tests aren't failing before (and hopefully after) the change as the undefined behavior we encounter is too stable. Thanks: David Binderman for reporting 2018-08-08T13:20:44Z Julian Andres Klode julian.klode@canonical.com 2018-08-08T13:19:20Z urn:sha1:55489885b51b02b7f74e601a393ecaefd1f71f9c We forgot to set the variable for the selection changes. Let's set it for that and some other dpkg calls. Regression-Of: c2c8b4787b0882234ba2772ec7513afbf97b563a 2018-08-07T13:07:52Z Julian Andres Klode jak@debian.org 2017-01-29T12:05:18Z urn:sha1:c2c8b4787b0882234ba2772ec7513afbf97b563a The dpkg frontend lock is a lock dpkg tries to acquire except if the frontend already acquires it. This fixes a race condition in the install command where the dpkg lock is not held for a short period of time between different dpkg invocations. For this reason we also define an environment variable DPKG_FRONTEND_LOCKED for dpkg invocations so dpkg knows not to try to acquire the frontend lock because it's held by a parent process. We can set DPKG_FRONTEND_LOCKED only if the frontend lock really is held; that is, if our lock count is greater than 0 - otherwise an apt client not using the LockInner family of functions would run dpkg without the frontend lock set, but with DPKG_FRONTEND_LOCKED set. Such a process has a weaker guarantee: Because dpkg would not lock the frontend lock either, the process is prone to the existing races, and, more importantly, so is a new style process. Closes: #869546 [fixups: fix error messages, add public IsLocked() method, and make {Un,}LockInner return an error on !debSystem] 2018-06-13T21:36:08Z Julian Andres Klode julian.klode@canonical.com 2018-06-13T16:45:12Z urn:sha1:79f012bd09ae99d4c9d63dc0ac960376b5338b32 debSystem uses a reference counted lock, so you can acquire it multiple times in your applications, possibly nested. Nesting locks causes a fd leak, though, as we only increment the lock count when we already have locked twice, rather than once, and hence when we call lock the second time, instead of increasing the lock count, we open another lock fd. This fixes the code to check if we have locked at all (> 0). There is no practical problem here aside from the fd leak, as closing the new fd releases the lock on the old one due to the weird semantics of fcntl locks.