apt/apt-pkg/depcache.cc, branch 1.0.9.4Debians commandline package managerhttps://git.kalnischkies.de/apt/atom?h=1.0.9.42014-11-10T16:23:29Zdeprecate the Section member from package struct2014-11-10T16:23:29ZDavid Kalnischkiesdavid@kalnischkies.de2014-06-13T06:35:32Zurn:sha1:50ef3344c3afaaf9943142906b2f976a0337d264
A version belongs to a section and has hence a section member of its
own. A package on the other hand can have multiple versions from
different sections. This was "solved" by using the section which was
parsed first as order of sources.list defines, but that is obviously a
horribly unpredictable thing.
Users are way better of with the Section() as returned by the version
they are dealing with. It is likely the same for all versions of a
package, but in the few cases it isn't, it is important (like packages
moving from main/* to contrib/* or into oldlibs …).
Backport of 7a66977 which actually instantly removes the member.
initialize iPolicyBrokenCount in DepCache::Update2014-08-29T09:19:05ZWarren Hemicrorffr@gmail.com2014-08-29T09:15:30Zurn:sha1:fb4c76436a88a04d1d9b7e9622e431ed8ab708a6
All other counters are correctly initialized here, expect this one. The
practical effect is low as in apt we usually just do "!= 0" checks, but
only correct counters are good counters.
Closes: 758397
do not revert candidate for protected packages2014-06-07T20:46:37ZDavid Kalnischkiesdavid@kalnischkies.de2014-06-07T20:46:37Zurn:sha1:e41d3d7e25754f858b6dfe4dd841f4749f7f3ab1
In commit 21b3eac8 I promoted the check for installable dependencies to
a pre-install check, which also reverts to a known good candidate (the
installed version) if it fails. This revert was done even for user
requested candidate switches which disabled our Broken detection so that
install requests which are impossible to satisfy do not fail anymore,
but print an (incomplete) solution proposal and then exit successfully.
Closes: 745046
Do not try to cast a pkgDepCache::Policy to a pkgCache2014-05-27T15:49:53ZMichael Vogtmvo@debian.org2014-05-27T15:49:53Zurn:sha1:de6221c9d5f99a276628bcf45fb28537e46e7660
Fix incorrect cast in pkgDepCache::Policy::GetCandidateVer()
Reported-By: clang -fsanitize=address -fno-omit-frame-pointer
discard candidates via IsInstallOk to allow override2014-03-23T11:38:43ZDavid Kalnischkiesdavid@kalnischkies.de2014-03-11T09:31:44Zurn:sha1:21b3eac8f9ab8e12b43fa8998a5aa5465f29adc5
In commit 446551c8 I changed MarkInstall to discard the candidate if the
candidate can't satisfy the dependency. This breaks interactive solvers
like aptitude which can change the candidate on-the-fly later.
In commit df77d8a5 I introduced this 'early' loop-breaking to begin with
which can't be that helpful for interactive solvers as well, but makes
perfect sense for non-interactives to stop them from exploring trees
which can't be satisfied, but it isn't perfect as ideally we would check
this before auto-installing the first dependency.
This commit therefore moves the loop into its own IsInstallOk hook so
that frontends can override this check if they want to and in exchange
removes the loop-breaking from MarkInstall itself and does it before any
dependency is installed.
Closes: 740750
do IsInstallOk call in MarkInstall unconditionally2014-03-23T11:31:02ZDavid Kalnischkiesdavid@kalnischkies.de2014-03-11T14:32:40Zurn:sha1:be7ce6f1d067fa62b01685e48094f3f73c95189f
Hooked checks could be influenced by AutoInst as a lot can happen
between a call without and one with this bit set. The real cache-hit
check is above this call already. Individual hooked checks can then
inspect the state if they want to cache. Calling them multiple times
shouldn't be a problem either way.
follow method attribute suggestions by gcc2014-03-13T12:58:45ZDavid Kalnischkiesdavid@kalnischkies.de2014-03-05T23:33:10Zurn:sha1:a02db58fd50ef7fc2f0284852c6b3f98e458a232
Git-Dch: Ignore
Reported-By: gcc -Wsuggest-attribute={pure,const,noreturn}
cleanup headers and especially #includes everywhere2014-03-13T12:58:45ZDavid Kalnischkiesdavid@kalnischkies.de2014-03-05T21:11:25Zurn:sha1:453b82a388013e522b3a1b9fcd6ed0810dab1f4f
Beside being a bit cleaner it hopefully also resolves oddball problems
I have with high levels of parallel jobs.
Git-Dch: Ignore
Reported-By: iwyu (include-what-you-use)
warning: unused parameter ‘foo’ [-Wunused-parameter]2014-03-13T12:58:45ZDavid Kalnischkiesdavid@kalnischkies.de2014-03-01T14:11:42Zurn:sha1:655122418d714f342b5d9789f45f8035f3fe8b9a
Reported-By: gcc -Wunused-parameter
Git-Dch: Ignore
warning: no previous declaration for foobar() [-Wmissing-declarations]2014-03-13T12:58:45ZDavid Kalnischkiesdavid@kalnischkies.de2014-02-27T02:11:54Zurn:sha1:c3ccac9232c2684b15f75fa8622a9a290aeca123
Git-Dch: Ignore
Reported-By: gcc -Wmissing-declarations