apt/apt-pkg/edsp.cc, branch 2.1.6Debians commandline package managerhttps://git.kalnischkies.de/apt/atom?h=2.1.62020-05-25T10:05:00ZEnsure EDSP doesn't use a dangling architecture string2020-05-25T10:05:00ZDavid Kalnischkiesdavid@kalnischkies.de2020-05-24T14:27:15Zurn:sha1:90a7a5e32643a67f4245460e7659d9dee230e9e7
../apt-pkg/edsp.cc:861:23: error: object backing the pointer will be destroyed at the end of the full-expression [-Wdangling-gsl]
const char *arch = _config->Find("APT::Architecture").c_str();
Compilers are probably optimizing it the way the patch does by hand now. Small
string optimisation helps likely as well. Othwise that should have failed left
and right as EDSP is used by experimental and such builders to talk to aspcud.
Reported-By: clang
Rename _count() macro to APT_ARRAY_SIZE()2020-01-07T21:51:41ZJulian Andres Klodejulian.klode@canonical.com2020-01-07T21:37:36Zurn:sha1:df4b92bd1df204e7fb0d22e73e143d205d74aea6edsp: Remove deprecated functions2019-02-26T15:31:20ZJulian Andres Klodejulian.klode@canonical.com2019-02-26T12:26:14Zurn:sha1:e9ac86f11b23310924058a045e0352b499c66d43Reformat and sort all includes with clang-format2017-07-12T11:57:51ZJulian Andres Klodejak@debian.org2017-07-12T11:40:41Zurn:sha1:87274d0f22e1dfd99b2e5200e2fe75c1b804eac3
This makes it easier to see which headers includes what.
The changes were done by running
git grep -l '#\s*include' \
| grep -E '.(cc|h)$' \
| xargs sed -i -E 's/(^\s*)#(\s*)include/\1#\2 include/'
To modify all include lines by adding a space, and then running
./git-clang-format.sh.
Drop cacheiterators.h include2017-07-12T11:56:05ZJulian Andres Klodejak@debian.org2017-07-12T11:42:18Zurn:sha1:c46f94aa48a9707668c46118b3eec77ff318b78c
Including cacheiterators.h before pkgcache.h fails because
pkgcache.h depends on cacheiterators.h.
avoid explicit types for pkg counts by auto2017-06-26T21:31:15ZDavid Kalnischkiesdavid@kalnischkies.de2017-06-04T16:14:13Zurn:sha1:fc2055e1e08e4e3b662b0c5f67a0d0a57267acd3
Changes nothing on the program front and as the datatypes are
sufficently comparable fixes no bug either, but problems later on if we
ever change the types of those and prevent us using types which are too
large for the values we want to store waste (a tiny bit of) resources.
Gbp-Dch: Ignore
ensure generation of valid EDSP error stanzas2016-12-31T01:29:20ZDavid Kalnischkiesdavid@kalnischkies.de2016-12-29T10:20:18Zurn:sha1:0161280405fe5aa256dc9df6a56106dd3a1a6f38
The crude way of preparing a message to be a multiline value failed at
generation valid deb822 in case the error message ended with a new line
like the resolving errors from apt do. apt itself can parse these, but
other tools like grep-dctrl choke on it, so be nice and print valid.
Reported-By: Johannes 'josch' Schauer on IRC
edsp: try 2 to read responses even if writing failed2016-09-07T08:21:01ZDavid Kalnischkiesdavid@kalnischkies.de2016-09-07T08:21:01Zurn:sha1:12b201da7c1d5e2beceae796151e4ebedc5bae97
Commit b60c8a89c281f2bb945d426d2215cbf8f5760738 improved the situation,
but due to inconsistency mostly for planners, not for solvers. As the
idea of hiding errors if we show another error is a bit scary (as the
extern error might be a followup of our intern error, rather than the
reason for our intern error as it is at the moment) we don't discard the
errors, but if we got an extern error we show them directly removing
them from the error list at the end of the run – that list will contain
the extern error which hopefully gives us the best of both worlds.
The problem itself is the same as before: The externals exiting before
apt is done talking to them.
Reported-By: Johannes 'josch' Schauer on IRC
edsp: try to read responses even if writing failed2016-07-29T20:09:06ZDavid Kalnischkiesdavid@kalnischkies.de2016-07-29T19:51:43Zurn:sha1:b60c8a89c281f2bb945d426d2215cbf8f5760738
If a solver/planner exits before apt is done writing we will generate
write errors. Solvers like 'dump' can be pretty quick in failing but
produce a valid EDSP error report apt should read, parse and display
instead of just discarding even through we had write errors.
(error) va_list 'args' was opened but not closed by va_end()2016-07-27T20:42:24ZDavid Kalnischkiesdavid@kalnischkies.de2016-07-27T20:21:58Zurn:sha1:196d590a99e309764e07c9dc23ea98897eebf53a
Reported-By: cppcheck
Gbp-Dch: Ignore