apt/apt-pkg/edsp/edsplistparser.cc, branch 1.4.6Debians commandline package managerhttps://git.kalnischkies.de/apt/atom?h=1.4.62016-11-22T21:58:33ZDo not use MD5SumValue for Description_md5()2016-11-22T21:58:33ZJulian Andres Klodejak@debian.org2016-09-27T22:49:45Zurn:sha1:49521f87851089bdb4097b715d09a8bd348aa60a
Our profile says we spend about 5% of the time transforming the
hex digits into the binary format used by HashsumValue, all for
comparing them against the other strings. That makes no sense
at all.
According to callgrind, this reduces the overall instruction
count from 5,3 billion to 5 billion in my example, which
roughly matches the 5%.
Add missing includes and external definitions2016-08-26T13:49:10ZJulian Andres Klodejak@debian.org2016-08-23T11:15:15Zurn:sha1:24a59c62efafbdb8387b2d3c5616b04b9fd21306
Several modules use std::array without including the
array header. Bad modules.
Some modules use STDOUT_FILENO and friends, or close()
without including unistd.h, where they are defined.
One module also uses WIFEXITED() without including
sys/wait.h.
Finally, environ is not specified to be defined in unistd.h. We
are required to define it ourselves according to POSIX, so let's
do that.
eipp: provide the internal planer as an external one2016-06-27T09:57:12ZDavid Kalnischkiesdavid@kalnischkies.de2016-05-28T13:40:59Zurn:sha1:f74d99c6a78caafdc6e32d8cb135683b7154795c
Testing the current implementation can benefit from being able to be
feed an EIPP request and produce a fully compliant response. It is also
a great test for EIPP in general.
refactor EDSP classes for better internal reuse2016-06-05T11:15:55ZDavid Kalnischkiesdavid@kalnischkies.de2016-06-05T11:05:30Zurn:sha1:d59671c9eef322c10abba22b0257fef37979dfd4
The classes are all marked as hidden, so changing them is no problem ABI
wise and will help with introducing protocols similar to EDSP.
The change has no observeable behavior difference, its just code
juggling.
Git-Dch: Ignore
edsp: use an ID mapping for the internal solver2016-06-04T16:45:01ZDavid Kalnischkiesdavid@kalnischkies.de2016-06-04T16:45:01Zurn:sha1:307d9eb2d13ee59191b86ffec2f36ba3fffc5c20
Currently an EDSP solver gets send basically all versions which means
the absolute count is the same, but that might not be true forever (and
with the skipping of rc-only versions it kinda is already) and even if
it were true, segfaulting on bad input seems wrong.
remove unused Description methods in listparsers2016-01-26T20:58:57ZDavid Kalnischkiesdavid@kalnischkies.de2016-01-26T20:58:57Zurn:sha1:02ceb810fe0de9b267a8b6a302505967afce6b5a
These virtual methods are implemented in hidden classes, so we can drop
them without breaking the ABI.
Git-Dch: Ignore
wrap every unlink call to check for != /dev/null2015-11-04T17:42:28ZDavid Kalnischkiesdavid@kalnischkies.de2015-11-02T17:49:52Zurn:sha1:ce1f3a2c616b86da657c1c796efa5f4d18c30c39
Unlinking /dev/null is bad, we shouldn't do that. Also, we should print
at least a warning if we tried to unlink a file but didn't manage to
pull it of (ignoring the case were the file is /dev/null or doesn't
exist in the first place).
This got triggered by a relatively unlikely to cause problem in
pkgAcquire::Worker::PrepareFiles which would while temporary
uncompressed files (which are set to keep compressed) figure out that to
files are the same and prepare for sharing by deleting them. Bad move.
That also shows why not printing a warning is a bad idea as this hide
the error for in non-root test runs.
Git-Dch: Ignore
sanify API to get 'the' candidate version2015-11-04T17:04:05ZDavid Kalnischkiesdavid@kalnischkies.de2015-10-30T15:34:25Zurn:sha1:294a80209a0c6ea617a14fb2ae650d4fd329eab5
This was discussed a while ago on #debian-apt and now that I see myself
making this mistake lets bite the bullet and fix it in the easy way out
version: Using a new name which fits with a similar named setter and
deprecate the old method instead of 'hostily' changing API.
Closes: #803471
implement autobit and pinning in EDSP solver 'apt'2015-09-14T13:22:18ZDavid Kalnischkiesdavid@kalnischkies.de2015-09-08T20:14:11Zurn:sha1:188a6fcf4f13df1fd362a0aff27a23493ddd1ec5
The parser creates a preferences as well as an extended states file
based on the EDSP scenario file, which isn't the most efficient way of
dealing with this as thes text files have to be parsed again by another
layer of the code, but it needs the least changes and works good enough
for now. The 'apt' solver is in the end just a test solver like dump.
Cleanup includes after running iwyu2015-08-17T10:01:45ZMichael Vogtmvo@debian.org2015-08-17T10:01:45Zurn:sha1:88a8975f156e452d9f3ebe76822b236e8962ebba