apt/apt-pkg/indexcopy.cc, branch 1.0.9.4 Debians commandline package manager https://git.kalnischkies.de/apt/atom?h=1.0.9.4 2014-03-13T12:58:45Z follow method attribute suggestions by gcc 2014-03-13T12:58:45Z David Kalnischkies david@kalnischkies.de 2014-03-05T23:33:10Z urn:sha1:a02db58fd50ef7fc2f0284852c6b3f98e458a232 Git-Dch: Ignore Reported-By: gcc -Wsuggest-attribute={pure,const,noreturn} cleanup headers and especially #includes everywhere 2014-03-13T12:58:45Z David Kalnischkies david@kalnischkies.de 2014-03-05T21:11:25Z urn:sha1:453b82a388013e522b3a1b9fcd6ed0810dab1f4f Beside being a bit cleaner it hopefully also resolves oddball problems I have with high levels of parallel jobs. Git-Dch: Ignore Reported-By: iwyu (include-what-you-use) warning: unused parameter ‘foo’ [-Wunused-parameter] 2014-03-13T12:58:45Z David Kalnischkies david@kalnischkies.de 2014-03-01T14:11:42Z urn:sha1:655122418d714f342b5d9789f45f8035f3fe8b9a Reported-By: gcc -Wunused-parameter Git-Dch: Ignore warning: useless cast to type A [-Wuseless-cast] 2014-03-13T12:58:45Z David Kalnischkies david@kalnischkies.de 2014-02-27T01:18:11Z urn:sha1:e788a834ce421042e727b72e43177edaa47e53a7 Git-Dch: Ignore Reported-By: gcc -Wuseless-cast warning: extra ‘;’ [-Wpedantic] 2014-03-13T12:58:45Z David Kalnischkies david@kalnischkies.de 2014-02-27T00:20:53Z urn:sha1:d3e8fbb395f57954acd7a2095f02ce530a05ec6a Git-Dch: Ignore Reported-By: gcc -Wpedantic fix -Wmissing-field-initializers warnings 2014-03-13T12:58:45Z David Kalnischkies david@kalnischkies.de 2014-02-25T21:22:41Z urn:sha1:67c3067f1a615fd6ff0b332c2a526d052442913d Reported-By: gcc Git-Dch: Ignore fix resource leak when verification fails 2013-07-25T18:45:53Z Michael Vogt mvo@debian.org 2013-07-25T18:45:53Z urn:sha1:a9d6b0ad873fdf38e7a7077fd1f07289ad66d45a apt-pkg/indexcopy.cc: check for pending errors before calling fdopen() 2013-07-25T18:41:03Z Michael Vogt mvo@debian.org 2013-07-25T18:41:03Z urn:sha1:60fc4f21783fddaae481494f99ec157e08a9bfdb call fdopen() after FileFd was checked 2013-07-25T18:36:23Z Michael Vogt mvo@debian.org 2013-07-25T18:36:23Z urn:sha1:a80a03448fe11f8ea3fd4a8c525fc413c9ce9037 fail in CopyFile if the FileFds have error flag set 2013-06-09T16:49:55Z David Kalnischkies kalnischkies@gmail.com 2013-06-09T16:33:48Z urn:sha1:2128d3fce44da34ecb1f0d784b703807f66b20f9 Testing for global PendingErrors in users of CopyFile is incorrect in so far as unrelated errors will prevent us from copying perfectly fine files and checking for the validity of the files is just better in CopyFiles as it already checks if files are at least opened. Add also a higher-level error message to the error stack if it fails.