Debians commandline package manager https://git.kalnischkies.de/apt/atom?h=2.1.2 2020-02-26T19:34:54Z 2020-02-26T19:34:54Z Julian Andres Klode julian.klode@canonical.com 2019-08-13T17:15:19Z urn:sha1:db678df196ccd8f9f6fb336706cf5701d1e53aa6 2019-06-12T13:02:55Z Julian Andres Klode julian.klode@canonical.com 2019-05-11T15:17:20Z urn:sha1:daa1352ed3d2bb4bc6aa0f0e7f22be3f0908942d 2019-02-26T15:31:20Z Julian Andres Klode julian.klode@canonical.com 2019-02-26T11:59:27Z urn:sha1:a969efb944ef9425b4b6a7b5cfe9104607f4f7ff 2015-11-27T14:40:47Z David Kalnischkies david@kalnischkies.de 2015-11-27T14:40:47Z urn:sha1:5dd00edbcf702cac1ea22392796c65881a8ef6f9 Git-Dch: Ignore 2015-08-17T10:01:45Z Michael Vogt mvo@debian.org 2015-08-17T10:01:45Z urn:sha1:88a8975f156e452d9f3ebe76822b236e8962ebba 2015-08-10T15:27:17Z David Kalnischkies david@kalnischkies.de 2015-07-08T22:35:40Z urn:sha1:3b3028467ceccca0b73a8f53051c0fa4de313111 C++11 adds the 'override' specifier to mark that a method is overriding a base class method and error out if not. We hide it in the APT_OVERRIDE macro to ensure that we keep compiling in pre-c++11 standards. Reported-By: clang-modernize -add-override -override-macros Git-Dch: Ignore 2015-08-10T15:25:26Z David Kalnischkies david@kalnischkies.de 2015-06-23T13:16:08Z urn:sha1:5ad0096a4e19e191b59634e8a8817995ec4045ad indexRecords was used to parse the Release file – mostly the hashes – while metaIndex deals with downloading the Release file, storing all indexes coming from this release and … parsing the Release file, but this time mostly for the other fields. That wasn't a problem in metaIndex as this was done in the type specific subclass, but indexRecords while allowing to override the parsing method did expect by default a specific format. APT isn't really supporting different types at the moment, but this is a violation of the abstraction we have everywhere else and, which is the actual reason for this merge: Options e.g. coming from the sources.list come to metaIndex naturally, which needs to wrap them up and bring them into indexRecords, so the acquire system is told about it as they don't get to see the metaIndex, but they don't really belong in indexRecords as this is just for storing data loaded from the Release file… the result is a complete mess. I am not saying it is a lot prettier after the merge, but at least adding new options is now slightly easier and there is just one place responsible for parsing the Release file. That can't hurt. 2015-08-10T15:25:25Z David Kalnischkies david@kalnischkies.de 2015-06-17T07:29:00Z urn:sha1:6c55f07a5fa3612a5d59c61a17da5fe640eadc8b Doing this disables the implicit copy assignment operator (among others) which would cause hovac if used on the classes as it would just copy the pointer, not the data the d-pointer points to. For most of the classes we don't need a copy assignment operator anyway and in many classes it was broken before as many contain a pointer of some sort. Only for our Cacheset Container interfaces we define an explicit copy assignment operator which could later be implemented to copy the data from one d-pointer to the other if we need it. Git-Dch: Ignore 2015-06-16T14:22:46Z David Kalnischkies david@kalnischkies.de 2015-06-16T14:22:46Z urn:sha1:c8a4ce6cbed57ae108dc955d4a850f9b129a0693 To have a chance to keep the ABI for a while we need all three to team up. One of them missing and we might loose, so ensuring that they are available is a very tedious but needed task once in a while. Git-Dch: Ignore 2015-05-11T15:22:33Z David Kalnischkies david@kalnischkies.de 2015-05-11T13:08:08Z urn:sha1:88593886a42025d51d76051da5929b044e42efee While it is mostly busywork to rewrite all instances it actually fixes bugs as the data storage used by the new method is std::string rather than a char*, the later mostly created by c_str() from a std::string which the caller has to ensure keeps in scope – something apt-ftparchive actually didn't ensure and relied on copy-on-write behavior instead which c++11 forbids and hence the new default gcc abi doesn't use it.