apt/apt-pkg/install-progress.cc, branch 1.5_rc1

Replace APT_CONST with APT_PURE everywhere

2017-08-24T14:56:52Z

As a follow up to the last commit, let's replace APT_CONST with APT_PURE everywhere to clean stuff up.

Reformat and sort all includes with clang-format

2017-07-12T11:57:51Z

This makes it easier to see which headers includes what. The changes were done by running git grep -l '#\s*include' \ | grep -E '.(cc|h)$' \ | xargs sed -i -E 's/(^\s*)#(\s*)include/\1#\2 include/' To modify all include lines by adding a space, and then running ./git-clang-format.sh.

Use C locale instead of C.UTF-8 for protocol strings

2016-08-26T20:17:13Z

The C.UTF-8 locale is not portable, so we need to use C, otherwise we crash on other systems. We can use std::locale::classic() for that, which might also be a bit cheaper than using locale("C").

prevent C++ locale number formatting in text APIs (try 3)

2016-08-23T13:11:20Z

This time it is the formatting of floating numbers in progress reporting with a radix charater potentially not being dot. Followup of 7303e11ff28f920a6277c159aa46f80c007350bb. Regression of b58e2c7c56b1416a343e81f9f80cb1f02c128e25 in so far as it exchanging very effected with slightly less effected code. LP: 1611010

don't perform int
2016-08-12T09:12:04Z
Comparing floating numbers is always fun and in this instance a 9 < 9.0 is "somehow" true on hurd-i386 letting the tests fail by reporting that too much progress achieved. A bit mysterious, but with some rework we can use code which avoids dealing with the floats in this way entirely and make our testcases happy.

prevent C++ locale number formatting in text APIs

2016-05-27T17:14:38Z

Setting the C++ locale via std::locale::global(std::locale("")); which would otherwise default to the default C locale (aka: unaffected by setlocale) effects the formatting of numeric types in IO streams, which for output for humans is perfectly sensible, but breaks our many text interfaces used and parsed by us and others without expecting the numbers to be formatted. Closes: #825396

flush line-clearing on progress stop before post-invoke

2016-03-14T10:47:19Z

All other interactions with std::cout are flushed directly, just in the stop case we hadn't done it – no problem expect if there is still output coming after apt is done like in the case of a post-invoke script producing output. Closes: 793672

Fix all the wrong removals of includes that iwyu got wrong

2015-08-17T12:29:02Z

Git-Dch: ignore

Cleanup includes after running iwyu

2015-08-17T10:01:45Z

Use terminfo's typical save_cursor/restore_cursor sequences

2015-08-16T14:59:47Z

Not all terminals understand DOS' escape sequences for save/restore cursor, so use the more typical sequences from terminfo. Closes: #772521 Signed-off-by: James McCoy