apt/apt-pkg/install-progress.cc, branch 1.8.0_rc2

Avoid implicitly promotion of float to double

2018-05-04T22:34:22Z

Reported-By: gcc -Wdouble-promotion Gbp-Dch: Ignore

remove pointless APT_PURE from void functions

2017-12-14T20:55:34Z

Earlier gcc versions used to complain that you should add them althrough there isn't a lot of point to it if you think about it, but now gcc (>= 8) complains about the attribute being present. warning: ‘pure’ attribute on function returning ‘void’ [-Wattributes] Reported-By: gcc -Wattributes Gbp-Dch: Ignore

deal with floats without old-style cast

2017-12-13T22:53:48Z

We have no speed problem with handling floats/doubles in our progress handling, but that shouldn't prevent us from cleaning up the handling slightly to avoid unclean casting to ints. Reported-By: gcc -Wdouble-promotion -Wold-style-cast

Replace APT_CONST with APT_PURE everywhere

2017-08-24T14:56:52Z

As a follow up to the last commit, let's replace APT_CONST with APT_PURE everywhere to clean stuff up.

Reformat and sort all includes with clang-format

2017-07-12T11:57:51Z

This makes it easier to see which headers includes what. The changes were done by running git grep -l '#\s*include' \ | grep -E '.(cc|h)$' \ | xargs sed -i -E 's/(^\s*)#(\s*)include/\1#\2 include/' To modify all include lines by adding a space, and then running ./git-clang-format.sh.

Use C locale instead of C.UTF-8 for protocol strings

2016-08-26T20:17:13Z

The C.UTF-8 locale is not portable, so we need to use C, otherwise we crash on other systems. We can use std::locale::classic() for that, which might also be a bit cheaper than using locale("C").

prevent C++ locale number formatting in text APIs (try 3)

2016-08-23T13:11:20Z

This time it is the formatting of floating numbers in progress reporting with a radix charater potentially not being dot. Followup of 7303e11ff28f920a6277c159aa46f80c007350bb. Regression of b58e2c7c56b1416a343e81f9f80cb1f02c128e25 in so far as it exchanging very effected with slightly less effected code. LP: 1611010

don't perform int
2016-08-12T09:12:04Z
Comparing floating numbers is always fun and in this instance a 9 < 9.0 is "somehow" true on hurd-i386 letting the tests fail by reporting that too much progress achieved. A bit mysterious, but with some rework we can use code which avoids dealing with the floats in this way entirely and make our testcases happy.

prevent C++ locale number formatting in text APIs

2016-05-27T17:14:38Z

Setting the C++ locale via std::locale::global(std::locale("")); which would otherwise default to the default C locale (aka: unaffected by setlocale) effects the formatting of numeric types in IO streams, which for output for humans is perfectly sensible, but breaks our many text interfaces used and parsed by us and others without expecting the numbers to be formatted. Closes: #825396

flush line-clearing on progress stop before post-invoke

2016-03-14T10:47:19Z

All other interactions with std::cout are flushed directly, just in the stop case we hadn't done it – no problem expect if there is still output coming after apt is done like in the case of a post-invoke script producing output. Closes: 793672