apt/apt-pkg/packagemanager.cc, branch 1.0.9.4Debians commandline package managerhttps://git.kalnischkies.de/apt/atom?h=1.0.9.42014-07-29T13:07:06ZFix SmartConfigure to ignore ordering of packages that are already valid2014-07-29T13:07:06ZMichael Vogtmvo@ubuntu.com2014-07-29T13:01:13Zurn:sha1:2f58969150b0daec1de407f61385ccf5b2065aa3
With the change of SmartConfigure() in git commit 42d51f the ordering
code was trying to re-order dependencies, even when at this point in
time this was not needed. Now it will first check all targets of the
given dependency and only if there is not a good one try to reorder
and unpack/configure as needed.
Closes: LP: #1347721
fix tight loop detection and temporary removes2014-05-22T15:43:48ZDavid Kalnischkiesdavid@kalnischkies.de2014-05-17T10:37:13Zurn:sha1:0eb4af9d3d0c524c7afdc684238aa263ac287449
As outlined in #748355 apt segfaulted if it encountered a loop between a
package pre-depending on a package conflicting with the previous as it
ended up in an endless loop trying to unpack 'the other package'.
In this specific case as an essential package is involved a lot of force
needs to be applied, but can also be caused by 'normal' tight loops and
highlights a problem in how we handle breaks which we want to avoid.
The fix comes in multiple entangled changes:
1. All Smart* calls are guarded with loop detection. Some already had it,
some had parts of it, some did it incorrect, and some didn't even try.
2. temporary removes to avoid a loop (which is done if a loop is
detected) prevent the unpack of this looping package (we tried to unpack
it to avoid the conflict/breaks, but due to a loop we couldn't, so we
remove/deconfigure it instead which means we can't unpack it now)
3. handle conflicts and breaks very similar instead of duplicating most
of the code. The only remaining difference is, as it should:
deconfigure is enough for breaks, for conflicts we need the big hammer
consistently fail if Smart* packagemanager actions fail2014-05-22T15:43:48ZDavid Kalnischkiesdavid@kalnischkies.de2014-05-16T15:28:11Zurn:sha1:71e7a0f3a432828e5bd5498297051aa37e7f0a59
These failure conditions come with an error message attached and the
conditions aren't workaroundable (otherwise this would have been done
instead of returning failure), so not erroring out here means that we
execute dpkg later on with a known not-working ordering adding insult
(our own error messages at the end) to injury (dpkg failure).
do not configure already unpacked packages needlessly2014-03-13T12:58:45ZDavid Kalnischkiesdavid@kalnischkies.de2014-03-08T16:29:46Zurn:sha1:0caa5a4c6472d1b74444c4f38ced6c3b89fa50fe
The unpack of a M-A:same package will force the unpack of all its
siblings directly to prevent that they could be separated by later
immediate actions. In commit 634985f8 a call to SmartConfigure was
introduced to configure these packages at the time the installation
order encounters them. Usually, the unpack order is already okay, so
that this 'earlier' unpack was not needed and if it wouldn't have been
done, the package would now only be unpacked, but by configuring the package
now we impose new requirements which must be satisfied. The code is
clever enough to handle this most of the time (it worked for 2 years!),
but it isn't needed and in very coupled cases this can fail.
Removing this call again removes this extra burden and so simplifies the
ordering as can be seen in the modified tests. Famous last words, but I
don't see a reason for this extra burden to exist hence the remove.
Closes: 740843
cleanup headers and especially #includes everywhere2014-03-13T12:58:45ZDavid Kalnischkiesdavid@kalnischkies.de2014-03-05T21:11:25Zurn:sha1:453b82a388013e522b3a1b9fcd6ed0810dab1f4f
Beside being a bit cleaner it hopefully also resolves oddball problems
I have with high levels of parallel jobs.
Git-Dch: Ignore
Reported-By: iwyu (include-what-you-use)
show debug output only if told so in packagemanager2014-03-13T12:57:34ZDavid Kalnischkiesdavid@kalnischkies.de2014-02-23T21:22:15Zurn:sha1:2252183c69fb5e3e020b45c37d9728b3437d797d
Git-Dch: Ignore
Fix typos in documentation (codespell)2014-02-22T17:34:33ZMichael Vogtmvo@debian.org2014-02-22T17:34:33Zurn:sha1:1e3f4083db29bba600b9725e9456b0e140975c99restore ABI and prepare next ABI via #if (APT_PKG_MAJOR >= 4 && APT_PKG_MINOR >= 13)2013-10-31T07:23:12ZMichael Vogtmvo@debian.org2013-10-31T07:23:12Zurn:sha1:bd5f39b34cc0e8cebbe9103f569d4d903e75bd2brestore binary compatiblity with the pkgPackageManager interface2013-10-21T20:11:18ZMichael Vogtmvo@debian.org2013-10-21T19:42:16Zurn:sha1:3b1b0f2900347ef2836c7ee4cc3ee20c6cdcb621re-add APT::Keep-Fds:: for the dpkg status-fd in dpkgpm.cc as we always need this2013-10-14T06:42:48ZMichael Vogtmvo@debian.org2013-10-14T06:42:48Zurn:sha1:5e9458e285af11c7fa4308add10d250e3546c8bf