apt/apt-pkg/packagemanager.h, branch 1.1.exp1Debians commandline package managerhttps://git.kalnischkies.de/apt/atom?h=1.1.exp12014-06-18T13:05:32Zreadd pkgPackageManager::Go() to not break API2014-06-18T13:05:32ZMichael Vogtmvo@ubuntu.com2014-06-18T13:05:32Zurn:sha1:9eb0042bef1f1b6b1603fb234cdbc53fc76b2ce7Merge remote-tracking branch 'upstream/debian/sid' into debian/experimental2014-05-29T10:14:42ZMichael Vogtmvo@debian.org2014-05-29T10:14:42Zurn:sha1:1f46d14620a0b58a9239fa3faa59ba79a98f6c98
Conflicts:
test/integration/test-bug-747261-arch-specific-conflicts
fix tight loop detection and temporary removes2014-05-22T15:43:48ZDavid Kalnischkiesdavid@kalnischkies.de2014-05-17T10:37:13Zurn:sha1:0eb4af9d3d0c524c7afdc684238aa263ac287449
As outlined in #748355 apt segfaulted if it encountered a loop between a
package pre-depending on a package conflicting with the previous as it
ended up in an endless loop trying to unpack 'the other package'.
In this specific case as an essential package is involved a lot of force
needs to be applied, but can also be caused by 'normal' tight loops and
highlights a problem in how we handle breaks which we want to avoid.
The fix comes in multiple entangled changes:
1. All Smart* calls are guarded with loop detection. Some already had it,
some had parts of it, some did it incorrect, and some didn't even try.
2. temporary removes to avoid a loop (which is done if a loop is
detected) prevent the unpack of this looping package (we tried to unpack
it to avoid the conflict/breaks, but due to a loop we couldn't, so we
remove/deconfigure it instead which means we can't unpack it now)
3. handle conflicts and breaks very similar instead of duplicating most
of the code. The only remaining difference is, as it should:
deconfigure is enough for breaks, for conflicts we need the big hammer
consistently fail if Smart* packagemanager actions fail2014-05-22T15:43:48ZDavid Kalnischkiesdavid@kalnischkies.de2014-05-16T15:28:11Zurn:sha1:71e7a0f3a432828e5bd5498297051aa37e7f0a59
These failure conditions come with an error message attached and the
conditions aren't workaroundable (otherwise this would have been done
instead of returning failure), so not erroring out here means that we
execute dpkg later on with a known not-working ordering adding insult
(our own error messages at the end) to injury (dpkg failure).
fix some compile errors in the now enabled #if (APT_PKG_MAJOR >= 4 && APT_PKG_MINOR < 13)2014-05-07T19:39:53ZMichael Vogtmvo@debian.org2014-05-07T19:39:53Zurn:sha1:b58f28d4c4a06ef0a67cf3b6fe57aa08e7bc6b7efollow method attribute suggestions by gcc2014-03-13T12:58:45ZDavid Kalnischkiesdavid@kalnischkies.de2014-03-05T23:33:10Zurn:sha1:a02db58fd50ef7fc2f0284852c6b3f98e458a232
Git-Dch: Ignore
Reported-By: gcc -Wsuggest-attribute={pure,const,noreturn}
cleanup headers and especially #includes everywhere2014-03-13T12:58:45ZDavid Kalnischkiesdavid@kalnischkies.de2014-03-05T21:11:25Zurn:sha1:453b82a388013e522b3a1b9fcd6ed0810dab1f4f
Beside being a bit cleaner it hopefully also resolves oddball problems
I have with high levels of parallel jobs.
Git-Dch: Ignore
Reported-By: iwyu (include-what-you-use)
warning: unused parameter ‘foo’ [-Wunused-parameter]2014-03-13T12:58:45ZDavid Kalnischkiesdavid@kalnischkies.de2014-03-01T14:11:42Zurn:sha1:655122418d714f342b5d9789f45f8035f3fe8b9a
Reported-By: gcc -Wunused-parameter
Git-Dch: Ignore
fix some more ABI issues, abicheck is happy now2013-10-31T16:08:20ZMichael Vogtmvo@debian.org2013-10-31T16:08:20Zurn:sha1:c5f0d8e6f8d338727b2b6bc4be0e482082398014restore ABI and prepare next ABI via #if (APT_PKG_MAJOR >= 4 && APT_PKG_MINOR >= 13)2013-10-31T07:23:12ZMichael Vogtmvo@debian.org2013-10-31T07:23:12Zurn:sha1:bd5f39b34cc0e8cebbe9103f569d4d903e75bd2b