apt/apt-pkg/pkgcachegen.cc, branch 1.2.1Debians commandline package managerhttps://git.kalnischkies.de/apt/atom?h=1.2.12016-01-23T14:40:17ZRemap another (non-parameter) StringView2016-01-23T14:40:17ZJulian Andres Klodejak@debian.org2016-01-23T14:37:59Zurn:sha1:8ee09b58e9f061cf5296c54680e2b3386f83ff04
I only looked at parameters in the previous commit, which was
not enough: One place also generated local string views. In this
case, we only need to make ArchA dynamic, as NameA is not used
after the FindPkg() call.
Gbp-Dch: ignore
Remap StringView instances pointing into the cache2016-01-23T14:20:52ZJulian Andres Klodejak@debian.org2016-01-23T12:15:31Zurn:sha1:7dd0c2eb45874d3df9a9ee2034501659548a1b97
It turns out that StringViews might need to be remapped in some
places because they come from the cache. For example, some sites
pass a Ver.VerStr() to NewProvides().
Such a StringView would become invalid during the duration of
the call if the cache is remapped, causing the program to die
with a segmentation fault.
We can take care of those issues by remapping string views in
the same way we remap all the iterators. String views are only
remapped if they point into the cache though, this allows us
to write more generic code on the callee site without having
to check whether the view points into the cache or not.
That's not as efficient as possible, but the overhead does not
appear to be measurable.
Closes: #812251
Pass the old map size to ReMap()2016-01-23T14:13:04ZJulian Andres Klodejak@debian.org2016-01-23T14:02:48Zurn:sha1:19819ac58a420275e0ae9aa7e2a34c72cba8af5e
This allows us to check if a value to be remapped was inside
the cache or not, which will become useful at a later point.
Gbp-Dch: ignore
fix M-A:foreign provides creation for unknown archs2016-01-14T22:08:02ZDavid Kalnischkiesdavid@kalnischkies.de2016-01-14T19:13:16Zurn:sha1:62428dbc17ffa7b5b8188e88609a9438428d6024
Architectures for packages which do not belong to the native nor a
foreign architecture (dubbed barbarian for now) which are marked
M-A:foreign still provide in their own architecture even if not for
others. Also, other M-A:foreign (and allowed) packages provide in these
barbarian architectures.
Store the size of strings in the cache2016-01-08T20:20:25ZJulian Andres Klodejak@debian.org2016-01-08T10:12:14Zurn:sha1:60d523e2ae93a6c5bc396b6bede2544271fb1f2e
By storing the size of the string in the cache, we can make use of
it when comparing the names in the hashtable in pkgCache::FindGrp.
pkgCacheGenerator: CurMd5.Value() cannot be empty2016-01-08T11:23:08ZJulian Andres Klodejak@debian.org2016-01-08T11:15:11Zurn:sha1:24c7db2edea692c3778c021c053a2316203bfa03
It makes no sense to check if the value is empty, as it cannot
be. It will always be a hexstring of exactly 32 bytes.
pkgCacheGenerator::StoreString: Get rid of std::string2016-01-08T00:30:18ZJulian Andres Klodejak@debian.org2016-01-08T00:27:01Zurn:sha1:869700d839a1695fe00734592bd504d59386e4b9
Instead of storing a string -> map_stringitem_t mapping, create
our own data type that can point to either a normal string or
a string inside the cache.
This avoids the creation of any string and improves performance
slightly (about 4%).
Replace compare() == 0 checks with this == other checks2016-01-07T23:52:29ZJulian Andres Klodejak@debian.org2016-01-07T23:52:29Zurn:sha1:57590d3c6e6b055402c938c3baebf1d872c58f7e
This improves performance, as we now can ignore unequal strings
based on their length already.
Gbp-Dch: ignore
pkgCacheGenerator: Use StringView for toString2016-01-07T23:41:14ZJulian Andres Klodejak@debian.org2016-01-07T23:41:14Zurn:sha1:dd592790c8f1be4925f74266742c163516ab80c7
This removes some minor overhead.
Gbp-Dch: ignore
pkgCacheGenerator::StoreString: Move the string into the map2016-01-07T23:32:26ZJulian Andres Klodejak@debian.org2016-01-07T23:25:45Zurn:sha1:c5a858e39f83676fdf16f1bdae5966c96ee882ff
Moving the string is likely faster than copying it. We could probably
avoid strings alltogether in the future using some more crazy code,
but I have not looked at that yet.
Gbp-Dch: ignore