apt/apt-pkg/pkgcachegen.cc, branch 1.6_alpha7Debians commandline package managerhttps://git.kalnischkies.de/apt/atom?h=1.6_alpha72017-12-24T09:31:29Zdo not remap current files if nullptrs in cache generation2017-12-24T09:31:29ZDavid Kalnischkiesdavid@kalnischkies.de2017-12-24T09:31:29Zurn:sha1:5ba048a475cfd728906875327ddceed4614a1c9d
If the cache needs to grow to make room to insert volatile files like
deb files into the cache we were remapping null-pointers making them
non-null-pointers in the process causing trouble later on.
Only the current Releasefile pointer can currently legally be a
nullpointer as volatile files have no release file they belong to, but
for safety the pointer to the current Packages file is equally guarded.
The option APT::Cache-Start can be used to workaround this problem.
Reported-By: Mattia Rizzolo on IRC
convert various c-style casts to C++-style2017-12-13T22:53:34ZDavid Kalnischkiesdavid@kalnischkies.de2017-12-13T12:26:38Zurn:sha1:957381a0d26ec11a172ebfc64f892d1b31f0c193
gcc was warning about ignored type qualifiers for all of them due to the
last 'const', so dropping that and converting to static_cast in the
process removes the here harmless warning to avoid hidden real issues in
them later on.
Reported-By: gcc
Gbp-Dch: Ignore
deprecate the single-line deprecation ignoring macro2017-12-13T22:53:26ZDavid Kalnischkiesdavid@kalnischkies.de2017-12-13T11:51:26Zurn:sha1:5d5ca1aac76448cdfd16972090d246c44671dce6
gcc has problems understanding this construct and additionally thinks it
would produce multiple lines and stuff, so to keep using it isn't really
worth it for the few instances we have: We can just write the long form
there which works better.
Reported-By: gcc
Gbp-Dch: Ignore
Reformat and sort all includes with clang-format2017-07-12T11:57:51ZJulian Andres Klodejak@debian.org2017-07-12T11:40:41Zurn:sha1:87274d0f22e1dfd99b2e5200e2fe75c1b804eac3
This makes it easier to see which headers includes what.
The changes were done by running
git grep -l '#\s*include' \
| grep -E '.(cc|h)$' \
| xargs sed -i -E 's/(^\s*)#(\s*)include/\1#\2 include/'
To modify all include lines by adding a space, and then running
./git-clang-format.sh.
Drop cacheiterators.h include2017-07-12T11:56:05ZJulian Andres Klodejak@debian.org2017-07-12T11:42:18Zurn:sha1:c46f94aa48a9707668c46118b3eec77ff318b78c
Including cacheiterators.h before pkgcache.h fails because
pkgcache.h depends on cacheiterators.h.
avoid validate/delete/load race in cache generation2017-01-19T01:13:54ZDavid Kalnischkiesdavid@kalnischkies.de2017-01-19T01:13:54Zurn:sha1:06606f073210fe3902fe92d5ff77fa1ab621b972
Keeping the Fd of the cache file we have validated around to later load
it into the mmap ensures not only that we load the same file (which
wouldn't really be a problem in practice), but that this file also still
exists and wasn't deleted e.g. by a 'apt clean' call run in parallel.
Do not use MD5SumValue for Description_md5()2016-11-22T21:58:33ZJulian Andres Klodejak@debian.org2016-09-27T22:49:45Zurn:sha1:49521f87851089bdb4097b715d09a8bd348aa60a
Our profile says we spend about 5% of the time transforming the
hex digits into the binary format used by HashsumValue, all for
comparing them against the other strings. That makes no sense
at all.
According to callgrind, this reduces the overall instruction
count from 5,3 billion to 5 billion in my example, which
roughly matches the 5%.
Compare size before data when ordering cache bucket entries2016-11-22T21:58:19ZJulian Andres Klodejak@debian.org2016-09-27T16:59:11Zurn:sha1:f378b41f9ab2493bcbc5892d482b18826b0b84c0
This has the effect of significantly reducing actual string
comparisons, and should improve the performance of FindGrp
a bit, although it's hardly measureable (callgrind says it
uses 10% instructions less now).
do not treat same-version local debs as downgrade2016-07-01T12:33:02ZDavid Kalnischkiesdavid@kalnischkies.de2016-07-01T12:00:47Zurn:sha1:cb9ac09bd6a36e73c2dce1d529acde6e4d15e32d
As the volatile sources are parsed last they were sorted behind the
dpkg/status file and hence are treated as a downgrade, which isn't
really what you want to happen as from a user POV its an upgrade.
Prevent double remapping of iterators and string views2016-03-06T13:57:41ZJulian Andres Klodejak@debian.org2016-03-06T13:44:53Zurn:sha1:9e7f83533665c03b52dff5809e7ebd93928ea445
If an iterator or a stringview has multiple dynamic objects
registered with it, it may be remapped twice. Prevent that
by noting which iterators/views we have seen and not remapping
one if we have already seen it.
We most likely do not have any instance of multiple dynamics
on a single object, but let's play safe - the overhead is not
high.