apt/apt-pkg/pkgcachegen.cc, branch 1.7.0

Remove obsolete RCS keywords

2018-05-07T11:41:31Z

Prompted-by: Jakub Wilk

Fix various typos reported by spellcheckers

2018-05-04T22:34:27Z

Reported-By: codespell & spellintian Gbp-Dch: Ignore

do not remap current files if nullptrs in cache generation

2017-12-24T09:31:29Z

If the cache needs to grow to make room to insert volatile files like deb files into the cache we were remapping null-pointers making them non-null-pointers in the process causing trouble later on. Only the current Releasefile pointer can currently legally be a nullpointer as volatile files have no release file they belong to, but for safety the pointer to the current Packages file is equally guarded. The option APT::Cache-Start can be used to workaround this problem. Reported-By: Mattia Rizzolo on IRC

convert various c-style casts to C++-style

2017-12-13T22:53:34Z

gcc was warning about ignored type qualifiers for all of them due to the last 'const', so dropping that and converting to static_cast in the process removes the here harmless warning to avoid hidden real issues in them later on. Reported-By: gcc Gbp-Dch: Ignore

deprecate the single-line deprecation ignoring macro

2017-12-13T22:53:26Z

gcc has problems understanding this construct and additionally thinks it would produce multiple lines and stuff, so to keep using it isn't really worth it for the few instances we have: We can just write the long form there which works better. Reported-By: gcc Gbp-Dch: Ignore

Reformat and sort all includes with clang-format

2017-07-12T11:57:51Z

This makes it easier to see which headers includes what. The changes were done by running git grep -l '#\s*include' \ | grep -E '.(cc|h)$' \ | xargs sed -i -E 's/(^\s*)#(\s*)include/\1#\2 include/' To modify all include lines by adding a space, and then running ./git-clang-format.sh.

Drop cacheiterators.h include

2017-07-12T11:56:05Z

Including cacheiterators.h before pkgcache.h fails because pkgcache.h depends on cacheiterators.h.

avoid validate/delete/load race in cache generation

2017-01-19T01:13:54Z

Keeping the Fd of the cache file we have validated around to later load it into the mmap ensures not only that we load the same file (which wouldn't really be a problem in practice), but that this file also still exists and wasn't deleted e.g. by a 'apt clean' call run in parallel.

Do not use MD5SumValue for Description_md5()

2016-11-22T21:58:33Z

Our profile says we spend about 5% of the time transforming the hex digits into the binary format used by HashsumValue, all for comparing them against the other strings. That makes no sense at all. According to callgrind, this reduces the overall instruction count from 5,3 billion to 5 billion in my example, which roughly matches the 5%.

Compare size before data when ordering cache bucket entries

2016-11-22T21:58:19Z

This has the effect of significantly reducing actual string comparisons, and should improve the performance of FindGrp a bit, although it's hardly measureable (callgrind says it uses 10% instructions less now).