apt/apt-pkg/pkgcachegen.cc, branch 2.9.15Debians commandline package managerhttps://git.kalnischkies.de/apt/atom?h=2.9.152024-11-14T17:41:26Zstd::string_view const & -> std::string_view2024-11-14T17:41:26Zнабnabijaczleweli@nabijaczleweli.xyz2024-11-14T17:37:57Zurn:sha1:323fcee3730fc8e3edd555f458bf260382f6d3ef
Fixes: 2c03eed649068c8838d971ceeb1a09603dcc8e9c
apt-pkg/pkgcachegen.cc, apt-pkg/pkgcachegen.h: APT::StringView -> std::string_view2024-11-12T19:36:20Zнабnabijaczleweli@nabijaczleweli.xyz2024-11-12T16:59:23Zurn:sha1:e900ad1a727912b340aa43417bff895294854d3bapt-pkg/edsp/edsplistparser.cc: APT::StringView -> std::string_view2024-11-12T19:36:16Zнабnabijaczleweli@nabijaczleweli.xyz2024-11-12T16:59:21Zurn:sha1:982998a061461a503352d85b1d0a76a99c8480cdpkgcachegen: Do not try to chmod or write to /dev/null2024-05-22T20:48:04ZJulian Andres Klodejulian.klode@canonical.com2024-05-22T20:46:31Zurn:sha1:140d36fd16a3d4f1fce0c54474b946d0577f1fde
When -o Dir::Cache::pkgcache or -o Dir::Cache is set to /dev/null
we accidentally changed its mode to 0666; which is certainly not
intended. Avoid this issue by exiting the function early if the
file specified is /dev/null.
Modernize standard library includes2024-02-20T12:49:04ZJulian Andres Klodejulian.klode@canonical.com2024-02-20T12:43:08Zurn:sha1:40a75722c43ae24cb9a99d6730a3b25b65819c49
This was automated with sed and git-clang-format, and then I had to
fix up the top of policy.cc by hand as git-clang-format accidentally
indented it by two spaces.
pkgcachegen: Use placement new to construct header2024-01-12T12:49:24ZJulian Andres Klodejulian.klode@canonical.com2024-01-12T12:47:52Zurn:sha1:0ee745995b1f45ed321b0c20b151ec8e76e4344f
Avoid copying the header from a stack allocated object as this
will copy uninitialized padding bytes into the cache, triggering
valgrind errors which people then use as a strawman for unrelated
errors on armhf.
In an optimal world we should annotate the allocator however such
that valgrind actually does treat those bytes as uninitialized and
then supress warnings in the harmless places, such that when you
then go and try to access it in a place that matters, you do get
an error for uninitialized memory.
Currently any access within the pool will be considered initialized
which is clearly suboptimal. But this is very much a TBD topic and
involves annotating the allocator everywhere.
Compare SHA256 to check if versions are really the same2023-08-02T10:04:32ZJulian Andres Klodejulian.klode@canonical.com2023-08-01T11:59:09Zurn:sha1:5576e7f76da73f3f5217f90d816cc19b6c0a5a77
If we know both SHA256, and they're different, the packages are. This
approach stores the SHA256 only at runtime, avoiding the overhead of
storing it on-disk, because when we update repositories we update all
of them anyhow.
Note that pkgCacheGenerator is hidden, so we can just modify its
ABI, hooray.
Closes: #931175
LP: #2029268
Do not make provides of M-A:allowed implicit M-A:foreign2021-09-04T13:35:15ZDavid Kalnischkiesdavid@kalnischkies.de2021-09-03T18:45:04Zurn:sha1:20745375afb333fd3d442006f3c6ebbebe195dab
As we don't know which architectures we will deal with and to avoid
creating many "unneeded" packages (and provides) the cache
generation uses a scheme of on-demand creation (see ecc138f858).
This assumed a particular handling of :any which got changed later
(3addaba1ff) making this code path not only no longer needed for
M-A:allowed, but actually wrong as it would go on and create provides
for the explicit Provides of a package as if the package would be
M-A:foreign.
The result was that a package A:amd64 providing B tagged as M-A:allowed
would satisfy a "C:armel depends on B". Note that this bug does NOT
effect "C:armel depends on A" which is (correctly) not satisfied as
before.
References: ecc138f858, 3addaba1ff
Use size of the old cache as APT::Cache-Start default2021-02-04T10:00:00ZDavid Kalnischkiesdavid@kalnischkies.de2021-02-03T21:41:56Zurn:sha1:a158e78152316f56b1a324a42a2f00f0a8662ac3
Depending on your configured source 25 MB is hardly enough, so the mmap
housing the cache while it is build has to grow. Repeatedly. We can cut
down on the repeats of this by keeping a record of the size of the old
cache assuming the sizes will remain roughly in the same ballpark.
Avoid undefined pointer arithmetic while growing mmap2021-02-04T10:00:00ZDavid Kalnischkiesdavid@kalnischkies.de2020-06-08T15:07:43Zurn:sha1:f7e6eaf84bebac565f462e2ce48f30808cc771eb
The undefined behaviour sanitizer complains with:
runtime error: addition of unsigned offset to 0x… overflowed to 0x…
Compilers and runtime do the right thing in any case and it is a
codepath that can (and ideally should) be avoided for speed reasons
alone, but fixing it can't hurt (too much).