apt/apt-pkg/pkgcachegen.h, branch 1.4_rc2 Debians commandline package manager https://git.kalnischkies.de/apt/atom?h=1.4_rc2 2016-11-22T21:58:33Z Do not use MD5SumValue for Description_md5() 2016-11-22T21:58:33Z Julian Andres Klode jak@debian.org 2016-09-27T22:49:45Z urn:sha1:49521f87851089bdb4097b715d09a8bd348aa60a Our profile says we spend about 5% of the time transforming the hex digits into the binary format used by HashsumValue, all for comparing them against the other strings. That makes no sense at all. According to callgrind, this reduces the overall instruction count from 5,3 billion to 5 billion in my example, which roughly matches the 5%. deal better with (very) small apt::cache-start values 2016-01-26T23:15:12Z David Kalnischkies david@kalnischkies.de 2016-01-26T23:15:12Z urn:sha1:a133f79c8766aee5b7d7811285e60b3d311d8473 It is a bit academic to support values which aren't big enough to fit even the hashtables without resizing, but cleaning up ensures that we do the right thing (aka not segfaulting) even if something goes wrong in these deep layers. You still can't have very very small values through… Git-Dch: Ignore convert Version() and Architecture() to APT::StringView 2016-01-26T22:18:05Z David Kalnischkies david@kalnischkies.de 2016-01-26T22:18:05Z urn:sha1:8efd5947bf7de0fc3db51b4871bcf3522018761d Part of hidden classes, so conversion is abi-free. Git-Dch: Ignore remove unused Description methods in listparsers 2016-01-26T20:58:57Z David Kalnischkies david@kalnischkies.de 2016-01-26T20:58:57Z urn:sha1:02ceb810fe0de9b267a8b6a302505967afce6b5a These virtual methods are implemented in hidden classes, so we can drop them without breaking the ABI. Git-Dch: Ignore Delete copy constructor and operator= for Dynamic 2016-01-26T11:45:32Z Julian Andres Klode jak@debian.org 2016-01-26T11:42:39Z urn:sha1:96f66f82cfcd3f21f73542375f9c722ac907c076 This would mess up reference counting and should not be allowed (it could be implemented correctly, but it would not be efficient and we do not need it). Gbp-Dch: ignore Pass the old map size to ReMap() 2016-01-23T14:13:04Z Julian Andres Klode jak@debian.org 2016-01-23T14:02:48Z urn:sha1:19819ac58a420275e0ae9aa7e2a34c72cba8af5e This allows us to check if a value to be remapped was inside the cache or not, which will become useful at a later point. Gbp-Dch: ignore pkgCacheGenerator::hash: Do not call tolower_ascii() 2016-01-08T00:34:53Z Julian Andres Klode jak@debian.org 2016-01-08T00:34:53Z urn:sha1:a0e3c0f55dc20b90f5f7d6d162135c9fef370686 Gbp-Dch: ignore pkgCacheGenerator::StoreString: Get rid of std::string 2016-01-08T00:30:18Z Julian Andres Klode jak@debian.org 2016-01-08T00:27:01Z urn:sha1:869700d839a1695fe00734592bd504d59386e4b9 Instead of storing a string -> map_stringitem_t mapping, create our own data type that can point to either a normal string or a string inside the cache. This avoids the creation of any string and improves performance slightly (about 4%). pkgCacheGenerator: Use StringView for toString 2016-01-07T23:41:14Z Julian Andres Klode jak@debian.org 2016-01-07T23:41:14Z urn:sha1:dd592790c8f1be4925f74266742c163516ab80c7 This removes some minor overhead. Gbp-Dch: ignore Switch performance critical code to use APT::StringView 2016-01-07T18:59:08Z Julian Andres Klode jak@debian.org 2016-01-07T18:16:23Z urn:sha1:eff0c22e59e65b6b63e854ff41eb091278e05714 This improves performance of the cache generation on my ARM platform (4x Cortex A15) by about 10% to 20% from 2.35-2.50 to 2.1 seconds.