Debians commandline package manager https://git.kalnischkies.de/apt/atom?h=2.9.27 2025-01-30T14:36:10Z 2025-01-30T14:36:10Z Julian Andres Klode julian.klode@canonical.com 2025-01-30T14:34:51Z urn:sha1:945ead2ab03b7c83b3fbaecf3e1e543525e476f0 Gbp-Dch: ignore 2025-01-30T13:50:15Z Julian Andres Klode julian.klode@canonical.com 2024-11-02T12:55:39Z urn:sha1:3523efb15d48ce3c6f9212f50dfc892497ba9dcb Instead of directly propagating in a recursive fashion, queue propagations in a queue and work on them in a loop per the miniSAT paper. We call Propagate() only at the end of the FromDepCache() function and then in the Solve loop. Delaying the initial propagation means that we get a stronger reasoning: Assume you have x->a->b->c, y->c and you install x,y: - Previously we traversed: x, y, x->a, a->b, b->c, (y->c) - but now we traverse: x, y, x->a, y->c, a->b, (b->c) Notably c now has the implication y->c instead of x->a->b->c. Inside the solver we need to call Propagate in a loop: Propagating facts can fail and we then backtrack. If backtracking is succesful, we have gained a new fact to propagate. 2025-01-30T13:50:15Z Julian Andres Klode julian.klode@canonical.com 2024-11-02T12:54:04Z urn:sha1:ccdbea353a30de597a00a88cf4c7216370a21882 Do not enqueue common dependencies if a version is selected already, this avoids test suites changing now in behavior as the ordering is different. 2025-01-30T13:50:15Z Julian Andres Klode julian.klode@canonical.com 2025-01-30T12:46:09Z urn:sha1:45432cc57144715109f27d0bb83356b12e2a4ef5 This is more or less unused; but it particularly has the bad problem of forcing new unsat recommends to be solved *before* dependencies. Which is awkward. 2025-01-30T13:50:15Z Julian Andres Klode julian.klode@canonical.com 2025-01-30T12:04:47Z urn:sha1:a20242cf3a7321e78cfd4afd892d67255d8282ba If both items are optional, unit items should be processed first. 2025-01-05T22:16:08Z David Kalnischkies david@kalnischkies.de 2024-12-26T19:41:53Z urn:sha1:f73593a4034d9eec0ec4466b8e173d4a4daece1f We were rather inconsistent in using it and as our public headers contain deduction guides (a c++17 feature) it seems silly to try to hide a c++11 feature in a macro, so lets stop this charade and drop the macro and while we are changing all these lines lets apply [[nodiscard]] (another c++17 feature) and other suggestions from clang-tidy and formatting for a little more consistency. 2024-12-03T08:44:18Z Julian Andres Klode julian.klode@canonical.com 2024-11-02T11:45:07Z urn:sha1:8f317d97c9fb821e839342ae445c824207678eb7 Reimplement strict pinning by rejecting the non-candidates when translating the problem from the depcache to the solver. This is substantially better than restricting the list of alternatives for an or group to only include allowed ones for debugging purposes, albeit a bit slower. 2024-12-03T08:44:18Z Julian Andres Klode julian.klode@canonical.com 2024-12-03T08:43:34Z urn:sha1:3e5977ed7b4e6291fcd67df193a501754ec1de7f 2024-12-02T10:37:16Z Julian Andres Klode julian.klode@canonical.com 2024-12-02T09:25:44Z urn:sha1:63721d8271430c1a0996c08cc96a3a7e6f69dc52 We only compared candidate to installed version, but candidate should dominate all versions, otherwise we end up in the fancy problem of elpa-notmuch in upgrade-noble-t64-remove-desktop-2024-03-29.edsp Where we had three versions: not-installable 0.38.3-1ubuntu1 candidate 0.38.2-1.1ubuntu2 installed 0.38.2-1ubuntu2 And received an ordering: installed > non-installable > candidate despite candidate > installed This is only visible with no-strict-pinning right now, as we are otherwise filtering out invalid choices (and hence we only have candidate and installed otherwise). 2024-11-02T12:17:11Z Julian Andres Klode julian.klode@canonical.com 2024-11-02T12:13:51Z urn:sha1:9f40a9a3251cc6b51bc50a5fe12c49a45a51aedd This is the first part of changing from Install() to Enqueue() for installs, affecting only the versions. For packages, we still have to resolve the group changing: When propagating cleanly, we don't have the information as to which group the package was part of, hence we are no longer able to queue the version selection of upgrades before obsolete packages, for example, which needs solving.