apt/apt-pkg/srcrecords.cc, branch 1.3.1Debians commandline package managerhttps://git.kalnischkies.de/apt/atom?h=1.3.12015-09-14T13:22:18Zavoid using global PendingError to avoid failing too often too soon2015-09-14T13:22:18ZDavid Kalnischkiesdavid@kalnischkies.de2015-09-10T17:00:51Zurn:sha1:95278287f4e1eeaf5d96749d6fc9bfc53fb400d0
Our error reporting is historically grown into some kind of mess.
A while ago I implemented stacking for the global error which is used in
this commit now to wrap calls to functions which do not report (all)
errors via return, so that only failures in those calls cause a failure
to propergate down the chain rather than failing if anything
(potentially totally unrelated) has failed at some point in the past.
This way we can avoid stopping the entire acquire process just because a
single source produced an error for example. It also means that after
the acquire process the cache is generated – even if the acquire
process had failures – as we still have the old good data around we can and
should generate a cache for (again).
There are probably more instances of this hiding, but all these looked
like the easiest to work with and fix with reasonable (aka net-positive)
effects.
Make apt compile with clang++ again2015-08-14T17:44:25ZMichael Vogtmvo@debian.org2015-08-14T17:44:25Zurn:sha1:f8043f219f077b1cfc6c5ad2263c4caa4709a00d
This allows us to run the clang static analyzer and to run the
testsuite with the clang MemorySanitizer.
make all d-pointer * const pointers2015-08-10T15:25:25ZDavid Kalnischkiesdavid@kalnischkies.de2015-06-17T07:29:00Zurn:sha1:6c55f07a5fa3612a5d59c61a17da5fe640eadc8b
Doing this disables the implicit copy assignment operator (among others)
which would cause hovac if used on the classes as it would just copy the
pointer, not the data the d-pointer points to. For most of the classes
we don't need a copy assignment operator anyway and in many classes it
was broken before as many contain a pointer of some sort.
Only for our Cacheset Container interfaces we define an explicit copy
assignment operator which could later be implemented to copy the data
from one d-pointer to the other if we need it.
Git-Dch: Ignore
apply various style suggestions by cppcheck2015-08-10T15:24:01ZDavid Kalnischkiesdavid@kalnischkies.de2015-06-16T22:14:10Zurn:sha1:e8afd16892e87a6e2f17c1019ee455f5583387c2
Some of them modify the ABI, but given that we prepare a big one
already, these few hardly count for much.
Git-Dch: Ignore
use 'best' hash for source authentication2014-11-10T16:23:29ZDavid Kalnischkieskalnischkies@gmail.com2013-08-18T21:27:24Zurn:sha1:3a2b39ee602dd5a98b8fdaee2f1c8e0b13a276e2
Collect all hashes we can get from the source record and put them into a
HashStringList so that 'apt-get source' can use it instead of using
always the MD5sum.
We therefore also deprecate the MD5 struct member in favor of the list.
While at it, the parsing of the Files is enhanced so that records which
miss "Files" (aka MD5 checksums) are still searched for other checksums
as they include just as much data, just not with a nice and catchy name.
This is a cherry-pick of 1262d35 with some dirty tricks to preserve ABI.
LP: 1098738
use pkgSrcRecords::Step() instead of Next()2014-06-10T13:07:15ZMichael Vogtmvo@debian.org2014-06-10T13:07:15Zurn:sha1:401e5db12dd71ed84e8d17a559ff5932c1b98367add pkgSrcRecords::Next() to step through all the pkgSrcRecords2014-06-09T07:57:58ZMichael Vogtmvo@ubuntu.com2014-06-09T07:06:07Zurn:sha1:462557017a0d8be321ca7d3eb96072f4db6a92eccleanup headers and especially #includes everywhere2014-03-13T12:58:45ZDavid Kalnischkiesdavid@kalnischkies.de2014-03-05T21:11:25Zurn:sha1:453b82a388013e522b3a1b9fcd6ed0810dab1f4f
Beside being a bit cleaner it hopefully also resolves oddball problems
I have with high levels of parallel jobs.
Git-Dch: Ignore
Reported-By: iwyu (include-what-you-use)
restart debSrcRecordParsers only if needed2014-01-29T23:16:20ZDavid Kalnischkiesdavid@kalnischkies.de2014-01-29T22:24:41Zurn:sha1:6a9c9d63edc878ff268cdaa4f985ca50c48380b0
The offset variable in DebSrcRecordParser was not initialized which we
now do and based on it do not trigger a restart if the parser was not
used yet avoiding a needless rescan of the section.
Detected while working on the previous commit e62aa1dd. Both commits act
as a "fix" for the bug shown in the testcase of the commit – this one
here would only hide it through.
various simple changes to fix cppcheck warnings2013-03-10T11:24:13ZDavid Kalnischkieskalnischkies@gmail.com2013-03-10T11:24:13Zurn:sha1:69c2ecbdc937e3c73fe67d3c9bce12a80d3ec7ec