Debians commandline package manager https://git.kalnischkies.de/apt/atom?h=1.2.6 2016-01-07T18:59:08Z 2016-01-07T18:59:08Z Julian Andres Klode jak@debian.org 2016-01-07T18:16:23Z urn:sha1:eff0c22e59e65b6b63e854ff41eb091278e05714 This improves performance of the cache generation on my ARM platform (4x Cortex A15) by about 10% to 20% from 2.35-2.50 to 2.1 seconds. 2016-01-02T15:19:40Z David Kalnischkies david@kalnischkies.de 2016-01-02T11:25:29Z urn:sha1:55153bf94ff28a23318e79aa48242244c4d82b3c APT usually deals with perfectly formatted files generated automatically be other programs – and as it has to parse multiple MBs of such files it tries to be fast rather than forgiving. This was always a problem if we reused this parser for files with a deb822 syntax which are mostly written by hand however, like apt_preferences or the deb822-style sources as these can include stray newlines and more importantly comments all over the place. As a stopgap we had pkgUserTagSection which deals at least with comments before and after a given stanza, but comments in between weren't really supported and now that we support parsing debian/control for e.g. build-dep we face the full comment problem e.g. with comments inbetween multi-line fields (like Build-Depends). We can't easily deal with this on the pkgTagSection level as the interface gives access to 'raw' char-pointers for performance reasons so we would need to optionally add a buffer here on which we could remove comments to hand out pointers into this buffer instead. The interface is quite large already and supports writing stanzas as well, which does not support comments at all either. So while in future it might make sense to have a parser setup which deals with and keeps comments in this commit we opt for the simpler solution for now: We officially declare that pkgTagSection does not support comments and instead expect the caller to deal with them, which in our case is pkgTagFile: pkgTagFile is extended with an additional mode which can deal with comments by dropping them from the buffer which will later form the input of pkgTagSection. The actual implementation is slightly more complex than this sentence suggests at first on one hand to have good performance and on the other to allow jumping directly to stanzas with offsets collected in a previous run (like our cache generation does it for example). 2015-12-29T13:37:14Z Julian Andres Klode jak@debian.org 2015-12-29T13:37:14Z urn:sha1:67c90775b650efe89d7d784cf913526cc3b63d07 We ignored the boundary of the buffer we were reading in while scanning for spaces. 2015-12-27T20:52:01Z David Kalnischkies david@kalnischkies.de 2015-12-27T20:52:01Z urn:sha1:c72f5c4fb4b1d496a9bbdb421f25e986f0cba9bf Regression introduced in 8710a36a01c0cb1648926792c2ad05185535558e, but such fields are unlikely in practice as it is just as simple to not have a field at all with the same result of not having a value. Closes: 808102 2015-12-27T00:20:41Z Julian Andres Klode jak@debian.org 2015-12-26T23:51:59Z urn:sha1:74dedb4ae28fd4f7c89bf769708d4f7edc7ed79a This converts all callers that read machine-generated data, callers that might work with user input are not converted. 2015-12-14T12:58:46Z Julian Andres Klode jak@debian.org 2015-12-14T12:58:46Z urn:sha1:137e8ad4b6ce28b1a1355d5a125d09670388c2b7 This makes the test suite work on 32 bit-long platforms. Gbp-Dch: ignore 2015-08-12T18:51:08Z Julian Andres Klode jak@debian.org 2015-08-12T18:44:40Z urn:sha1:809aa216c630f1cc61b0c3b9d992d4a3be14be3c Treat invalid pin priorities and overflows as an error. Closes: #429912 2015-08-10T15:27:58Z David Kalnischkies david@kalnischkies.de 2015-07-15T12:36:16Z urn:sha1:dfe66c72ffc010e019e96b35154e1ad4ab506a6e We store very few flags in the cache, so keeping storage space for 8 is enough for all of them and still leaves a few unused bits remaining for future extensions without wasting bytes for nothing. Git-Dch: Ignore 2015-08-10T15:27:58Z David Kalnischkies david@kalnischkies.de 2015-07-15T11:21:21Z urn:sha1:4dc77823d360158d6870a5710cc8c17064f1308f We aren't and we will not be really compatible again with the previous stable abi, so lets drop these markers (which never made it into a released version) for good as they have outlived their intend already. Git-Dch: Ignore 2015-08-10T15:25:26Z David Kalnischkies david@kalnischkies.de 2015-06-21T21:12:24Z urn:sha1:81460e32961bb0b9922bf8a1a27d87705d8c3e51 Having two different formats in the same file is very dirty and causes external tools to fail hard trying to parse them. It is probably not a good idea for them to parse them in the first place, but they do and we shouldn't break them if there is a better way. So we solve this issue for now by giving our deb822 format a new filename extension ".sources" which unsupporting applications are likely to ignore an can begin gradually moving forward rather than waiting for the unknown applications to catch up. Currently and for the forseeable future apt is going to support both with the same feature set as documented in the manpage, with the longtime plan of adopting the 'new' format as default, but that is a long way to go and might get going more from having an easier time setting options than from us pushing it explicitely.