apt/apt-pkg/tagfile.cc, branch 1.9.9

Follow gcc-9 -Wnoexcept suggestion for FileChunk constructor

2019-04-16T10:59:54Z

warning: but ‘pkgTagFilePrivate::FileChunk::FileChunk(bool, size_t)’ does not throw; perhaps it should be declared ‘noexcept’ [-Wnoexcept] Reported-By: gcc-9 Gbp-Dch: Ignore

tagfile: Remove deprecated pkgUserTagSection and TFRewrite

2019-02-26T15:31:20Z

Step over empty sections in TagFiles with comments

2019-02-01T13:51:56Z

Implementing a parser with recursion isn't the best idea, but in practice we should get away with it for the time being to avoid needless codechurn. Closes: #920317 #921037

Remove obsolete RCS keywords

2018-05-07T11:41:31Z

Prompted-by: Jakub Wilk

Reformat and sort all includes with clang-format

2017-07-12T11:57:51Z

This makes it easier to see which headers includes what. The changes were done by running git grep -l '#\s*include' \ | grep -E '.(cc|h)$' \ | xargs sed -i -E 's/(^\s*)#(\s*)include/\1#\2 include/' To modify all include lines by adding a space, and then running ./git-clang-format.sh.

fix various typos reported by spellintian

2017-01-19T14:59:38Z

Most of them in (old) code comments. The two instances of user visible string changes the po files of the manpages are fixed up as well. Gbp-Dch: Ignore Reported-By: spellintian

TagSection: Introduce functions for looking up by key ids

2016-11-22T21:57:46Z

Introduce a new enum class and add functions that can do a lookup with that enum class. This uses triehash.

TagSection: Extract Find() methods taking Pos instead of Key

2016-11-22T21:56:46Z

This allows us to add a perfect hash function to the tag file without having to reimplement the methods a second time.

TagSection: Split AlphaIndexes into AlphaIndexes and BetaIndexes

2016-11-22T21:47:35Z

Move the use of the AlphaHash to a new second hash table in preparation for the arrival of the new perfect hash function. With the new perfect hash function hashing most of the keys for us, having 128 slots for a fallback hash function seems enough and prevents us from wasting space.

TagFile: Fix off-by-one errors in comment stripping

2016-08-31T15:39:06Z

Adding 1 to the value of d->End - current makes restLength one byte too long: If we pass memchr(current, ..., restLength) has thus undefined behavior. Also, reading the value of current has undefined behavior if current >= d->End, not only for current > d->End: Consider a string of length 1, that is d->End = d->Current + 1. We can only read at d->Current + 0, but d->Current + 1 is beyond the end of the string. This probably caused several inexplicable build failures on hurd-i386 in the past, and just now caused a build failure on Ubuntu's amd64 builder. Reported-By: valgrind